03:14:41 <jberman[m]> Hey all, I found and reported a bug in the decoy selection algo:
03:14:41 <jberman[m]> https://github.com/monero-project/monero/blob/de3456e1275836725291ba71036b7ef0e2cda91f/src/wallet/wallet2.cpp#L1022
03:14:41 <jberman[m]> It's doing integer division there, but it seems it should be doing normal division. `average_output_time` is therefore underestimated. Today it's underestimated by a factor of nearly 2x (`average_output_time` should work out to ~1.9 today, but integer division rounds the result down to 1). I believe this means that the decoy distribution produced by the client would be shifted over to the right by a factor of nearly ~2 today (the output
03:14:41 <jberman[m]> selected using the modified `average_output_time` approach is ~2x "later" than it should be)
03:15:46 * jberman[m]  < https://libera.ems.host/_matrix/media/r0/download/libera.chat/23c74dfbbdaa19e8c997eee17020a143b2fec036/message.txt >
03:19:00 <jberman[m]> Fix is super simple. Just need to cast one of those values to a double. Talked about it with devs, requesting push rights to add it
03:30:51 <mj-xmr> jberman[m], aaaah. Classic.
03:31:08 <mj-xmr> ideally cast the divisor to double.
03:31:40 <mj-xmr> and with static_cast<double?(outputs_to_consider
03:31:47 <mj-xmr> >
03:35:45 <jberman[m]> will do 🙂
03:37:53 * jberman[m]  < https://libera.ems.host/_matrix/media/r0/download/libera.chat/a36275136edcbb4b8280b6d4fdc6b6bae81e4c16/message.txt >
03:44:03 <jberman[m]> 1 is probably easier than I suggested. Maybe could just try and fit the decoy selection to a gamma distribution and see how different it is from the expected shape and scale/allow some tolerance? something like that
03:48:43 <wowario> also try avoid selecting coinbase outputs as decoys
03:49:28 <wowario> sgp proposed the idea a few years ago
03:51:40 <sarang> The point of using average output times is to avoid selection bias based on block density, to mitigate things like coinbase overselection
03:52:04 <sarang> (but it helps mitigate general over- or under-selection)
03:53:57 <sgp_[m]> Coinbase outputs are a different assumption though because they're already marked as a different type
03:54:50 <sgp_[m]> Sanity checks have been suggested in the past but I believe the added complexity was the main drawback
03:55:28 <sarang> Plus it doesn't fully solve the issues with coinbase in rings
04:11:56 <jberman[m]> It would protect a user who randomly gets a distribution of 10 decoys that is off from the gamma distribution, even though their median is within the last 60% of all outputs. not sure how prevalent that is though. Though not sure how prevalent that is
04:13:21 <jberman[m]> I get the complexity drawback too
04:15:01 <jberman[m]> 40%* of all outputs
04:19:29 <jberman[m]> The client is over-requesting outputs, it just seems like it can be a bit smarter when selecting the final 10 to include to make its selection look more like others
04:21:50 <UkoeHB> jberman[m]: the ring binning proposal has that effect
04:23:11 <jberman[m]> true, I guess it would be a bit pointless to spend time adding complexity there if that general algorithm is going to change dramatically soon anyway 
07:19:40 <mj-xmr> Not a reason to win a golden medal, maybe, but ccache under FreeBSD finally works :)
07:19:41 <mj-xmr> https://github.com/monero-project/monero/pull/7797
08:47:07 <mj-xmr> <jberman[m]> Fix is super simple. Just need to cast one of those values to a double. Talked about it with devs, requesting push rights to add it <-- if this takes too long, and since the patch is small, you can ask sb. with the rights to put it for you, mentioning your user name.
08:50:10 <jberman[m]> who's sb? I don't care to be the one to push it, seems unnecessary to hold anything back on account of that
08:50:34 <sech1> I can do it
08:55:14 <selsta> jberman[m]: luigi usually gives users repo access but he is afk for another week
08:57:01 <jberman[m]> he mentioned to reach out to fluffy to get access before he gets back (emailed fluffy). but not a big deal, seems sech1 's got it
08:58:48 <jberman[m]> I mean it would be cool to show my kids some day "this was my first contribution (really hoping of many) to the currency everyone uses every day" lol. but I'll live
09:02:52 <selsta> fluffypony: ^
09:05:16 <sech1> https://github.com/monero-project/monero/pull/7798
09:07:43 <sech1> and #7799
09:08:20 <selsta> sech1: you could use the git --author flag
09:08:50 <sech1> is it something I can still do now? I used GitHub Desktop
09:09:27 <selsta> do you have normal git somewhere?
09:09:52 <sech1> I can open command prompt from there, but you'll have to guide me with commands
09:09:58 <sech1> *git command prompt
09:10:02 <selsta> ok
09:10:11 <selsta> let's do in PM
10:12:52 <mj-xmr> jberman[m]> who's sb? <-- sorry for being too vague, but I didn't want to shill like "just send it to me" :)
12:57:52 <binaryFate> I can give github permissions too. Is everyone sorted already or can I help with anything?
13:00:03 <selsta> binaryFate: can you add https://github.com/j-berman to the repo?
13:13:33 <binaryFate> selsta: ok I think done
13:37:55 <fluffypony> ok cool j-berman has a pending invite, so that appears to be all sorted
18:36:29 <jberman[m]> accepted, thanks guys
18:37:14 <moneromooo> And thanks for the report and fix.
18:46:47 <jberman[m]> np :)
21:23:02 <mib_a0sl5msa> Hi
21:23:42 <mib_a0sl5msa> I am having an issue with getmonero wallet, I didnt received my sent monero, the wallet ID is correct. What shoud I do?
21:26:03 <moneromooo> Don't spam the same thing in many channels.
21:35:32 <mib_a0sl5msa> Sorry, I felt I am lost my monero. I know spam wont resolve, but hopefully :D