01:45:22 selsta shared my opinion and reasoning on the best path forward for 7798, and opened an additional issue that shows that extremely recent spents are likely identifiable in rings: https://github.com/monero-project/monero/issues/7807 01:45:45 yes, thanks for the writeup 01:45:55 I'm fine with only fixing the divide by zero 02:02:02 * jberman[m] < https://libera.ems.host/_matrix/media/r0/download/libera.chat/8644131ad6a19d34ca4bc0e9fbf43606c1943a00/message.txt > 03:10:21 Thanks for bridging, I would have missed 03:14:31 Is there a good reason not to just roll out both changes at once 03:14:43 It's not like selection is enforced by consensus anyway 03:36:15 There are a couple reasons: 03:36:15 1. Not 100% certain yet on the exact correct fix for 7807, and 7798 makes sense to patch ASAP because of the divide by 0 bug. 03:36:16 2. All wallets that delay in updating would be using a different algorithm, which would then cause 2 puddles of rings to form and potentially introduce privacy implications as a result of breaking tx uniformity. 03:47:40 I see not moving forward with a fix as a worse privacy choice, but I understand patching divide by zero asap 03:52:29 I agree, once the fix for 7807 is known it should also probably be applied ASAP in terms of benefit and cost to privacy (the risk of potentially breaking tx uniformity in a small number of cases is *probably* vastly outweighed by continuing to compromise real outputs in some known cases). And considering tx uniformity would already be altered from 03:52:29 a change to 7807, it probably makes more sense to go ahead with the fix in 7798 as well 04:18:31 maybe we slap a ringsize bump on it for good measure 06:02:37 gingeropolous: that will require a hardfork. That's not explicitly required for the other changes 06:04:38 sgp_: lol. is blockfolio alerts the new monero mailing list? 06:04:51 jberman: I definitely appreciate your concern for uniformity, but that's something we need to fix later when there's a common spend condition whereby users accidentally reveal the real wallet spends 06:05:19 M5M400: I put out notices where I can; I can't send emails to the main distro haha 06:05:37 So this is what y'all get :p 06:06:06 fair enough :) thx in any case 06:08:20 Good to know those notifications work 06:11:25 sgp_ ya I'm agreeing with you, 7807 should probably be patched ASAP once the correct fix is known regardless of its impact on tx uniformity 06:12:36 All things considered, we've been pretty nonchalant (relatively) at enforcing ring sig selection anyway as I'm sure you're aware 06:13:05 I know for certain pushing the algorithm out 1 block would alleviate the issue immediately, it would just take more time digging into the paper's numbers to be certain that is the correct thing to do 06:13:07 Not that it's necessarily a good thing haha, but still, we're not losing much 06:13:51 Or rather, assuming the gamma distribution starts 120 seconds earlier 06:23:18 It seems I'm not getting everything via Matrix either. If anybody has a task for me or sth. similar, please message directly. 11:15:28 yeah i know its not required for the other changes, but a hardfork is one way to ensure tx uniformity 11:15:47 although i guess folks could mod their wallets to bump ringsize but not the other things 14:26:13 Hi allπŸ‘‹ 18:32:00 We are hitting 120 tx a block, how does the bug affect privacy now ? 18:32:44 Its 120 outputs per block that is the threshold and it's a trailing avg of the last year -- we're still well below that. 18:54:39 https://imgur.com/a/I1bOnsv - yellow: vout >=120, green: vout < 120 18:55:21 (no, each point doesn't mean "one block", but rather "one time the collector look at `monerod` and saw the last block) 18:57:46 πŸ‘ 18:58:09 (whoops, yellow is <= 120) 19:59:10 Is the bug just on the wallet? 19:59:10 Excuse my ignorance? 19:59:19 * Is the bug just on the wallet? 19:59:19 Excuse my ignorance 19:59:21 Yes, just the wallet. 20:01:45 Is there a wallet with a different implementation, or coin control at all? 20:02:36 Not sure if coin control is a thing that can be done in monero 20:02:50 that's better for #monero as it isn't dev related (CLI and Feather have coin control) 20:03:34 Yes, monero-wallet-cli can freeze/thaw outputs, and Feather wallet can do the same. 20:03:54 But if you're spending >1h after receiving funds you're fine. 20:04:05 No need to coin control everything because of this bug. 20:06:53 Yes, not worried :) my spending habits not affected 20:06:54 How do you do that on the GUI or should be it CLi? 20:07:55 I don't think the "official" GUI has coin control -- have to use the CLI or Feather wallet (which is a GUI wallet, and my favorite wallet to use, #_oftc_#feather:matrix.org ) 20:17:26 * MonerolionX[m] uploaded an image: (85KiB) < https://libera.ems.host/_matrix/media/r0/download/bitcoiner.chat/MvjuBlzOrZzbRneEfbJKNUCm/Screenshot_20210727-211657.png > 20:18:12 odd 20:18:26 Website is featherwallet.org 20:42:57 .merges 20:42:57 -xmr-pr- 7692 7693 7698 7718 7740 7744 7745 7758 7765 7769 7771 7772 7776 7781 7782 7789 20:44:20 #_oftc_#feather:matrix.org 20:44:20 #feather:matrix.org 20:50:16 Clicking this worked 22:09:37 * utxobr[m] < https://libera.ems.host/_matrix/media/r0/download/libera.chat/65b32f2d443655119061d4fbd6ed6bd08da62268/message.txt > 22:10:19 utxobr[m]: which Ubuntu version? Which cmake version? 22:10:30 * utxobr[m] < https://libera.ems.host/_matrix/media/r0/download/libera.chat/b951062ce585360ab9c33dcbb9ef0568ad6b0ac7/message.txt > 22:10:36 utxobr: which Ubuntu version? Which cmake version? 22:11:12 slstmd: `cmake version 3.16.3` `DISTRIB_DESCRIPTION="Ubuntu 20.04.2 LTS"` 22:11:25 Did you tree a fully clean build? 22:11:30 try* 22:12:08 yeah I thought I might've had something weird under `build`, so got rid of everything and started from a fresh clone (did fetch the submodules etc) 22:12:37 is it all good over there? if so, I can try double checking the dependencies I have here 22:13:12 (I noticed github actions didn't finish yet - no worker picked the builds up still - so not sure if a regression/not) 22:15:17 https://github.com/monero-project/monero/pull/7698/ 22:15:33 It's this PR, it passed all CI including Ubuntu 20.04 so I'm confused why it fails on your system. 22:16:26 hi 22:16:44 It's possible that Github actions deactivated our account for whatever reason. 22:18:06 interesting, no worries, that's helpful already, thanks slstmd 22:20:30 hi atoc_ :p 22:20:43 hi man 22:22:56 utxobr: will take a look at your issue 22:24:07 Did you just do "make" or did you use custom cmake paths? 22:30:15 slstmd: oh thanks! no, just plain `cmake ..` from a build dir followed by a `make -j12` 22:30:15 I wonder if the concurrency there messes it up 22:30:15 utxobr: can you try this https://paste.debian.net/hidden/f70b726b/ ? 22:30:34 sure 22:32:42 * utxobr[m] < https://libera.ems.host/_matrix/media/r0/download/libera.chat/9ea4b96407071637c6d42637ff700528b5fa19fb/message.txt > 22:33:43 utxobr: next try https://paste.debian.net/hidden/21425af9/ 22:35:58 slstmd: a-ha. that seems to have done it - past that target already 22:38:30 sweet, that did it slstmd πŸ‘οΈ 22:39:04 thank you! 22:40:38 utxobr: thanks, could you please also check if the patch in https://github.com/monero-project/monero/pull/7813 works and then approve it if you have a github account? 22:45:13 rebuilt fresh from your fork's branch, works great! i'd need to ping luigi to get the permissions there first, but lgtm 22:45:40 luigi1111: https://github.com/cirocosta in case you're around 23:24:35 .merge+ 7813 7814 7815 23:24:35 Added 23:42:55 utxobr: github actions works again for newer PRs, probably a bug?