11:57:51 <selsta> Is there a specified monero uri scheme?
11:57:56 <selsta> apart from https://github.com/monero-project/monero/wiki/URI-Formatting
11:59:11 <selsta> because the one on wiki seems wtf, amount as float and the description claims atomic units
12:19:34 <selsta> jberman[m]: do you want to squash your PRs?
15:41:46 <rbrunner> I try to compile UkoeHB's multisig improvements: https://github.com/monero-project/monero/pull/7877
15:42:09 <rbrunner> I run into a boost error quite early on: https://paste.centos.org/view/116f1506
15:42:28 <rbrunner> Something with boost::system::system_category() undefined, as far as I can see
15:45:04 <rbrunner> Ups, have the same problem with master. What did change? Do I need to update boost? If yes, how?
15:45:55 <UkoeHB> submodule thing?
15:46:12 <UkoeHB> I have these written down:
15:46:12 <UkoeHB> git submodule sync
15:46:12 <UkoeHB> git submodule update --init --recursive
15:46:12 <UkoeHB> git submodule update --init --force
15:46:12 <UkoeHB> cmake -S . -B build -DMANUAL_SUBMODULES=1
15:47:42 <vtnerd> its coming from epee, so probably not it
15:48:05 <selsta> rbrunner: does it only happen with debug build?
15:48:19 <rbrunner> I tried that first, yes. Release not yet tried.
15:48:45 <vtnerd> looks like `${Boost_SYSTEM_LIBRARY} needs to be added to the dependency list in epee
15:51:33 <selsta> rbrunner: vtnerds suggestion https://paste.debian.net/hidden/4067d466/
15:52:59 <rbrunner> thanks UkoeHB, selsta, vtnerd for all the hints. Compiling release right now, just to check it works. Will try that dependency added after that.
16:29:03 <wfaressuissia> "I run into a boost error quite early on ..." it's reproducible only with boost <=1.65 and `-DBUILD_SHARED_LIBS=1` (enabled by default for debug target)
16:29:56 <wfaressuissia> The above patch fixes it.
16:31:21 <selsta> will PR it
16:52:09 <selsta> Remaining PRs that need review: 7805, 7825, 7873/7874, 7881/7882
17:02:21 <rbrunner> Hmmm, with that dependency fix I get basically the same error, but for another lib: Linking CXX shared library libepee_readline.so
17:02:50 <rbrunner> https://paste.centos.org/view/4ece7136
17:03:23 <rbrunner> That's now for UkoeHB's branch, not master
17:03:40 <rbrunner> Unmodified release master compiles ok without that patch
17:04:43 <selsta> rbrunner: try https://termbin.com/vgjl
17:04:59 <wfaressuissia> also reproducible, the same `${..}` fixes it for `epee_readline`
17:06:39 <rbrunner> Ah, yes, only a few lines below the other one, should have seen that myself. Anyway, noob here, stumbling through C++ stuff :)
17:06:45 <rbrunner> Thanks
17:07:51 <rbrunner> Maybe somewhere in the vast open-source software universe there is a tool that could find and fix all such errors once and for all automatically and systematically ...
17:50:55 <rbrunner> Now it compiles successfully.
18:06:27 <rbrunner> Hey, that's nice additional info, was that you, UkoeHB? :) Multisig info imported. *Number of outputs updated: 1*
18:08:13 <UkoeHB> I don't think so
18:09:23 <UkoeHB> I didn't make any behavioral changes to tx building code.
18:10:04 <rbrunner> That was a praise, by the way, should there be any doubt. That's useful info, I am just a little surprised somebody took it on to improve it.
18:11:29 <rbrunner> Started to test the MMS on your branch.
18:12:01 <UkoeHB> Looks like xiphon is to thank: https://github.com/monero-project/monero/pull/7346#discussion_r563656731
18:12:36 <UkoeHB> Cool looking forward to your results :)
18:13:28 <selsta> UkoeHB: does this fix the security issue with multisig? or does that require more work?
18:14:19 <UkoeHB> It fixes the security issue with making multisig wallets, but does not address the tx building issue (which is much harder to pull off).
18:14:27 <UkoeHB> (and much harder to fix)
18:15:06 <rbrunner> Might not even be worth it, with new code (hopefully) ahead within a reasonable timeframe anyway?
18:15:10 <UkoeHB> actually maybe not harder to fix... probably similar or even fewer diffs
18:17:01 <UkoeHB> rbrunner: no one has the answer to that yet. A) idk if anyone is enthusiastic about implementing multisig that supports Triptych, B) alternatives to Triptych are being researched...
18:20:31 <rbrunner> Yeah, I am aware
18:24:11 <rbrunner> I tested 2/2, and almost everything worked. At the end, after sending funds out of the multisig wallet again, the situation is strange:
18:24:42 <rbrunner> The wallet that submitted has the correct balance, but does not tell about missing key images, and also does not report the mining of the tx
18:25:08 <rbrunner> The other wallet is oblivious to everything, did not see anything happening, still has the old balance, even after refresh
18:26:12 <rbrunner> Ups, I take all back, it just took an eternity for the wallet to notice the transaction. 
18:28:17 <rbrunner> So I can report that a full roundtrip worked for 2/2: Wallet building, funding, syncing, transfer out part of the funds from the multisig wallets, and finally syncing again
18:28:28 <UkoeHB> Awesome! Thanks :)
18:35:31 <UkoeHB> I wonder if there will be problems with M < N, since I killed `finalize_multisig()`
18:39:30 <rbrunner> I will probably know in a few minutes, right now trying 2/3. If anything the MMS is at least good for testing multisig code
18:58:37 <rbrunner> 2/3 still works as well. Nice.
19:19:02 <UkoeHB> yay! What about 2-of-4 (or 1-of-3, which I enabled in the new version)?
19:21:31 <rbrunner> Wallet construction for 3/5 worked. (Don't try that at home without the MMS :)
19:24:06 <sgp_[m]> Matrix room description updated
19:25:13 <rbrunner> 1/3 trivially fails because of an error check in the MMS code in simplewallet.cpp, 1 as number of required signers gets rejected there
19:28:09 <UkoeHB> What's the error msg? Trying to find it
19:29:06 <rbrunner> Error in the number of required signers and/or authorized signers
19:29:32 <moneromooo> 1 does seem a bit short of multi.
19:29:42 <rbrunner> Well, not 100% sure anymore where the check is. Maybe also somewhere in wallet2.cpp
19:30:13 <rbrunner> Well, yes, until now. It should be supported now, after the most recent changes by UkoeHB, in their PR
19:33:09 <UkoeHB> rbrunner: in `mms_init()`, is `num_authorized_signers` the value 'N' and `num_required_signers` the value 'M', in M-of-N?
19:34:30 <rbrunner> Er ... it's required/authorized, e.g. 2/3.
19:35:07 <UkoeHB> Ok try latest commit
19:35:09 <rbrunner> So ... yes?
19:35:47 <rbrunner> Ok. That will have to wait for tomorrow however, night arrived here.
19:36:50 <UkoeHB> Np :)
19:48:09 <rbrunner> Alright, 3/5 worked up to sending funds out again. Perfect so far. Solid!
22:02:40 <jberman[m]> <selsta> "jberman: do you want to squash..." <- all squashed :)
22:15:58 <selsta> thanks
22:15:59 <selsta> .merges
22:15:59 -xmr-pr- 7780 7805
22:17:52 <selsta> .merge+ 7882 7881 7879 7878 7849 7848 7846 7845 7838 7822 7821 7832
22:17:52 <xmr-pr> Added
23:16:24 <selsta> luigi1112: can you change this page? https://github.com/monero-project/monero/wiki/URI-Formatting
23:17:44 <selsta> If yes, please change at tx_amount "Float" -> "String" and "atomic currency units" -> "decimal units"
23:54:04 <luigi1112> ok