01:11:52 <ndorf> am i blind or is the 'request review from...' function somehow disabled for the monero github repo?
06:13:11 <mj-xmr[m]> selsta: 7805 - nothing more to nitpick.
06:13:47 <mj-xmr[m]> 7825 needs somebody to look at the wallet2.cpp changes.
07:44:39 <selsta> mj-xmr[m]: it's enough to compare the patches in 7825 against the ones merged into master branch
07:44:51 <selsta> .merge+ 7805
08:00:36 <mj-xmr[m]> selsta: OK, so I've just done it. Check.
08:01:27 <selsta> ty
08:06:04 <mj-xmr[m]> np
08:18:39 <selsta> .merge+ 7825
08:18:39 <xmr-pr> Added
08:18:40 <selsta> .merges
08:18:40 -xmr-pr- 7805 7822 7825
08:24:41 <mj-xmr[m]> <ndorf> "am i blind or is the 'request..." <- As far as I can see, you can Re-request a review from sb., who has already checked. That symbol on the right of the avatar.
08:24:49 <mj-xmr[m]> circle with arrows
19:59:26 <NikolaIgnatovNed> stopwatch
19:59:40 <NikolaIgnatovNed> ruff ruff
20:55:16 <lru> this failes: git checkout v0.17.2.0 ; git submodule update
20:55:24 <lru> which causes the plain 'make' build to fail
20:55:44 <lru> external/miniupnp does not have the commit that master expects
20:56:02 <lru> anyone know where 4c700e09526a7d546394e85628c57e9490feefa0 can be found?
21:14:04 <wfaressuissia> https://github.com/monero-project/monero#cloning-the-repository
21:17:08 <lru> wfaressuissia: yep, was already following that, but the repo is missing a commit or something
21:18:07 <lru> it fails if I use: git checkout release-v0.17 ; git submodule update
21:18:22 <lru> either branch or tag fails after the submodule update
21:18:28 <wfaressuissia> sorry, I'm too dumb to help then
21:18:35 <lru> no worries
21:18:55 <UkoeHB> lru: try these:
21:18:55 <UkoeHB> git submodule sync
21:18:55 <UkoeHB> git submodule update --init --recursive
21:18:55 <UkoeHB> git submodule update --init --force
21:18:55 <UkoeHB> cmake -S . -B build -DMANUAL_SUBMODULES=1
21:22:21 <lru> UkoeHB: thanks, didn't realize --recursive was needed on update
21:23:05 <wfaressuissia> indeed, `--recursive` was that magic flag
21:23:23 <lru> maybe that's my first patch... to README.md :-)
21:29:37 <wfaressuissia> "https://github.com/monero-project/monero/pull/7650/files", too late, it's already there
21:30:21 <lru> wfaressuissia: it doesn't have the --recursive flag on update
21:30:28 <lru> that's what led me astray
21:32:04 <wfaressuissia> repeat again your steps without `--recursive`
21:33:26 <lru> well, that's what led me here... I did a plain git clone without recursive, then I saw that if I already had it downloaded, I could just do 'submodule init && submodule update' but I never did --recursive until UkoeHB mentioned it
21:43:21 <wfaressuissia> "https://paste.debian.net/hidden/7f92ac47/", "113 Fetched in submodule path 'external/miniupnp',  ..."
21:57:51 <selsta> lru: `git submodule sync` was the command you need
22:53:16 <Lyza> another person with issue of the gui not closing on windows https://www.reddit.com/r/monerosupport/comments/pa7v69/help_pls/
23:08:10 <selsta> Lyza: can you open the GUI twice on Windows?
23:09:09 <selsta> if yes it's not clear that they have the same issue as you, just that they had multiple GUI instances open
23:09:41 <selsta> (not that I'm doubting your issue, just that it doesn't seem clear from issue description)