11:09:43 "What would be a good C++ / STL..." <- deque 11:10:35 unless the input is meant to be inserted into random locations, but still sorted. 11:11:44 Mining nodes will erase and insert at arbitrary positions. 11:12:05 Then you're right about the map/ 11:12:06 In fact, also non mining nodes, though less so. 11:57:40 rbrunner: a map also allows access to its first (sorted) element via .first() (provided it's not empty()) and later via begin() + i 11:58:11 It's just that its deletions will be a bit slow, but I doubt that these operations will be done so often, that it would matter. 12:57:31 hello 12:57:50 this monero-project/monero #7803 monero-project/monero #7891 has small conflicts 12:58:25 and both are very important 13:41:32 #7803 is vtnerd 's. I'm planning to review this on the weekend, or in the next week. 14:29:30 Do y'all have any clue what's causing https://github.com/monero-project/monero/pull/7970? 14:32:35 Somehow one of the includes changes the default log level. 14:33:03 but I didn't go through the code in detail 14:35:00 I put this on my next week's todo list. 14:35:45 selsta: 7912 would be very useful before the next release. 14:40:58 Possibly something setting MONERO_DEFAULT_LOG_CATEGORY in a header. 14:49:47 mj-xmr[m]: left a comment 14:50:58 Thanks. Needs a deeper look then. 14:51:27 shouldn't be much work to change 15:35:31 sadly, not as easy as it seemed 15:43:58 hyc: it does not use gbuild as far as I can see 15:44:17 but if it's too much work / not easy I can merge as is 16:00:03 I'm still tinkering with it 16:05:11 if it's not using gbuild or any of that setup, particularly GBUILD_PACKAGE_CACHE or GBUILD_COMMON_CACHE then I'll just switch on one of those vars instead 16:22:32 hyc: hmm I did find GBUILD_CACHE_ENABLED=1 now in the Dockerfile, whatever, let's still merge it 16:22:40 that can be solved later 16:22:55 .merge+ 7912 16:22:55 Added 16:23:09 ok 16:25:42 do we need release-0.17 versions of these, or is this for v0.18? 16:27:49 both would be fine 16:28:10 ok I'll do 0.17 in a little while 19:55:05 hmmm, what's the CI build doing differently from gitian and/or depends? https://github.com/monero-project/monero/runs/3723220908?check_suite_focus=true 19:55:38 hyc: brew installed openssl3 which doesn't get recognized somehow 19:55:42 looking into it currently 19:55:51 ok 19:56:14 openssl3 deprecates a lot more functions, there's prob a fair bit of compat work needed 19:56:30 might be easier to change CI to openssl1.1 19:56:33 for now 19:56:47 yeah that'd certainly take care of it for now 20:06:32 ¯_(ツ)_/¯ 20:07:09 ¯_(ツ)_/¯\ 21:25:28 hyc: monero compiles fine with openssl3, just some deprecation warnings as you said 21:25:34 now I just have to find out why it fails on CI