00:27:21 <atomfried[m]> i dont think you need to know all the internals in zero to monero to create an exchange web app :D
00:27:31 <atomfried[m]> thats a bit of an overkill isnt it?
05:41:47 <mj-xmr[m]> selsta: There has been quite a jump of the compilation time since the last 2-3 merge sets, but I just wanted you to know that it was NOT due to your C++11 -> C++14 change, because this jump happened earlier.
05:41:48 <mj-xmr[m]> http://cryptog.hopto.org/monero/health/img/cbta.png
05:44:52 <sech1> something ~20 commits before HEAD?
05:45:27 <sech1> release or master branch?
06:41:35 <mj-xmr[m]> <sech1> "something ~20 commits before..." <- This is all master.
06:41:35 <mj-xmr[m]> and the incrementation is not really per each commit, but a set of commits. See the 1st two leftmost columns:
06:41:35 <mj-xmr[m]> http://cryptog.hopto.org/monero/health/
06:46:44 <jberman[m]> Reporting back on the gamma test issue: the addition of the "recent spend window" (where the gamma picker redraws a recent output for picks <10 blocks old) causes the test's median output age to drop from ~116,500s to ~115,000s, which is just close enough to the test's lower bound of 112,320s to trigger the occasional failure with a sample size of 100k picks (exactly 10 in 1000 tests failed when I ran it locally, so ~1% failure rate)
06:47:02 <jberman[m]> When I run the test with a gamma picker that matches Miller et al exactly (removed the recent spend window, allowed outputs <10 blocks old to be picked by the gamma, applied distr from chain tip), I get a median of around ~115,000s as well. Which is good, it means the current implementation is now more in line with the paper
06:47:31 <jberman[m]> The reason the paper's expected median is ~129,000 when plugging into the formula, and this test's median is way less than that, is because of the long tail where draws that are too old get thrown away. A very large proportion of draws get thrown away in this test because there just aren't that many outputs in the sample chain. This skews this test's median to be much younger than the gamma formula's expected median
06:47:59 <jberman[m]> Will put a fix out for the test soon probably in line with what moneromooo said in mrl. Basically nothing unexpected is happening here, all is well :) I'll add a deterministic test as well
08:34:06 <mj-xmr[m]> <sech1> "something ~20 commits before..." <- And I'm not trying to pinpoint the exact commit here. All these commits were necessary for improvements. The regressions, that I show, are just side effects (like waste) of something better. Simply from time to time the waste has to be cleaned up, independently of the production.
10:33:58 <selsta> jberman[m]: thanks for looking into it :)
10:34:35 <selsta> mj-xmr[m]: at least there doesn't seem to be a huge increase due to C++14
10:34:59 <mj-xmr[m]> selsta: Quite the opposite.
10:35:30 <mj-xmr[m]> And this brings even more potential of reduction, by ditching bits of Boost.
10:35:35 <selsta> Somehow compilation fails when building release branch under C++14
10:35:42 <selsta> and I can't figure out why
10:35:54 <selsta> some boost iterator error
10:36:26 <selsta> also it only happens on Mac as can be seen here https://github.com/monero-project/monero/pull/7997
10:44:26 <mj-xmr[m]> selsta: my gut feeling tells me, that it expects `cend` instead of `end`
10:44:36 <mj-xmr[m]> `/usr/local/include/boost/range/concepts.hpp:302:34: error: no matching function for call to 'end'
10:44:36 <mj-xmr[m]>             const_iterator ci2 = boost::end(const_range);
10:44:36 <mj-xmr[m]>                                  ^~~~~~~~~~`
10:45:10 <mj-xmr[m]> but since it's inside boost, all you can do is to bump the Boost version.
10:45:27 <mj-xmr[m]> `-- Found Boost Version: 107600`
10:45:47 <mj-xmr[m]> Try 1.77.0 ?
10:47:59 <selsta> yep will try
10:48:09 <selsta> but still don't understand why master compiles fine
10:48:50 <moneromooo> Sounds like you're not including the header where that is.
11:22:02 <BigmenPixel[m]> Hello. What is causing this error?
11:22:02 <BigmenPixel[m]> ```
11:22:02 <BigmenPixel[m]> 2021-10-19 11:21:11.941	E failed to parse version number unknown
11:22:02 <BigmenPixel[m]> ```
11:22:42 <moneromooo> Break where it prints this (abort() would do), bt in gdb.
11:23:42 <mj-xmr[m]> The shortest, yet correct debugging tutorial ever.
12:45:28 <selsta> BigmenPixel[m]: GUI?
12:46:02 <BigmenPixel[m]> selsta: yes
12:46:51 <selsta> does it cause any issues,
12:46:53 <selsta> ?
12:48:03 <BigmenPixel[m]> selsta: Monero gui version is not shown in Info section
12:48:12 <BigmenPixel[m]> * Info section (unknown (Qt 5.15.3))
12:48:13 <BigmenPixel[m]> * Info section (unknown (Qt 5.15.3)
12:48:18 <BigmenPixel[m]> * Info section (unknown (Qt 5.15.3))
12:48:39 <selsta> is that with flatpak?
12:49:13 <BigmenPixel[m]> selsta: yes
12:49:14 <selsta> git / git repository is required during build to get the version number and commit hash
12:49:44 <selsta> though that can be improved at some point
12:50:07 <BigmenPixel[m]> selsta: Perhaps this is due to the limitation of the Internet after downloading the source files?
12:50:36 <selsta> no, you have to be inside a git repository
12:50:50 <selsta> download source files doesn't contain it
12:51:01 <selsta> .git folder
12:51:18 <selsta> it would require some cmake changes to support it
12:55:27 <BigmenPixel[m]> selsta: OK, thank you for answer
12:56:01 <selsta> BigmenPixel[m]: will take a look later
14:09:16 <selsta> BigmenPixel[m]: https://github.com/monero-project/monero-gui/pull/3715 should solve it
14:12:04 <BigmenPixel[m]> selsta: ok, I'll try to apply this patch later
14:12:16 <BigmenPixel[m]> * patch later(or now...))
16:01:32 <selsta> BigmenPixel[m]: updated it again, it should display "v0.17.2.3-unknown" now
16:02:02 <selsta> you can overwrite the "unknown" with the `-D GUI_VERSION_TAG="release"` cmake option
16:02:14 <selsta> but I don't know how the flatpak script works exactly
16:04:42 <BigmenPixel[m]> selsta: Is there a mistake? I just collected monero-gui with the patch and the version is still unknowт
16:05:04 <selsta> hmm wait
16:05:17 <BigmenPixel[m]> Well, let's build again :)
16:05:23 <BigmenPixel[m]> selsta: without it
16:05:23 <selsta> with the patch that I updated 5 mins ago?
16:05:33 <BigmenPixel[m]> selsta: no
16:07:46 <BigmenPixel[m]> <selsta> "you can overwrite the "unknown..." <- ok
16:08:09 <selsta> I tested it locally and it works here
16:08:18 <selsta> https://usercontent.irccloud-cdn.com/file/Kk0A9sNm/Screenshot%202021-10-19%20at%2018.08.13.png
16:09:18 <BigmenPixel[m]> selsta: with an old or new patch?
16:10:26 <selsta> with 3715 (before and after force push)
16:11:11 <BigmenPixel[m]> selsta: I'll try to build with a new patch.
16:12:10 <BigmenPixel[m]> Maybe I was wrong somewhere...
16:19:08 <BigmenPixel[m]> s/unknowт/unknown/
17:39:09 <BigmenPixel[m]> selsta: :)
17:39:12 * BigmenPixel[m] uploaded an image: (5KiB) < https://libera.ems.host/_matrix/media/r0/download/matrix.org/MIJrAwQEaCYPjQPJDIxzSRix/%D0%A1%D0%BD%D0%B8%D0%BC%D0%BE%D0%BA%20%D1%8D%D0%BA%D1%80%D0%B0%D0%BD%D0%B0%20%D0%BE%D1%82%202021-10-19%2017-38-51.png >
17:39:33 <selsta> nice :D