04:34:15 .merge+ 8186 04:34:15 Added 04:40:06 .merge+ 8154 8158 8159 04:40:06 Added 04:44:23 .merge+ 8187 04:44:23 Added 04:49:46 hyc: could you take a look again at https://github.com/monero-project/monero/pull/8088 and approve if the PR is ok? 06:41:26 If anyone would be willing to review my PR https://github.com/monero-project/monero/pull/8211, I would greatly appreciate it! I tried to simplify the changes that I made and I would be happy to help answer questions since it's a pretty big PR 06:41:54 (It's the final version for now) 06:45:18 -xmr-pr- jeffro256 opened pull request #8211: EPEE Cleanup Reorganized 06:45:18 -xmr-pr- > https://github.com/monero-project/monero/pull/8211 15:00:14 how is one to use monerod `get_fee_estimate` to estimate a tx fee? one needs to know how big the tx is in bytes, but that requires generating the tx? 15:11:58 Yes. 15:13:43 how can a transaction be generated without a fee estimate in order to know the size in bytes? 15:16:33 Iteratively. Most of the time, you won't need to add a new output. 15:16:41 s/out/in/ 15:16:54 See create_transactions_2 15:17:47 Or you can just select inputs that always sum >= wanted amount + 0.001 and you'll always be good. 16:52:08 is there any update on the status of next hard fork? 17:19:42 If you want to have your favorite IDE documented against Monero-dev's specifics, please vote here: 17:19:42 https://www.reddit.com/r/Monero/comments/t9iy3b/poll_what_ide_would_you_like_to_have_documented/ 17:42:41 r4v3r23[m]: 1/2 multisig PRs were merged, a lot of the other big patches are also approved 17:43:06 but there is no date currently 19:31:47 there is an issue with version 0.17.3.1, when you add a contact to the address book, the bottom entry in the address book get reassigned the name of the new entry. what should I do about this, I am a developer and have been using monero for a while but have never tried to contribute? 19:43:23 "there is an issue with version 0..." <- Of GUI? 19:43:35 yes 19:43:38 gui 19:44:24 * issue with Monero GUI version 0.17.3.1, 19:44:39 Open an issue on GitHub yet? 19:44:50 there is not a version 0.17.3.1 cli 19:44:56 no i have not 19:45:12 is that the preferred avenue? 19:46:55 For an issue 19:46:55 But 19:46:55 selsta: might be able to point you to the code 19:47:18 * the code if you're interested in investigating yourself 19:47:34 * the code if you're interested in investigating yourself 19:48:10 i would like to become familiar with the codebase, i feel like its only responsible 19:48:23 for me to have a deeper understanding of the back end 19:50:04 The code is likely in wallet2.cpp, a bit less likely to be in src/wallet/api 19:50:39 you could try using the address book in monero-wallet-cli, and see if a similar thing happens. If yes, the bug's almost certainly in wallet2. 19:51:20 okay, i will take a look there then i guess i should submit an issue on the github? 19:51:51 A PR if you can :) If you can't find it, an issue. 19:52:35 I added tests for address book functionality (tests/functional_tests). If they don't test that particular case, adding another test that "finds" this bug would be a nice plus if you're willing. 19:53:00 i mean, i don't know if im qualified to fix the problem, ill see if its something simple, but if not idk about that yet i havent even looked at the codebase before 19:53:27 Well, it's straight C++. No crypto involved, so you're likely to be just fine. 19:53:59 Good luck, and questions here about the code are welcome if you need clarity on some bits. 19:54:08 c++ is my jam 😝 19:54:12 thanks 19:54:17 this should be fun 19:58:23 * arimfexendrapus[ uploaded an image: (205KiB) < https://libera.ems.host/_matrix/media/r0/download/matrix.org/DSJNVtglGiQtplpKyMlgiIoq/image.png > 19:58:23 maybe im being stupid but i cant find wallet2.cpp 19:58:33 find src -name wallet2.cpp 19:59:02 or, better: find . -name wallet2.cpp 20:02:57 im in a windows environment 20:03:22 shocker i know :P 20:03:27 Ouch, sorry :/ src/wallet 20:04:34 * arimfexendrapus[ uploaded an image: (53KiB) < https://libera.ems.host/_matrix/media/r0/download/matrix.org/YKDfkgSdJzwfbfFpTRucYZTo/image.png > 20:04:48 don't have that path 20:05:30 i downloaded the gui master 20:05:36 He's talking about the main Monero repo that inclures wallet-cli 20:05:36 Not gui 20:05:38 do i need just the main monero 20:06:18 okay gotcha sry took me a second to figure that on out 20:06:24 s/on/one/ 20:06:31 😅 20:06:32 Oh right. A submodule in your case... 20:07:42 i just downloaded the master monero zip just so i dont run into any more issues like this 20:07:55 since you seem to me more familiar with that anyway 20:10:50 christ wallet2.cpp is 14k lines 20:11:22 Sounds like you found the right one :) 20:20:29 LOL 20:29:23 how many loc is Monero in total roundabout? 20:34:56 i see wallet2 is one of the largest files in the repo 20:41:51 "how many loc is Monero in..." <- 265k lines of code 20:41:59 Here are some "actionable" stats if you're interested: 20:42:08 oh boy 20:42:10 http://cryptog.hopto.org/monero/health/ 20:42:38 there, the LOC is counted as code in .cpp files relative to code in header files. 20:42:51 yea 20:43:00 this is neat 20:43:42 (almost) obviously in order to incentivise the move the code from the headers into source files. 20:48:32 "r4v3r23: 1/2 multisig PRs were..." <- are there any remaining issues? has the fee change been settled? IIRC that was what was holding up the fork 20:50:16 arimfexendrapus[m]: This one particularly confirms that the wallet2 is really heavy on the RAM as well. Think of RPi with only 2 GB of RAM, whose 3 of 4 cores cannot be used in such circumstances: http://cryptog.hopto.org/monero/health/data/d562deaaa/d562deaaa-mem-usage-prod.txt 20:51:49 ive never even thought about how much ram it uses on my personal box 20:51:51 * personal box tbh 20:52:04 * personal box tbh im not that concerned 20:53:10 those stats are only for the compiling anyway 20:54:13 i wouldnt try to compile something like this on a RPi 20:55:11 Laptops with 4 GB RAM are not unusual. 20:55:11 thats just asking for problems 20:55:17 true 20:55:45 But yeah. This is only developers' perspective. The user won't be affected at all. 20:56:00 thats a sad developer 20:56:11 using a 4gb laptop 20:56:12 So in other words: there are worse problems in the World :) 20:56:20 😝true that 20:56:32 seems to be tearing at the seams atm 20:56:42 the world i mean 20:57:15 When TSHTF, and I have to resort tapping my solar panels as the only energy source, than that 4 GB laptop will be the only way to work :) 20:58:08 arimfexendrapus[m]: It's gonna be alright. It just needs some ... clensing. 20:59:06 s/clensing/cleansing/ 20:59:08 some of the solar stuff rn is nuts, i doubt that it would affect your usage of a regular destop or even workstation 20:59:39 which is pretty crazy to think about 20:59:57 i mean i wouldnt be mining anymore but for just regular usage... 21:00:13 I'm mounting 600 pW this week. So 300 W on average with 72 Ah storage. 21:00:37 see, not a problem 21:00:57 for a laptop anyway 21:01:23 arimfexendrapus[m]: Why not? Otherwise the energy goes to a waste. Selling it to the grid is out of option for me. I don't work for the government nor for the so called: Local Community. 21:01:56 i was just saying if i had to choose 21:02:12 arimfexendrapus[m]: Not at all. Even in rainy cloudy days, when you have to assume just 10% of the average output. 21:02:18 refridgerate my food -- mineing crypty 21:02:24 s/crypty/crypto/ 21:02:32 * refrigerate my food -- mining crypto 21:02:42 lol 21:03:31 I store the bulk of my food in form of dry grains. Refrigerator is not sth. I'd count on, TBH. 21:03:45 OK. Sliding off topic, and I'm getting sleepy. GN. 21:03:50 hey technical question, i havent worked with cmake in VS only regular sln files, its saying that i need openssl 21:04:48 or something like that, ill figure it out on my own but if you know what to do off the top of your head... 21:05:03 https://github.com/monero-project/monero#compiling-monero-from-source 21:05:28 There are copy-paste ready installation commands. I guess you're missing at least one of the deps. 21:05:34 im trying to actually work on the code not compile it 21:05:59 Still, CMake needs them to generate the Makefiles. 21:06:06 okay 21:06:18 and only on top of that, your VS can show you a valid project file. 21:06:34 *project tree. 21:06:39 Otherwise it crashes before this is possible.