00:53:42 <chesterfield[m]> Whipping up a little thing with the monero-javascript lib in case anyone wants to check it out: https://sunny-malabi-a3b5ff.netlify.app/
00:56:35 <willshu[m]> <moneromooo> "In that case, you could maybe..." <- I have been looking at the wrong api. If I query with `get_block`. I actually get the amount:... (full message at https://libera.ems.host/_matrix/media/r0/download/libera.chat/280a08466fbd8dad21d7b0f6fa7cfe39f4075050)
00:57:19 <willshu[m]> So I only have one problem, how do I calculate if the vout belongs to my wallet with `target.key` and my privateViewKey?
01:00:41 <willshu[m]> Well, here the vout belongs to `miner_tx`, so I guess the list of vout is actually coinbase transactions, not the transactions mined by the miner, am I correct?
02:19:50 <selsta> .merge+ 8227 8228
02:19:50 <xmr-pr> Added
02:38:55 <selsta> .merge+ 8179
02:42:49 <willshu[m]> `curl -X POST http://127.0.0.1:48089/json_rpc -d... (full message at https://libera.ems.host/_matrix/media/r0/download/libera.chat/89d1705d5783ca20b95367f17314e3e1c5781e42)
02:43:20 <willshu[m]> Hello, this is the `unsigned_txset`, how do I decode it to get from, to, amount etc?
02:48:41 <selsta> willshu[m]: isn't it part of the output of e.g. `transfer`? https://www.getmonero.org/resources/developer-guides/wallet-rpc.html#transfer
03:04:06 <selsta> .merge+ 7153
03:04:06 <xmr-pr> Added
03:04:23 <willshu[m]> <selsta> "will.shu: isn't it part of the..." <- It's part of our internal risk audit before we broadcast we need to check if the info is correct, so we need to decode it.
03:23:30 <selsta> willshu[m]: try this function: https://github.com/monero-project/monero/blob/master/contrib/epee/src/hex.cpp#L103-L121
03:25:49 <selsta> e.g. port it to python or so
03:31:57 <selsta> but doesn't the output of `sign_transfer` show what you need to know anyway?
03:40:56 <luigi1111w> .merges
03:40:56 -xmr-pr- 7153 7170 7936 7937 8053 8166 8177 8179 8180 8195 8196 8197 8205 8207 8211 8212 8213 8215 8222 8223 8227 8228
03:52:45 <selsta> .merge+ 7937
03:52:49 <selsta> sorry, had to add this too :D
03:52:59 <selsta> ugh it was already, forget it
04:22:49 <luigi1111w> ^_^
04:22:57 <luigi1111w> .merge- 7936
04:22:57 <xmr-pr> Removed
04:39:30 <selsta> .merges
04:39:30 -xmr-pr- 8207 8211
04:40:50 <selsta> bulletproofs+ is now merged
12:54:52 <vtnerd> -selsta my fault for holding up the bp+ review as well, I couldn't review it for various reasons. I will scan over it again over the coming weeks but I already did the hardest reviews a while back
12:55:46 <vtnerd> the holdup was me verifying parts of the math :/ it looked legit but that is some of the most dense code I've had to review
13:03:22 <hyc> thanks for doing all that vtnerd
13:03:42 <hyc> too bad it wasn't written in rust, then it would be intrinsically safe    /s
14:14:16 <vtnerd> hyc: haha sounds like we'll have much to talk about in Miami, as usual
14:14:42 <vtnerd> Im traveling late today, but Im flying in a "Im thankful for today" tshirt underneath my long-sleeve pullover. Can't wait to break it out at the airport or where ever
14:16:13 <r4v3r23[m]> so will #8046 be added to the HF? looks like sech1 is on it
14:16:14 <r4v3r23[m]> https://github.com/monero-project/monero/pull/8046
14:17:46 <r4v3r23[m]> <selsta> "we still need someone to..." <- so will this be added to the HF? looks like sech1  is on it
14:18:16 <r4v3r23[m]> 50% reduction of tx creation time on mobile would be killer
19:10:35 <selsta> .merge+ 8242
19:10:35 <xmr-pr> Added
19:11:09 <selsta> luigi1111w: can you merge ^ soon to fix tests? and GUI too pls
20:28:20 <monerobull[m]> <r4v3r23[m]> "50% reduction of tx creation..." <- does this have an effect on hardware wallets?
20:28:45 <monerobull[m]> sitting around waiting for the ledger to construct a transaction, only for it taking so long the device locks itself and you have to start over isnt that fun
20:34:20 <r4v3r23[m]> <monerobull[m]> "does this have an effect on..." <- moneromoo should be the one to ask
20:36:21 <r4v3r23[m]> either way looks like a clear winner for UX
20:36:23 <reeemuru[m]> thx for the merges selsta and luigi1111w 🕺
20:40:40 <sech1> #8046 doesn't speedup hardware wallets, this is the code that runs on the host PC
20:46:48 <selsta> sech1: should I add 8046 to the merge list or does a second review make sense?
20:47:06 <selsta> it's tx generation related so i'm trying to be careful
20:48:50 <sech1> I went through each commit. I'm not very familiar with that code, but the changes make sense. I think unit tests should catch any bugs?
20:49:30 <sech1> but yes, a second review would be nice
20:50:53 <selsta> yes in theory the tests should catch a bug with tx generation, i also tested the PR and it worked fine
20:51:43 <r4v3r23[m]> <sech1> "#8046 doesn't speedup hardware..." <- unless your phone/pc is your hardware wallet :)
20:52:25 <sech1> yes, CLI and GUI wallets and everything that uses wallet2 (Cake, Monerujo etc) will get faster
21:31:44 <hyc>  c0-