06:49:29 <willshu[m]> curl -X POST http://127.0.0.1:38089/json_rpc -d '{"jsonrpc":"2.0","id":"0","method":"transfer","params":{"destinations":[{"amount":123400000000,"address":"78n1uR1CAuaKVW62PVuLpyVYeG6CJNdbTNARj4Y4ors4jCSBzWAKpk4TxgVp9pza5P7z3EjKQLzdDLke8wxGvtbyBCxyira"}],"account_index":0,"subaddr_indices":[0],"ring_size":11,"unlock_time":0}}' -H 'Content-Type: application/json'
06:53:27 <willshu[m]> Hello, when constructing txns, since the `destinations` is an array, if I pass in several txns, and one txn fails, will all txns fail, or will the ones up to the failed txn succeed and ones after the failed txn fail?
07:05:10 <moneromooo> The latter.
07:10:10 <luigi1112> .merges
07:10:10 -xmr-pr- 7819 8207 8211 8232 8239 8240 8241
07:16:25 <luigi1112> oops I think I messed up 8211
07:16:28 <luigi1112> again
07:31:03 <luigi1112> thoughts on merging my conflict resolution?
07:32:35 <moneromooo> You can PR something to fix whatever is borked and I can approve it I guess. I assume it'll be a small patch.
13:21:10 <selsta> jberman[m]: https://github.com/monero-project/monero/pull/8178 did you run tests with this patch locally?
13:21:18 <selsta> functional-tests-rpc seem to have gotten stuck
13:21:42 <selsta> .merge+ 8061
13:21:42 <xmr-pr> Added
14:15:30 <jeffro256[m]> luigi1112 That merge commit you added seemed to do the trick. Looks good on paper and it builds so no complaints. Seems like mj-xmr agrees
14:18:23 <selsta> maybe it's just me being picky but if you could properly rebase without luigi's merge commit the git history would look cleaner jeffro256[m]
14:18:37 <selsta> but if you don't want to change it it's fine too
14:21:36 <jeffro256[m]> Yeah I can rebase for sure, I'll squish the merge commit with another
15:31:51 <mj-xmr[m]> As far as I could see, there was just one conflict in one file (CMakeLists.txt).
16:12:48 <jeffro256[m]> selsta Okay I rebased to fix the history, no changes to lines
16:14:07 <jeffro256[m]> You can double-check it with the compare button if you want
16:33:33 <mj-xmr[m]> Shall we merge this time? :)
16:34:36 <mj-xmr[m]> We need a Senior Manager here to keep y'all anarchists in place.
16:34:59 <mj-xmr[m]> https://github.com/monero-project/monero/pull/8211#issuecomment-1090254352
16:37:22 <jeffro256[m]> That would be nice
16:37:31 <jeffro256[m]> I feel bad for dragging you around every time we merge
16:38:12 <mj-xmr[m]> It's not your fault.
16:50:05 <jeffro256[m]> I appreciate all the effort you put into tho!
17:05:11 <mj-xmr[m]> PROVE IT! ... by checking one of my olden PRs :)
17:05:11 <mj-xmr[m]> I can show you some uncontroversial ones.
17:06:00 <mj-xmr[m]> You can't go wrong with this one:
17:06:01 <mj-xmr[m]> https://github.com/monero-project/monero/pull/7217
17:06:09 <mj-xmr[m]> jeffro256[m]: 
17:12:09 <luigi1112> where are the managers
17:14:03 <luigi1112> thanks guys
17:15:15 <selsta> i manage the merge queue does that make me a manager
17:15:19 <jeffro256[m]> luigi1112 It was tongue-in-cheek I think because someone suggested that we have a dev manager in my PR :)
17:15:45 <UkoeHB> selsta: I think you are closest we've got to a manager
17:17:05 <jeffro256[m]> luigi1112 thanks for merging. cheers!
17:17:08 <mj-xmr[m]> Thankfully the recruitment ended quickly.
17:17:49 <luigi1112> selsta for manager
17:17:58 <luigi1112> "I am the manager now" -selsta
17:18:41 <selsta> .merges
17:18:41 -xmr-pr- 8061 8232 8239 8240 8241
17:18:50 <mj-xmr[m]> .manages
17:18:58 <selsta> wow so much left to merge
17:30:11 <jeffro256[m]> SELSTA: Senior Elected Leader of Stewardship To Alterations
17:30:54 <UkoeHB> perfect
18:08:02 <rbrunner> +1
18:43:33 <Siren[m]> Hi, I tried to run monero-wallet-rpc with a view-only wallet. When I tried using the `transfer` RPC method, the wallet-rpc printed these lines and crashed:... (full message at https://libera.ems.host/_matrix/media/r0/download/libera.chat/8b23bac3625f4e88ca8039f988f6a4c91bfdcb8b)
18:52:49 <moneromooo> The crash looks like a memory corruption (or bug in the red black tree code, which less likely). Very bad. Did you build monero-wallet-rpc youtself ?
18:54:23 <Siren[m]> yes, within docker
18:54:59 <Siren[m]> I see that `incoming_transfers` method works in restricted mode, will use it instead.
18:55:16 <moneromooo> Then try rebuilding with asan (add -D USE_SANITIZER=ON to the cmake command line) and try to make it crash again.
18:55:33 <moneromooo> It should print better information, hopefully from the original bug.
18:55:57 <moneromooo> er: -D SANTIZE=ON
18:56:10 <moneromooo> Also, one little change in unbound too:
18:56:16 * moneromooo goes check 
18:56:49 <moneromooo> in external/unbound/util/storage/lookup3.c
18:57:11 <moneromooo> add this line at the very top:
18:57:15 <moneromooo> #define VALGRIND
18:57:44 <Siren[m]> alright I'll add those and get back to you some time later. It's kinda late now hopefully you don't mind.
18:57:51 <moneromooo> Sure.
18:58:37 <moneromooo> You might have to install asan libs, if you do not have them too.
19:13:02 <gingeropolous> excellent backronym jeffro256[m] 
22:13:51 <selsta> .merge+ 8245 8246
22:13:51 <xmr-pr> Added
22:23:13 <Siren[m]> <Siren[m]> "alright I'll add those and get..." <- Heya again, I ended up compiling it again but this time out of docker
22:23:48 * Siren[m] uploaded an image: (580KiB) < https://libera.ems.host/_matrix/media/r0/download/kernal.eu/RSqUduaeULCXUyhmMCvCEZMy/image.png >
22:24:39 <Siren[m]> It did not crash this time and even returned a response but there gotta be something wrong since this is a view only wallet
22:30:45 <plowsof[m]> @siren https://monerodocs.org/cold-storage/offline-transaction-signing/#offline-transaction-signing_1
22:31:56 <selsta> Siren[m]: which dockerfile did you use to build the binary that crashed?
22:32:36 <Siren[m]> here: https://github.com/cornfeedhobo/docker-monero/blob/master/Dockerfile
22:35:04 <selsta> same unbound version that we use for release binaries
22:37:56 <Siren[m]> <Siren[m]> "It did not crash this time and..." <- It's not normal for someone to give monero-wallet-rpc a view only wallet and try to transfer but maybe it would be better if this case was handled
22:50:56 <Siren[m]> If it's possible to detect that a wallet is view only, maybe it's better for monero-wallet-rpc to not start without the `--restricted-rpc` option
23:03:42 <Siren[m]>  * When a view only wallet is supplied, maybe it's better for monero-wallet-rpc to not start without the `--restricted-rpc` option
23:22:07 <jberman[m]> selsta:  fixed 8178 (rebased and updated tests)
23:22:35 <selsta> jberman[m]: was something wrong with the tests before?
23:22:41 <selsta> i just saw that it timed out
23:26:23 <jberman[m]> was my fault for not updating the tests. without those changes (specifically the ones that tell the tests to mine more blocks to the mock chain), it would get stuck in an infinite loop in the multisig and transfer tests because there weren't enough outputs in the mock chain to construct a 16 member ring
23:29:14 <jberman[m]> like this: https://github.com/monero-project/monero/pull/8178/files#diff-3e721ec1e10d7442bda5082e8a672d83b748c85cc3650ed2f098d814184ca9cfR85
23:31:50 <jberman[m]> probably shouldn't have been infinite looping and should have failed, I didn't dig deeper into the root cause there
23:33:26 <selsta> ok great, so the fail previously was expected
23:42:20 <jberman[m]> yep yep. I needed to rebase to repro the failure locally, then I made the changes to the tests in 8178 to fix the failure (specifically needed this change from master so functional tests would use the updated higher ring size rules: https://github.com/monero-project/monero/blob/53bf62d11457b011ac77d6d2947e662259cfec5e/src/hardforks/hardforks.cpp#L74-L75)