00:10:50 <selsta> .merges
00:10:50 -xmr-pr- 8299 8323 8352 8359 8379 8381 8415 8419 8427 8428 8442 8444 8450 8460 8462 8464 8465 8490 8491
04:08:43 <TrasherDK[m]> Will the merge queue get into 0.18.1 ?
05:45:00 <luigi1111w> 18.1 is done and dusted and the merge queue is for master branch
06:33:57 <TrasherDK[m]> So 8427 didn't make it. the zmq-pub thingy.
06:36:26 <TrasherDK[m]> Or was that 8cc3c9af4dde7a32d675c4297d673dee4a9c2514 Publish submitted txs via zmq
06:37:39 <jberman[m]> Yep, 8451 was the equivalent PR for the release branch and made it in (8427 is for the master branch)
06:38:06 <TrasherDK[m]> Got it. Thanks.
07:04:33 <willshu[m]> Hello
07:04:37 * willshu[m] uploaded an image: (118KiB) < https://libera.ems.host/_matrix/media/r0/download/matrix.org/OTmIDsJmrtjmyAEGIyMwczCM/image.png >
07:04:46 <willshu[m]> I use the view-only wallet plus offline wallet mechanism to sign keyImages and I found a bug.
07:05:14 <willshu[m]> In the screenshot above is how I sign keyImages in the offline wallet.
07:05:45 <willshu[m]> I deposited two amounts to the wallet: one at the primary address, one at the subaddress with index 181162. If I set up the view-only wallet to scan just 1000 subaddresses, thus skipping the one at index 181162, the outputhex contains only 1 utxo, it can be imported into the offline wallet and key images be exported without error. But if I set up the view-only wallet to scan 1 million subaddresses, thus including the one at index 181162,
07:05:45 <willshu[m]> the outputhex will be much longer, and it cannot be properly imported into the offline wallet and key images cannot be exported.
07:06:18 <willshu[m]>  when instantiating `createWalletFull`, can I specify the subaddress to be included?
15:27:43 <selsta> jeffro256[m]: I'm currently going through unused dependencies, to we use graphviz anywhere? I only see it here: https://github.com/monero-project/monero/blob/master/CMakeLists.txt#L1230
15:27:53 <selsta> do*
17:44:31 <jeffro256[m]> I think Doxygen uses graphviz for the dependency graph documention
17:46:23 <selsta> yep, but we don't need it for depends since we don't even build doxygen
17:48:33 <jeffro256[m]> Yeah that's, it would only really be needed if you were building Doxygen anyways
19:02:44 <jozsef[m]> I think doxygen uses graphviz for generating images (of, e.g., dependency graphs) during generating documentation, and not for building doxygen.
19:03:23 <jozsef[m]> But maybe that's what you meant by "building doxygen", i.e., running doxygen to build docs.
19:03:32 <jeffro256[m]> Yes, if you never run (build) your doxygen documentation, then graphviz never gets uses
19:03:35 <hyc> yes but still irrelevant for our depends builds
19:03:51 <jozsef[m]> ah okay
19:10:50 <hyc> I've never even run doxygen on our source tree. does it produce anything interesting?
19:13:39 <jeffro256[m]> It steals the main page from lmdb lol
19:13:59 <hyc> lol
19:14:28 <jeffro256[m]> It's basically unusable rn. I have a PR #8333 to reduce a lot of the noise 
19:16:09 <jeffro256[m]> It documents all the python scripts and it trips over trying to assign all the variables and functions to namespaces so it's really messy. It also documents everything in external/ 
19:17:18 <hyc> prob should prune all of external/ from its coverage
19:22:35 <binaryFate> v0.18.1.0 binaries are now available at getmonero.org
19:37:50 <selsta> jeffro256[m]: is 8333 merge ready / approved?
19:39:14 <jeffro256[m]> It's merge ready and mj approved it, it's only 4 lines of modifications if you want to review ;)
19:40:02 <jeffro256[m]> Instead of logging every single file in the project root directory, it only documents the stuff specific to this project (i.e. epee, the src folder, and easylogging++)
19:40:08 <selsta> .merge+ 8333
19:40:08 <xmr-pr> Added
19:40:17 <selsta> yea looks good
19:44:53 <jeffro256[m]> sweet
19:45:00 <jeffro256[m]> moneromoooo what do you think of this? https://github.com/monero-project/monero/pull/8489#issuecomment-1212274517
19:45:50 <jeffro256[m]> Ideally should the `index=` placement thing be an error or should it just understand either way?