06:25:53 <rbrunner> selsta: I just rebased my #8076 after the merge of jberman's #8556 caused some conflicts. Now the time for merging my PR has hopefully finally arrived.
06:26:30 <rbrunner> I wonder how to best check such a merge process on GitHub, to make sure I really only changed things to correct conflicts and did not take the chance to sneak in something malicious
06:27:03 <rbrunner> Because of the merge there are of course tons of differences now to the last commit of my PR, with over a dozen commits added to master
06:27:21 <rbrunner> Is there a way to check only my merge-conflict related changes?
06:45:16 <rbrunner> I am talking about this difference: https://github.com/monero-project/monero/compare/d6e7d663de8747aec2447f3e8b9a4d865c940289..3ec6e69184b81a6a22100715ba1c81439043ce54
09:26:21 <arnuschky[m]> Just wanted to say thanks to all involved for pushing out another release! Your work's much appreciated. Now the testing starts :)
10:45:01 <hyc> my hashes https://paste.debian.net/1254060/
10:50:35 <sech1> what, is it tagged already?
10:50:53 <sech1> I'll build binaries in the evening
11:34:13 <sech1> my hashes: https://paste.debian.net/hidden/f2ae0069/
11:36:04 <hyc> looks good
11:38:59 <sech1> https://github.com/monero-project/gitian.sigs/pull/214
12:44:40 <selsta> sech1: please upload them again to the p2pool website
12:44:51 <selsta> rbrunner: will take a look once the release is out
12:45:06 <selsta> luigi1111: please also gui merges + tag once you wake up :D
12:45:19 <rbrunner> Ok, thanks
12:45:33 <sech1> selsta I'll upload when I get home in the evening
12:45:41 <selsta> ty
15:16:28 <one-horse-wagon[> My hashes:  https://paste.debian.net/1254086
15:29:49 <one-horse-wagon[> My hashes again.  First paste was going to expire in 24 hrs.  https://paste.debian.net/1250489
15:30:32 <one-horse-wagon[> s/1250489/1254089/
15:36:32 <sech1> selsta https://p2pool.io/bin/
17:49:20 <selsta> sech1: thank you, have to wait for gui tag
18:42:02 <Wargof[m]> Hi
18:43:19 <moneromooo> hi
19:22:01 <moneromooo> Jesus fuck, whoever made 672 API layers to reach wallet2 should be... told not to do it again -_-
19:22:16 <moneromooo> Every layer with slightly differnt types, kill me ow...
19:23:02 <moneromooo> And of course Qt just HAD to have its own string class, because using std::string is for people who don't flaunt their DIFFERENCE.
19:23:55 <moneromooo> I'm gonna make my own just to spite the next poor bastard that reads this code...
19:25:04 <moneromooo> Reminds me in TF, which has String from the game engine, TBStr from the UI lib... I think there's a third one hiding somewhere too...
19:26:40 <moneromooo> Ah, tstring in litehtml. Though that one resolves to std::string (and, obviously, somthing else for windows, because fucking windows)
19:34:50 <moneromooo> No way. One layer has *both* Qstring and std::string in different functions. Asshole...
19:34:59 * moneromooo stabs
19:35:20 <rbrunner> What are you looking at?
19:35:28 <moneromooo> Garbage.
19:35:54 <moneromooo> The glue in feather wallet. Which I suspect was lifted from the monero GUI, but I haven't looked.
19:36:26 <rbrunner> Yeah, but where is that garbage? I could end up designing the API for the Seraphis core wallet, and I am looking for inspiration ... or examples how not to do it :)
19:36:55 <moneromooo> This particular one... src/libwalletqt/WalletManager.cpp
19:38:35 <rbrunner> Yeah, that "Wallet API". It seems to be quite successful. The GUI, Feather, Monerujo all use it, as far as I know. Don't really see the attraction over "pure" wallet2.h, but maybe I did not look close enough.
19:39:47 <moneromooo> The attraction seems to be "I can now juggle with one more layer". Number goes up ?
19:40:24 <moneromooo> Look ma, without the brain!
19:41:00 <moneromooo> OK, I'm being unfair here. Just annoyed at all the glue crap just to add a bloody function.
19:41:04 <rbrunner> As long as I don't have to change something there, it's possible to ignore it. Do you have to change?
19:41:34 <moneromooo> Well, depends what you mean by "have to" :)
19:41:38 <rbrunner> Ah, yes, "add a bloody function" :)
19:45:20 <rbrunner> Take it as a test of intelligence, and you passed with flying colors. Congrats. Other people would faint at the sight of the third string class :)
19:47:05 <moneromooo> I took it as a test of my piss taking detector :P
19:50:36 <moneromooo> I mean, I think I did my own string class like twenty years when I found C++. It was fun to do these little things. I don't think I ever made a lib with it though. Sorry if I did...
19:52:36 <moneromooo> OK, victory achieved over that gunk code. Feather now has hidden TF messages :D
19:52:43 <moneromooo> Pointless, but cool.
19:53:19 <moneromooo> Well, display mode. I now get to add send code. Just for hte hell of it.
19:57:26 <grumblemobile> (and, for hte record, I have a cc_message_t class. I had to add *two* different versions, one that uses std::string instead of crypto::hash, because the first wallet2 api layer uses strings instead of crypto objects, and another with QString, because Qt is scared of standard strings).
19:57:51 <grumblemobile> This is ridiculous.
19:58:05 <grumblemobile> With all the conversions of course, when you go through the layers.
19:58:21 <grumblemobile> And the slightly diffrent prototypes.
19:59:04 <grumblemobile> Someone should make a javascript API for this. That'd probably reqiure some new js string type.
19:59:42 <rbrunner> WASM. WASM is it today, I heard.
20:00:41 <rbrunner> I still have problems to believe that you can compile wallet2 and crypto code to WASM, an that bloody thing runs then.
20:00:43 <grumblemobile> What, Another String More ?
20:01:26 <grumblemobile> Yeah. That's above my pay grade. I tried to look at it and failed miserably.
20:02:07 <grumblemobile> Wasted way too much time before I cut my losses :(
20:02:55 <rbrunner> Do you build something like Feather Wallet, TF edition?
20:03:23 <grumblemobile> Yes.
20:03:34 <grumblemobile> Because why not :D
20:03:45 <rbrunner> So it manages, what it is, simply "gold"?
20:04:00 <grumblemobile> Yes. It's really monero under the hood.
20:04:02 <rbrunner> Why not - good question :)
20:04:18 <rbrunner> I remember, yes.
20:04:34 <rbrunner> Still waiting for the ICO.
20:12:14 <plowsof> reminds me a little of this PR https://github.com/monero-project/monero-gui/pull/3965 (with ints this time) 
20:14:01 <plowsof> was broken for 2~ years 
20:17:29 <grumblemobile> Nice. Objects are comparable but different types so never equal ?
20:17:58 <plowsof> yes, it gave me a few extra wrinkles 
20:19:06 <plowsof> always failed the checks and selected the default value 
20:21:04 <grumblemobile> Hmm, I guess I should also complain about functional_tests being in python (that one might be my fault), so you're told about simple dead obvious typoes after one hour of runtime.
20:21:38 <grumblemobile> OTOH it means there are lots of tests. Glass half full.
21:37:39 <luigi1112> soon