03:07:23 <almalh> Hi guys, thought I'd introduce myself, my name is Alex I'm a C++ developper "by trade", started in the aerospace industry and now I program trading systems at a financial institution. I've never worked on an open source project before so this is my first, although I've been into Monero for a while now; I only recently decided to try and contribute on a dare from a friend!  I'm making my first commits for issue 8753 please bear 
03:07:24 <almalh> e if I'm a bit clumsy with the PRs, this is quite different from the workflow I'm used to but I'll try to find my bearings quickly.
03:10:02 <selsta> hi
03:10:27 <selsta> "Handle case where a command line flag is not allowed in the config file" should still be a good thing to add in addition to the 8753 fix
03:10:56 <almalh> yeah it's coming with it that was my intention
03:11:08 <almalh> thats what I meant by clumsy with the PRs lol
03:12:02 <selsta> ok I approved it :)
03:13:14 <almalh> I'll push another commit over it though haha (to allow non-interactive in the config file) I was looking for a lock functionality to communicate that it's not ready for approval yet but couldnt find it
03:15:57 <selsta> hmm, does it touch the exact same code? otherwise I would have thought it would be best to open a separate PR for it
03:17:40 <almalh> it doesn't so not a problem I can very well make a different PR for it, thanks for the directions
03:18:42 <selsta> would recommend a separate PR in this case, also there's a draft setting which is what you are looking for when you want to mark something as not ready for approval
03:18:55 <selsta> or you can add [DO NOT MERGE] into the title
03:20:43 <almalh> makes sense thanks! I'll ask here next time
17:02:37 <Lyza> congrats on the new release umm, a little late to be asking IG but I'm curious about #8675, seems like there was some disagreement about it
17:23:08 <selsta> Lyza: there's a follow up pr for it
17:23:56 <Lyza> #8707 ? I guess that's partly why I was asking, looks unfinished
17:27:27 <veggiemaven[m]1> What is speaker's dinner supposed to mean?
17:27:27 <veggiemaven[m]1> sorry wrong chat
17:27:27 <veggiemaven[m]1> :)
17:27:46 <jeffro256[m]> It's finished and ready for review
17:27:47 <jeffro256[m]> What did you like to know about it?
17:33:31 <Lyza> that's pretty much it. looks like it would be in the next point release then?
17:41:15 <jeffro256[m]> Depends on what the reviewers think about it and whether they review it soon
18:55:03 <Lyza> hmm, okay. kind of seems like an optimization patch could have waited but, oh well. I might just hold on updating
19:39:53 <jeffro256[m]> Yes I also think sech1 ‘s PR should not have been in the latest release without the fragility fix 
19:40:24 <jeffro256[m]> Even though it is really fast
19:41:08 <sech1> fragility to code changes doesn't matter if it's a fixed code release, plus it's already fixed in your PR
19:46:23 <Lyza> yeah as long as that get gets included promptly I think it's not like, the worst thing. I may build my own with that PR once it's ready for merge, will see
20:29:08 <jeffro256[m]> rbrunner plowsof Do you have those files that jberman gave you to benchmark the RPC PR?
20:30:04 <rbrunner> Me, no.
20:30:48 <rbrunner> Didn't come around to re-do the benchmarks
20:35:09 <jeffro256[m]> I did some very bare-bones functional tests and didn't see a difference in speed 
20:35:42 <jeffro256[m]> With a local daemon though, the differences will be more pronounced for a remote daemon
20:37:13 <jeffro256[m]> rbrunner I have a peculiar issue while refreshing my CLI wallet (not related to your PR). The refreshing sometimes runs for about one second then stops for no reason because of a connection issue 
20:37:13 <jeffro256[m]> Do you experience this as well? 
20:37:17 <jeffro256[m]> If not, I'll start debugging it 
20:54:12 <jberman[m]> jeffro256: will dm the files
20:54:34 <jeffro256[m]> Thanks!
20:57:56 <jberman[m]> I also noticed a similar connection issue recently when I upgraded to ubuntu 22.04. I only see the issue with a compiled daemon, not release binaries. Been looking into the cause, no luck yet
21:10:18 <rbrunner> jeffro256[m]: Didn't especially notice something like that.
21:11:08 <rbrunner> I sometimes wonder why and how the wallet can go into "not synced" all on its own after some time for me but that's probably yet another story :)
21:11:32 <jeffro256[m]> > I also noticed a similar connection issue recently when I upgraded to ubuntu 22.04. I only see the issue with a compiled daemon, not release binaries. Been looking into the cause, no luck yet
21:11:32 <jeffro256[m]> Yup! I'm also on Ubuntu 22 
21:46:07 <selsta> jberman[m]: reminds me of https://github.com/monero-project/monero/pull/8731
21:47:45 <jberman[m]> same
21:48:49 <jberman[m]> it's what made me think to check the release binaries