02:06:17 <gingeropolous> what do I need to update?
02:16:35 <gingeropolous> ok think i got it
18:13:39 <selsta> .merge+ 8805
18:13:40 <xmr-pr> Added
18:13:50 <selsta> sech1: I assume your PR is now merge ready from your side?
18:14:28 <sech1> yes
18:14:36 <sech1> I reduced it to just 2 lines of code :D
18:15:20 <sech1> not counting comments and formatting
18:21:01 <selsta> and jeffro's separate PR isn't important for this release?
18:48:36 <luigi1111w> I will be gone for a few days starting tomorrow so hopefully we can get this wrapped up tonight
20:15:15 <jeffro256[m]> <sech1> "I reduced it to just 2 lines..." <- Correct me if wrong, but sech's PR in its current state will still drop nodes who notify with incoming blocks that contain transactions with tx_extra that is too big 
20:15:40 <jeffro256[m]> Not downloading, which should be covered, but incoming block notifications 
20:16:05 <sech1> no
20:16:15 <sech1> kept_by_block bool prevents it
20:16:34 <sech1> I'm running this PR on my nodes, and I have stable number of outgoing connections
20:26:52 <plowsof11> do you have testnet nodes running this 
20:28:29 <sech1> no, only mainnet
20:30:40 <plowsof11> later im going to have 1 testnet node runnin release + your patch. and another 18.2.0 . i will broadcast nfts from the 18.2.0 node and see i get banned. (i will add-priority-node=release+patch to the nft node) does this sound like a sane test? and check if i get banned?
20:31:13 <sech1> you will not get banned even without the patch
20:31:28 <sech1> it just drops connection without it
20:33:23 <plowsof11> ah ok so the ban check is redundant, so the release+patch node 'will not have those  errors we seen with release' of tx failing verification
21:43:42 <plowsof11> minted 27 ordinals. sitting in mempool. made 1 normal tx. the node with release+patch see's only the 1 real tx (nobody is mining nfts on testnet atm)
21:51:46 <plowsof11> connections stable on mainnet release+patch. i will leave it an hour or 2 then mine my own morbinals because all the testnet miners must be using the patch 
21:52:19 <plowsof11> my normal txs appear in other nodes mempools / mined blocks 
22:39:38 <sech1> hmm, my home node was failing to start. It turned out I had node.majesticbank.su in my long list of priority nodes in bitmonero.conf - this failed to resolve, and monerod was failing to start, and the error message couldn't be seen until I increased log level. Not the best UX
22:41:13 <sech1> I've also found one more critical bug that makes it nearly impossible to sync from 0 on Windows under certain conditions (but they're rare, so we're lucky). I'll make a PR with the fix tomorrow.
22:42:24 <ofrnxmr[m]> I can confirm, I can sent 1kb jpegs but cent send over that
22:42:55 <sech1> I only found this sync bug because my node wasn't starting and I tried to delete data.mdb and sync again
22:44:00 * ofrnxmr[m] uploaded an image: (1KiB) < https://libera.ems.host/_matrix/media/v3/download/monero.social/qhguScikOIoIPByXHUVzbFGF/pt6rzbn3u0brnj99.jpg >
22:44:11 <ofrnxmr[m]> sech1:  my apologies 🙏
23:07:20 <plowsof11> the above image is 985bytes, it was broadcast/minted by a node running the tx limit patch (i wrongly assumed it would limit sending an image of 32 bytes or 255 if the image was split over all outputs). i will now mine the ordinals in my mempool - mainnet connections stable, looks good sech1