00:12:21 luigi1111w: I feel like we will have to wait until you are back so that we can have more time to review and test 00:12:26 @sech1 Okay I trimmed down my alternative PR to its absolute smallest (not including comments), and I made you co-author . I don't want to start a pissing contest over trivial things, but I prefer my PR because it also fixes connection dropping for fees that are too low 00:12:42 What do you think of it? 00:13:16 It doesn't make changes to for ZMQ optimization but IMHO that should be a different PR 00:15:20 > it also fixes connection dropping for fees that are too low 00:15:54 And could be easily extended to other relay only rules by adding one line of code in the tx pool, without having to touch the protocol handler each time a change is made 01:02:05 selsta kk 05:17:44 jeffro256[m] do ZMQ fix a second commit too, wtf 05:17:53 why are you making everyone do more work 05:18:03 I'm working on a totally different fix now, do waste my time 05:18:14 *don't waste my time 05:18:31 sech1: b/c it's a better fix 05:18:56 just do a second commit with ZMQ 05:19:09 I'm not going to make a separate PR just because "it's more right" 05:19:25 I'm working on a different fix already while you're obsessed with "by the book" 05:20:31 Did you miss the part where my PR in question fixed more than tx_extra? 05:20:41 It's just 4 lines of code 05:20:41 Just look what bug I found: https://p2pool.io/u/d70f28419ee2a43d/image.png 05:20:49 I don't care about that PR anymore 05:21:15 8808 is ok as long as you add ZMQ fix 05:22:13 Soon I'll find out how many threads it's allowed to create per process in Windows, lol :D 06:50:00 hyc https://github.com/monero-project/monero/pull/8810 08:22:52 .merges 08:22:52 -xmr-pr- 8794 8805 08:23:57 8811, 8813 (and their copies for master branch) need a review 08:24:14 I mean one more reviewer 12:22:37 .merge+ 8810 8811 8808 8813 12:22:37 Added