00:08:18 <Pascal123> good night
06:34:47 * DonW16[m] uploaded an image: (33KiB) < https://libera.ems.host/_matrix/media/v3/download/matrix.org/rKFlmTlPxspwFtNtzpNntlqc/image.png >
06:35:05 * DonW16[m] uploaded an image: (32KiB) < https://libera.ems.host/_matrix/media/v3/download/matrix.org/AZSkXmpVIyHVvCMSFPifSCtm/image.png >
06:35:22 <DonW16[m]> Good morning guys, after further testing I can confirm that when compiling the Monero source code the release version of the build provides the tests however the debug version of the build does not, can I make changes to the tests README.md so this makes more sense?
06:38:29 <DonW16[m]> I compiled the source code with the following commands 
06:38:37 <DonW16[m]> make and make debug
06:39:38 <moneromooo> Looks like a bug then, neither should build the tests.
06:40:04 <moneromooo> Were these in clean trees ? If not, cmake will cache stuff.
06:40:21 <moneromooo> cmake can be annoying in what it caches.
06:45:07 <DonW16[m]> Hey moneromooo 
06:45:12 <DonW16[m]> What do you mean clean trees? Thanks
06:45:57 <DonW16[m]> I've followed the compile from source instructions the only difference I've done is create my own branch for changes.
06:46:09 <DonW16[m]> How do you clean the cache for cmake?
06:48:18 <moneromooo> I mean without a build tree ,which is where cmake caches its stuff.
06:48:37 <moneromooo> make clean would clean a tree. Or rm -fr build.
06:50:31 <moneromooo> I just looked at the Makefile, this is expected.
06:51:09 <moneromooo> The default is to build everything.
06:57:40 <DonW16[m]> I've cleaned the build tree and the bug is reproduced.
06:58:12 <DonW16[m]> option(BUILD_TESTS "Build tests." OFF) should this be changed to ON?
06:59:56 <moneromooo> If you can make a good argument that it should be.
07:01:00 <moneromooo> If the default is arbitrary, it should be left as is, to avoid confusing people and/or needing to change stuff that already works.
07:02:04 <moneromooo> Also, if you problem is simply that you want to build tests wihtout debug flags, you can use make release-test.
07:02:18 <moneromooo> Or make release.
07:02:27 <moneromooo> I think. Lemme check acrually...
07:03:17 <moneromooo> Yes. release-test (though it will try to run the tests, you'll need to ^C if you don't want that).
07:11:25 <DonW16[m]> Can I update the README.md within the tests folder so it reflects what you've just said? At the moment it does not reflect that and is confusing.
07:13:23 <moneromooo> Sure.
07:14:11 <DonW16[m]> Thx for the help :)
10:11:44 <Pascal123> hello ....
10:12:13 <Pascal123> for experiments i suppose its easier to make requeststo daemon, too...
10:12:45 <Pascal123> but i encounter q question: https://pastebin.com/5mnuBsG6 is the miner_tx_hash the same as merkle root ?
10:15:26 <sech1> No, it's the hash of miner transaction. Merkle root is the root hash of all transactions in the block (arranged in a tree)
10:16:10 <Pascal123> ah ok, could i use the merkle root function of bitcoin, for calculating the hash or is it different from monero
10:16:14 <Pascal123> ?
10:17:05 <Pascal123> do i need to hash the result of transaction tree with cryptonote or is the data ready to use after creating merkle root ?
10:20:20 <sech1> No you can't use bitcoin code for Monero
10:20:28 <sech1> check src/crypto/tree-hash.c
10:20:36 <sech1> you need "tree_hash" function
10:21:06 <sech1> cn_fast_hash = keccak
10:21:22 <Pascal123> ok sech1, thank you
10:21:24 <Pascal123> :)
17:00:37 <plowsof11> vtnerds ccs proposal is up (pending rendered markdown from the description) https://repo.getmonero.org/monero-project/ccs-proposals/-/merge_requests/391/diffs