06:10:51 <sech1> luigi1111w yes, but wait until all fixes are ready to be merged
09:03:33 <selsta> TheCharlatan: we are skipping v0.18.3.0
09:03:48 <selsta> since you are merging gitian PRs
09:04:09 <selsta> I guess it doesn't hurt to also merge them but we will release v0.18.3.1 instead
09:54:37 <m-relay> <m​onerobull:matrix.org> does anyone here know lalanza808?
09:56:37 <m-relay> <m​onerobull:matrix.org> i cant get monero.fail to install 😭
09:58:16 <selsta> monerobull: he is in #monero-community-dev, username lza_menace
09:58:58 <m-relay> <m​onerobull:matrix.org> thanks
12:19:18 <selsta> .merge+ 9012
12:19:18 <xmr-pr> Added
15:35:19 <selsta> .merge+ 9013 9014
15:35:20 <xmr-pr> Added
15:43:36 <Andrei> Hello.
15:43:36 <Andrei> How can I convert a transaction blob to a transaction hash like "01d4da0e01ff98da0e0180a5f3d0f00402b9485b5bfdb1e78de6ee23fda67545a08db295ad8f34e7bef257eb1a8ee6efb32b01b32dd844ff03ce76f20bc337a6aa9c65cc35958191275200505d3da06c7087df02080000000000000000"?
15:43:37 <Andrei> Should I simply use the cn_fast_hash function? The result I got is 40602c6a4047d0dd9305397048e4cf20f900b6446259b05299e133981039bd3d, but I'm not certain it's correct.
15:55:52 <moneromoooo> If it's a recent tx, it's not correct. Safest is to decode ut, then call get_transaction_hash on the tx.
15:59:20 <Andrei> It is a coinbase transaction from block template.
16:01:50 <Andrei> I want to convert a blocktemplate_blob to a blockhashing_blob in Python.
16:01:50 <Andrei> Is my understanding of the algorithm correct?
16:01:51 <Andrei> * Convert the coinbase transaction blob to a transaction hash using cn_fast_hash.
16:01:51 <Andrei> * Construct the Merkle root using [coinbase_tx_hash, tx1, tx2...].
16:01:52 <Andrei> * Add the Merkle root to the end of the block header.
16:05:40 <moneromoooo> IIRC you also have a varint for the number of entries in the merkle tree.
16:06:17 <moneromoooo> Other than that, I *think* it's correct.
16:07:12 <moneromoooo> For recent txes, the hash is calculated by calculating the keccak of several parts of the tx, so decoding is a must.
16:07:29 <moneromoooo> (helps with pruning)
16:08:12 <moneromoooo> For coinbase txes, it's easier as one of the parts is always empty so you can do it manually without decoding. But you presumably have non-coinbase txes also.
16:25:04 <sech1> coinbase_tx_hash is not so straight-forward to calculate, but you are correct. You need to calculate the Merkle root after that, and write the number of transactions (including coinbase_tx) as a varint in the end
16:26:45 <sech1> Ever since Monero has pruning, a transaction hash is a combination of several hashes
16:26:59 <sech1> get_transaction_hash is the easiest way to calculate it
17:55:40 <selsta> .merges
17:55:40 -xmr-pr- 9011 9012 9013 9014
17:55:49 <selsta> luigi1111w: we can tag v0.18.3.1
17:56:23 <selsta> of course merges first
17:57:14 <hyc> did I miss v0.18.3.0 ?
17:58:00 <hyc> ah there it is
18:21:13 <luigi1111w> k
19:42:29 <luigi1111w> tagging...
19:43:17 <selsta> yep
19:44:41 <sech1> building...
19:45:11 <m-relay> <r​ottenwheel:nokyc.im> v0.18.3.1 tag is ready. https://github.com/monero-project/monero/releases/tag/v0.18.3.1
19:49:10 <hyc> cool, just started a build
20:14:44 <sech1> my hashes https://paste.debian.net/hidden/6d32e67d/
20:18:07 <sech1> https://github.com/monero-project/gitian.sigs/pull/253
21:54:38 <selsta> CI hashes: https://github.com/monero-project/monero/actions/runs/6384731211
21:55:31 <selsta> matches
22:59:32 <selsta> jeffro256: can you follow the explenation here? https://github.com/monero-project/monero/pull/8752#issuecomment-1741701255
23:00:19 <selsta> it would be nice if a second person could review the chain gen changes
23:02:49 <m-relay> <j​effro256:monero.social> Yes that explaination was great, I was poking around the tests and reading the changes for myself earlier today
23:03:21 <m-relay> <j​effro256:monero.social> I plan to approve it either today or tomorrow as long as I don't see anything wrong
23:03:35 <m-relay> <j​effro256:monero.social> It looks solid so far
23:18:46 <selsta> perfect, thank you