11:51:14 <gingeropolous> reading 9185, see in conversation: "and use a proper commit title like Doxygen: fix broken links."   In contributing.md, the instructions for title are: "That means a subject line that describes the patch". Upon loooking at all the PRs, i do see a lot of this <xxxx>:<aaaa bbbb cccc> . So is xxx like the area of code? trying to refine contributing.md to instruct properly
11:57:17 <m-relay> <t​obtoht:monero.social> gingeropolous: yes, it usually points to a subdirectory under src/ or contrib/ where the changes were made, or more generally describes the type of change
11:59:39 <gingeropolous> ok., the existing title is "fix broken links". which imo describes the change, but not where i guess
11:59:57 <gingeropolous> well, im off to do my little bike shed PR
12:03:51 <moneromoooo> Without the prefix, it only vaguely describes. It could be broken links to the update downloads, to the IRC web proxy, etc. The prefix is a succint way to incresae the accuracy of the rest of the description.
12:04:46 <moneromoooo> If I see "doxygen: FOO", I know I don't have to care about this patch if I'm not looking at documentation stuff.
12:06:26 <gingeropolous> indeed. thanks!
12:10:22 <gingeropolous> hrm, moneromoooo your listed under "monero maintainer team" along with fluffypony and hyc . this is in contributing.md
12:10:59 <moneromoooo> I guess it means main contributor. I do not (and never had) repo write access. Feel free to remove me.
13:08:36 <hyc> I recall I have access to close tickets
13:47:43 <moneromoooo> Ah, I have that too if that's what maintainers means. I was thinking more push rights.
18:58:23 <m-relay> <s​omeoneelse495495:matrix.org> moneromoo, what was the reasoning behind monero-wallet-rpc resolving to `localhost:8080` if no daemon address is provided ? (wallet/wallet2.h, L1000)
19:17:13 <sech1> This "localhost:8080" has been there (in the "init" function) since the very first commit on github. So it's a remnant of the original Cryptonote codebase
19:17:45 <sech1> so it's older than when port 18081 was chosen to be used by default
19:19:18 <m-relay> <s​omeoneelse495495:matrix.org> alr, thx for explanations. should i make a pr to change these to 18081 ?
19:20:25 <sech1> I think you can just remove the default value there
19:20:36 <sech1> It's always called with daemon address filled in
19:21:02 <m-relay> <s​omeoneelse495495:matrix.org> I'll still make an assertion since docs are stating it is optional
19:22:12 <sech1> I don't know what would be the good default value there. Port 18081 is default only for the mainnet, but there are also testnet and stagenet
19:22:18 <sech1> better just remove it
19:22:29 <m-relay> <s​omeoneelse495495:matrix.org> alright
20:23:27 <m-relay> <s​omeoneelse495495:matrix.org> tested, made pr. but omg wallet2.cpp is so laggish, vscode didn't stopped crashing
20:24:51 <m-relay> <t​obtoht:monero.social> SyntheticBird45: please use spaces instead of tabs
20:27:51 <m-relay> <s​omeoneelse495495:matrix.org> fixed 👍️
20:36:40 * moneromoooo imagines Linus saying "that userspace is so crap, my kernel crashes on it" and calling it a day.
20:37:28 <moneromoooo> As for default param, there is a get_config(network_type) which can give you access to the default ports.
22:01:31 <m-relay> <s​omeoneelse495495:matrix.org> done. in case of empty strings set_daemon resolve to `"http://localhost:" + get_config(m_nettype).RPC_DEFAULT_PORT`
22:21:23 <m-relay> <s​omeoneelse495495:matrix.org> Tested, it resolve to localhost:RPC_DEFAULT_PORT
22:21:27 <m-relay> <s​omeoneelse495495:matrix.org> Tested, it resolve to http://localhost:RPC\_DEFAULT\_PORT