09:11:17 <m-relay> <321bob321:monero.social> * Thanks Sleepy Joe 09:13:03 <m-relay> <syntheticbird:monero.social> Joe joe, can you pardon kewbit please 13:37:12 <binarybaron> Hi, we are trying to migrate from monero-wallet-rpc to native wallet2 bindings (using monero_c, a C wrapper around wallet2). I'm trying to move from a HTTP call to check_tx_key to a C call to MONERO_Wallet_checkTxKey. However I'm a bit unsure why there is a difference between the two. check_tx_key takes a txid, tx_key and address and gives me back 13:37:13 <binarybaron> confirmations and the received amount. MONERO_Wallet_checkTxKey however takes all 5 and only returns a boolean? 13:41:32 <binarybaron> https://docs.getmonero.org/rpc-library/wallet-rpc/#check_tx_key 13:41:32 <binarybaron> https://github.com/monero-project/monero/blob/1bd57c8e959d80d7f6cb21a0e560958c21c5d693/src/wallet/api/wallet2_api.h#L1026 13:41:32 <binarybaron> https://github.com/MrCyjaneK/monero_c/blob/bbb28c741f902fb585d2c13b786e029018ebfde8/monero_libwallet2_api_c/src/main/cpp/wallet2_api_c.h#L781-L782 13:41:33 <binarybaron> Probably a mistake in the monero_c wrapper code? MONERO_Wallet_checkTxKey should take a reference instead of value? 13:42:00 <m-relay> <syntheticbird:monero.social> probably better to ask in #monero-dev-community since Czarnek which i believe to be the author is there 16:56:13 <selsta> jeffro256: can you take a look at https://github.com/monero-project/monero/pull/9459#issuecomment-2589519946 again? 17:03:15 <binarybaron2> Suppose I wanted to build on top of monero-cpp and build a wrapper. Which should I use? simplewallet.h, wallet2.h or wallet2_api.h? 17:04:46 <binarybaron2> by monero-cpp I mean the normal monero core repo 17:06:01 <m-relay> <woodser:monero.social> would recommend wallet2.h for now 17:06:20 <m-relay> <woodser:monero.social> wallet2_api.h was created for the gui, though I hear they're working on porting all functionality to that 17:06:23 <m-relay> <woodser:monero.social> simplewallet.h is for simple command line tool 17:07:29 <moneromooo> wallet2_api is a gratuitous extra api for no good reason (apart from thr async stuff it adds, which does add value). 17:07:57 <moneromooo> But the redefinition of structures is just... wtf... 17:08:19 <binarybaron2> Is wallet2_api.h being used in the GUI yet? We are basically doing what the GUI is doin (wallet functionality and a few other things) but in Rust 17:08:46 <moneromooo> It is. 17:09:44 <binarybaron2> As far as I understood wallet2_api.h is going to act as a compatability layer for the upcoming hardfork? 17:39:39 <binarybaron2> 74 | SL(boost::asio::io_service::work); 17:39:40 <binarybaron2> | ~~~~~^ 17:39:40 <binarybaron2> /Users/me/code/monero-wrapper/monero-cpp/src/debug_utilities/object_sizes.cpp:62:39: note: expanded from macro 'SL' 17:39:41 <binarybaron2> 62 | #define SL(type) sl.add(#type, sizeof(type)) 17:39:41 <binarybaron2> Anyone know how to fix this build error? 18:13:24 <m-relay> <rbrunner7:monero.social> The "Wallet API completion PR" is quite advanced already and ready for review: https://github.com/monero-project/monero/pull/9464 18:15:32 <m-relay> <rbrunner7:monero.social> I am well aware that the move from wallet2 to the Wallet API does not make everybody sing with joy, but hey, still cementing the monster that is wallet2 further, in 2025? Come on :) 18:18:03 <m-relay> <rbrunner7:monero.social> Especially when you more or less have free choice, like binarybaron2 may have now 18:25:16 <m-relay> <rbrunner7:monero.social> "As far as I understood wallet2_api.h is going to act as a compatability layer for the upcoming hardfork?" Don't think so, not yet for the very next hardfork. 18:27:00 <m-relay> <rbrunner7:monero.social> The Seraphis Wallet Workgroup had the very ambitious and ultimately failed plan to replace wallet2 not by the Wallet API, but something brand new, with the goal to remove wallet2 already with the hardfork to Seraphis. Didn't get very far ... 18:46:53 <m-relay> <jeffro256:monero.social> selsta: yes, sorry I meant to earlier, but got distracted