06:54:22 Hi everyone, 06:54:22 I'm Karun, a developer with experience in C and C++, specializing in optimizing high-performance applications. I also have a background in DevOps and cloud technologies, as well as web development using JavaScript and Node.js. 06:54:24 I’ve been exploring the repositories and am eager to contribute by addressing existing issues or improving the codebase. Any guidance on where to start or areas that need attention would be greatly appreciated. Looking forward to collaborating with all of you! 06:54:26 Thank you! 07:25:06 Hi. My usual guidnace to start with monero is: use the software, find small bits that annoy you, and improve them. 07:25:42 It gives you small enough tasks to do, with a personal goal to give you some drive to finish it. 07:25:53 And you learn what's where along the way. 07:39:32 Karun : You say "specializing in optimizing high-performance applications". Well, looks like we do have a need for some optimizations soon, and we even intend to hold a contest where people can submit their improved solutions and win some prize. 07:40:06 For background you may check the log of the last MRL (Monero Research Lab) meeting here: https://github.com/monero-project/meta/issues/1145 07:42:05 From one of the links there: "The goal of this contest is to provide optimized implementations of helioselene and ec-divisors" 07:43:13 Not sure, that may mean coding stuff in Rust however, not C / C++ 11:28:39 .merge+ 9467 9456 9671 9538 9723 9708 11:28:39 Added 11:29:27 vtnerd: could this be related to the recent network code changes? https://github.com/monero-project/monero/actions/runs/12969219043/job/36173269466?pr=9723#step:11:1380 11:29:51 it only fails sometimes 12:16:34 ofrnxmr: can you look at 9467, need it for fcmp++. others would be helpful too. 12:40:45 tobtoht_ the general rule of thumb is that if hinto approved your PR you can be proud of you 12:41:01 tobtoht\_: The general rule of thumb is that if hinto approved your PR you can be proud of you 12:45:33 ok, i want a show of hands. is there anyone besides ofrn who objects to me merging QUEUED prs if they are my own? 12:45:42 we're doing rough consensus now 12:47:19 Well the first step there would be to open a pr to change the rules 12:47:29 i knew it 12:47:44 you gave me dopamine 12:49:22 cant just be all unprofessional with it. I dont have a problem with prs for CI or like luigi worked it "duh" prs. But there should be a documented process for anything else 12:49:59 Currently that process is min 7 days + dont merge your own unless exceptional circumstances (and more, but this is the gist) 12:51:48 was there a PR to behin with that establish the "maintainer PRs must be reviewed by ofrnxmr and ofrnxmr only"? tobtoht_ relying on hinto's approval isn't unprofessional since hinto is completely competent and collaborate on Guix. 12:52:34 no, i never asked for that either 12:52:53 Hinto's approval doesnt supercede anything else, nor does mine 12:53:45 there are some of these prs that have 3 or 4 approvals, and are "duh" 12:54:01 some of them have 1 approval and are somewhat less than "duh" 12:54:05 I'm just notating that your suggestion of "pr to change the rules" make no sense. 12:54:22 Explain? 12:54:51 the rules (on the repo, in contributing.md) say 7 days and dont merge your own 12:54:54 as for the PR in itself, it's a relatively minor one, its not "duh", hinto validated it, tobtoht_ should be free to merge it without waiting on your review 12:55:17 Oh 12:55:47 It has 3 approvals. Not just hinto's 12:56:03 Selsta just added it after tobtoht_ asked 12:56:18 Last commit was a month ago, so even the contributing.md doesn't apply here 12:56:44 mind explaining where is the issue here? 12:56:50 3 approvals is 1 more than the 2 needed, and the pr is old. I'd argue on that basis that its similar to if it was written by someone else and has 2 approvals 12:58:17 Not merging your own prs is in the md. But as i said in my last msg, i think the third "valid" approval might be fair to bypass that rule 12:59:27 Ok so you are arguing that for a maintainer to merge its own PR, it should be validated by 3 different people, is that right? 13:02:18 what do we think of this language: "Maintainers MUST NOT merge their own patches unless they were added to the merge queue on irc and have at least 2 approvals from contributors." 13:02:54 3 if own imo 13:03:00 2 for not your own 13:03:28 do we count selsta adding to the queue as an implicit approval? 13:04:01 thats a question for selsta. I dont think so though 13:04:39 selsta isn't overlooking, I would count it as a valid review 13:04:49 selsta adds things to queue based on approval of others. Selsta reviews prs and leaves approval on the pr when necessary 13:05:04 adding to the queue is not an approval from me 13:05:13 i approve them explicitly 13:05:26 ok 13:05:30 selsta ofrnxmr thumbs you up 13:05:39 so queue + 3 approvals? 13:06:08 why would the queue be relevant. Isn't all prs supposed to be in the queue to be merged 13:06:20 For own, that sounds sane, yes 13:06:56 4 parties minimum to a pr 13:11:12 my bad i misunderstood, fwiw I thought tobtoht_ you were only talking of 9467. So yeah I'm against you merging all your own PRs. 13:16:04 https://github.com/monero-project/monero/pull/9730 13:20:05 [@jeffro256:monero.social](https://matrix.to/#/@jeffro256:monero.social) [@jberman:monero.social](https://matrix.to/#/@jberman:monero.social) [@jberman:matrix.org](https://matrix.to/#/@jberman:matrix.org) [@0xfffc:monero.social](https://matrix.to/#/@0xfffc:monero.social) [@vtnerd:monero.social](https://matrix.to/#/@vtnerd:monero.social) ^ 13:20:13 @room directly at this point 13:20:15 @everyone 13:20:28 call them on their personal phone number too 13:21:07 Sending immediate smoke signals 13:25:11 how to use the software ? 13:26:33 okay grandpa let's get you to bed 13:28:33 🚶‍♂️🛌 14:43:25 Nooo please noo 14:44:43 I can give you some stagenet monero’s