01:04:37 <tobtoht_> https://github.com/monero-project/monero/pull/2174
01:04:48 <tobtoht_> I love how the contributor guidelines itself were yolo-merged before anonimal addressed all of moo's comments.
01:07:32 <tobtoht_> Why we recognize a document that was more-or-less copy-pasted from zeromq is beyond me.
01:09:17 <tobtoht_> Half of it doesn't even make sense in the context of this project.
05:34:02 <m-relay> <r​brunner7:monero.social> "pasted from zeromq" Just imagine how hard it would have been to find consensus for something new written from scratch ....
11:36:46 <Cindy> can i strip out the supercop components off the build system?
11:37:15 <Cindy> it's causing issues with building it, and it doesn't seem to be a necessary component (since it's just to evaluate the performance of cryptographic algorithms)
11:38:25 <Cindy> (also i'm not gonna push this to upstream, just modifying my copy of monero)
14:04:26 <m-relay> <o​frnxmr:monero.social> > <t​obtoht_> I love how the contributor guidelines itself were yolo-merged before anonimal addressed all of moo's comments.
14:04:28 <m-relay> <o​frnxmr:monero.social> because there were no guidelines and a lot of stuff was yolo merged w/o addressing reviews
14:05:37 <m-relay> <o​frnxmr:monero.social> The C4 was decided on in meetings
14:08:24 <Cindy> surprising how much stuff i have to patch out to make an automated library build of monero
14:11:33 <Cindy> at least, one that would work in meson
14:19:58 <Cindy> (and apparently supercop offers fast cryptographic operations for monero wallets, but has a misleading name that makes it look like it's just there to benchmark cryptographic algorithms)
15:30:20 <tobtoht_> ofrnxmr: "The C4 was decided on in meetings" <- Yeah?
15:30:23 <tobtoht_> "A new Contributor who makes a correct patch MUST be invited to become a Maintainer."
15:30:33 <tobtoht_> Give me a fucking break. Not one person read this thing.
15:33:54 <ofrnxmr> It was clearly read and modified, but clearly not well
15:34:35 <ofrnxmr> I noticed that as well and luigi commented (months ago) that he disagreed with that line. Obviously it hasnt been touched in years
15:34:53 <ofrnxmr> It was implemented in place of a CoC
15:35:39 <ofrnxmr> as you said, it was yolo merged without addressing comments (like many other prs at the time)
15:37:02 <ofrnxmr> Cant be "not read" and have unaddressed comments simultaneously. Back then we had a core team who, by the governance structure, had veto over everything
15:37:26 <ofrnxmr> times change(d)
15:40:37 <tobtoht_> "Cant be "not read" and have unaddressed comments simultaneously. " <- Moo, the only reviewer, literally says: "I've stopped in the middle". That line appears near the end.
15:41:01 <tobtoht_> And we have been ignoring it ever since, until you found a clause that aligned with your opinion. Might as well start over if it wasn't done properly the first time.
15:42:20 <ofrnxmr> if you want to go ahead and yolo merge all of your own prs, w/o merge queue, or however you first proposed, go ahead and do it. I'm not your boss
15:42:51 <ofrnxmr> If you dont like my opinion or the clause in the guide, youre free to do whatever tf you want
15:45:08 <ofrnxmr> You're definitely not accountable to me and don't have to pay any attention to my opinion, and i'm definitely free to disagree with setting precedent that we should go back to the days when things were yolo merged
15:46:43 <tobtoht_> I'm not interested in yolo-merging any PRs. And I do value your opinion.
16:03:57 <m-relay> <j​effro256:monero.social> Cindy: you can't remove it easily, `wallet2` uses the supercop repo for a fast implementation of ECDH when scanning. However, if you refactored `wallet2` I'm sure that you could switch it out for a different implementation, even if that one was much, much slower
16:04:15 <Cindy> nah, i finally got supercop to compile
16:04:28 <Cindy> i removed the "-x cpp-with-assembler" build flag
16:04:39 <Cindy> and renamed consts.s to consts.S
16:04:49 <Cindy> (which made GCC parse it as assembler with C preprocessor)
16:07:46 <Cindy> meson misinterpreted the "set_source_file_proprieties" from CMake's trace JSON, and applied the parameters to all source files within the supercop targets
16:07:54 <Cindy> so that was a hack i had to do
16:08:17 <Cindy> (since meson can't apply specific flags to specific source files within a target)
19:11:02 <edgzoah> hello i have faced an issue with debugging monero code in clion, i have set build type as debug but still when i try to jump inside some wallet2 functions i get moved to functions not inside of monero like stl_vector.h, do i have to setup something more to get it to work?
19:11:36 <edgzoah> i mean i jump into some random functions inside of stl_vector.h
19:33:11 <m-relay> <j​effro256:monero.social> Are you using `gdb`?
19:40:09 <plowsof> edgzoah has disconnected from IRC 
19:43:35 <m-relay> <r​brunner7:monero.social> Probably hit a breakpoint :)
20:20:08 <sech1> If you use "step into" on some line of code, the debugger will step into all function calls on that line, one by one. It's probably some vector size() calls that get in the way first