03:07:09 .merges 03:07:09 -xmr-pr- 9791 9808 9809 9821 9840 03:12:53 #9791 and #9840 need +1 approval. #9808 needs response from author. 03:43:31 .merges 03:43:31 -xmr-pr- 9808 12:00:13 vtnerd: please check 9759 12:21:21 Only an issue on release, yea? 12:28:50 ofrnxmr: https://github.com/monero-project/monero/pull/9582#discussion_r2009853341 12:31:50 Sorry :P last msg was for a DM 14:32:07 m-relay: vtnerd 14:32:25 He's sleeping 14:33:07 now you woke him up 💢 (jk) 16:04:43 9861 and 9862 are up cc sech1 16:30:42 .merge+ 9861 9862 16:30:42 Added 16:59:47 jeffro256 I prepared a branch with working cppcheck (well, almost working - still one critical error left) https://github.com/SChernykh/monero/tree/cppcheck 16:59:59 I don't see any major errors (most are false positives) 17:00:10 But you can go through the list or try to run it yourself 20:46:45 Is this a misunderstanding/FUD or true? https://njump.me/nevent1qqs8vlthavdqcznk0us3aaqkv6af4y852crqvafkssqd3j6ve28xshqpz3mhxue69uhhyetvv9ujuerpd46hxtnfduqs7amnwvaz7tmwdaehgu3wd4hk6q3qgm7tuvr9atc6u7q3gevjfeyfyvmrlul4y67k7u7hcxztz67ceexspdwpdp 20:50:21 Probably won't get many bites with a url looking like that. 21:03:13 Well, the repository this tool was forked from has a warning "Vulnerability Warning: Do not use this library": https://github.com/meling/urs 21:03:43 So yeah, maybe we really should remove this 10 year old grandpa of a tool 21:05:04 Relevance for Monero cryptocurrency security probably a big fat ZERO, but can still shine a bad light on the project and how it's managed 21:06:26 @luigi1111: Maybe nuke that thing? https://github.com/monero-project/urs 22:13:57 Or just make it a private repo 22:15:45 rbrunnner, the warning was added.. yesterday :D 22:18:05 https://kewde.github.io/urs moneromooo 22:20:36 wow KEW* jumpscare 22:21:09 after reading the disclaimer, just delete the fork "the vulnerable code is not critical to the Monero cryptocurrency. The code is in no way or form used in the reference client of the CryptoNote protocol" 22:25:46 bit of history: kewde is/was part of particl 22:26:01 He has presented at monerkon 22:26:05 I will get rid of it I guess