07:19:47 Hi, I opened my first pull request fixing a minor warning: https://github.com/monero-project/monero/pull/10088 07:19:48 Im trying to join monero dev on matrix but getting "Registration has been disabled on this homeserver. 07:19:48 ". Let me know if I should/need to just choose a different home server before joining. 08:57:07 Registration on the homeserver is disabled you have to choose a diffrent homeserver unfortunatly 12:59:30 Is it safe as a lightweight method to detect a payment, to query with json rpc a node (public node) in the following steps: 1. Get current height 2. Get transaction hashes from last block. Then for each transaction: 3. Get transaction public key and decode outputs using private view key looking for a match (recipient subaddress and amount)? 17:08:00 complaint about check_tx_proof 17:08:04 $ echo -n "OutProofV22tNdKUEy8Zc8wyMxVECS6C3eYAA9P7tCribN31YZ2VbTahBJgv6RYaJHJGwHCS6cDXKFXuQQx8Nu2U7EEjeDq5EiSx9WtFmUyrHFLF88zsDybhigkMtzTmq8K6CobZHbSWT3" > proof.txt 17:08:05 check_tx_proof 68890618e2331fa771664479d36b7895bbf9dd89985ed260afc6129959258b52 48XXcXEC1b79VBjUAKSM5EX5jBDHdkraPRpjVFBUz7yv5sDXWVCvPdQBx53uAqHsifXaPBgtQJm4dTutNCZoR2ZT2tQh36i proof.txt 17:08:17 this is silly. first proof.txt cannot have newlines or spaces 17:08:33 then proof.txt is always one of these OutProof/InProof etc. versioned strings 17:08:45 why can't the last arg on check_tx_proof also accept one of these directly? 17:09:47 (or at least accept newlines, so nano/other editors that add newlines can be used to make this file) 17:10:19 Not accepting newlines sounds unintended 17:10:36 Ending a file with a newline = posix compliant 17:11:44 On GUI there's just fields for all of it 17:11:58 https://irc.gammaspectra.live/fb5795c2160d005f/image.png 17:16:06 some of the proof explanations get kinda silly https://p2pool.observer/proof/fba9a44bbe1fa71c7538c364ab27bd253ddb885d2e1d76405a1976782e67f8b5/31 17:16:13 > Place the signature proof on a file, then call check_tx_proof in CLI. Ensure no newlines or spaces exist on the file. 17:17:24 Does it have to be in a file? 17:17:46 it has to be in a file 17:18:00 Error: usage: check_tx_proof
[] 17:18:18 if I try with the OutProofV2 17:18:25 Error: failed to load signature file 17:20:05 if there are newlines/spaces in file 17:20:06 Error: error: Wrong signature size 17:27:59 What is the correct way to generate checksums for Monero addresses? I've tried the pycryptodome keccak implementation in Python, and the js-sha3 keccak_256 implementation in JavaScript but I've bumped into a specific set of public Spend and View keys which doesn't generate the correct checksum when using those libraries compared with the checksum from luigi1111 at https://xmr.llco 17:28:01 ins.net/addresstests.html 17:29:00 only that pair or did you try others 17:29:06 they should either all work or none work 17:29:10 keccak_256, take 4 bytes out little endian 17:29:22 This pair specifically, that's what's odd! 17:29:45 https://git.gammaspectra.live/P2Pool/consensus/src/branch/master/monero/address/address.go#L144-L150 17:29:48 got the pair? 17:30:10 or address itself 17:30:43 The content 12279d2ada9e7c509981294e0226d245a0a2dbd2b69027fa1c4d626f2f6482d28056fdc7b6999bf479544f59b3bf8ccb1f1520589f76119103278af415789e17b1 is hashed to 82feb5cebaa109fe7763eb312ecfca468005638eb909bf2ed7050c69c6f9625d by both the JavaScript and Python libraries but to fa88ac85b8e59ea58312e02ca657aa6d49787be23e7603860cc40f54164a1ad4 by your checker 17:31:19 For other pairs chosen at random the checksums match 17:31:30 so spend key 279d2ada9e7c509981294e0226d245a0a2dbd2b69027fa1c4d626f2f6482d280 view 56fdc7b6999bf479544f59b3bf8ccb1f1520589f76119103278af415789e17b1 ? 17:31:39 yes 17:35:16 sadly 82feb5ce is correct in my implementation 17:36:04 that gives 438BFq9hJfHSgBogkksBMvTsNaY9czwv95jZvQdTH7EhNU4JUvtGcEoMJ3hZc5zQoU6CYHdXwJZwE1XbvyfLvECEM2aHs3b 17:36:05 Then you will also generate an address which will be invalid in some wallet (Feather and Cake for example) 17:36:18 14. Checksum: 82feb5ce Does #14 equal #11? Yes! This is a valid Standard XMR address. 17:36:25 it works for me on https://xmr.llcoins.net/addresstests.html 17:36:30 You cannot send XMR to that address using Cake Wallet for example 17:37:31 https://irc.gammaspectra.live/e78d7c8d490cd814/image.png 17:38:40 mine uses golang's sha3 Keccak256 17:38:41 Then I need to triple check the base58 encoding, it might be wrong and flip some bits 17:39:01 " this is silly. first proof.txt cannot have newlines or spaces" << yeah, lol. get_tx_proof even creates a file that doesnt end in a newline 17:39:05 remember it's as-is 17:39:14 don't read the checksum to uint32 :D 17:39:30 > to fa88ac85b8e59ea58312e02ca657aa6d49787be23e7603860cc40f54164a1ad4 by your checker 17:41:38 Comparing with your address, it seems the base58 padding is incorrect in the one I generated, so this is probably the root cause, intrducing bit flips I did not spot 17:41:56 Thanks for taking the time to check, I'm going back to the drawing board.... 17:47:09 past me helps again by overimplementing things :) 17:53:44 I can also try to decode them, if you have the address :) 18:04:44 Ok the issue was in the base58 padding which incorrectly padded the block at the wrong end! 19:28:16 upgraded from v0.18.3.3 to 18.4.2, has daemon connection code been changed in any way? getting a lot of "no connection to daemon" errors when trying to build txs (daemon is connected and synced) 19:36:38 also getting a very strange error: 19:36:45 https://matrix.monero.social/_matrix/media/v1/download/monero.social/saORkkPNLmzRrTrGoeflwSxf 19:41:57 Maybe node issue? 19:47:17 IIRC, `--rpc-max-connections` was added in 0.18.4.0 https://github.com/monero-project/monero/releases/tag/v0.18.4.0 19:54:57 DataHoarder here is a patch, so now you can use `check_tx_proof
proof=` and it also strips whitespace when loaded from file https://paste.debian.net/1397565/ 19:55:19 Yeah it's more for end users :D 19:55:21 can also make a PR 19:55:27 that'd be nice 19:56:09 I mean why not check if the proof starts with InProof/OutProof instead of proof=? 19:57:01 check_spend_proof and check_reserve_proof are different commands and those make sense having the file alternative 19:57:08 (the proofs are huge) 19:57:18 the file could be named InProof.txt or something 19:57:32 InProofV2 yeah etc. 19:57:40 try decoding, if that fails, decode file? 19:58:09 file could be named proof=.txt :) 19:58:39 Thats on node (ans wallet-rpc) side though. Updating wallet_api shouldn't have changed anything 19:58:41 good point :D 19:59:03 r4v3r23: does it work after retrying a couple times? 22:49:32 Hi all. I'm bdLinick. I'm a security engineer who's passionate about Monero 22:49:33 and just want to start contributing more. Just opened my first PR (fuzz tests 22:49:33 docs): https://github.com/monero-project/monero/pull/10093