05:38:53 <Guest93> Hi
18:49:17 <DataHoarder> can't compile release-v0.18 on latest fedora 43, command_line.h:187:8: error: definition with same mangled name '_ZN12command_line7add_argIbLb0ELb0ELi1EEEvRN5boost15program_options19options_descriptionERKNS_14arg_descriptorIT_XT0_EXT1_EXT2_EEEb' as another definition
18:52:08 <DataHoarder> (somehow seraphis fork does work?)
18:54:44 <m-relay_> <o​frnxmr:xmr.mx> Fcmp fork is of master
18:57:11 <DataHoarder> yeah, but this is old code (last touched 2018)
18:57:26 <m-relay_> <v​tnerd:monero.social> I got this with clang-21 the other day. The fix isn't too bad, I'll issue a pr
18:57:40 <DataHoarder> untouched in fcmp
18:58:11 <DataHoarder> got a patch meanwhile for it?
18:59:14 <m-relay_> <v​tnerd:monero.social> Yeah just remove the `template<>` line and make the third parameter optional by defaulting to false
18:59:28 <m-relay_> <v​tnerd:monero.social> Hold on
19:00:09 <m-relay_> <v​tnerd:monero.social> Or make it true sorry
19:01:08 <m-relay_> <v​tnerd:monero.social> ```
19:01:13 <m-relay_> <v​tnerd:monero.social> ```
19:01:14 <m-relay_> <v​tnerd:monero.social> diff --git a/src/common/command_line.h b/src/common/command_line.h
19:01:16 <m-relay_> <v​tnerd:monero.social> index 681eb903b..a8a718012 100644
19:01:18 <m-relay_> <v​tnerd:monero.social> --- a/src/common/command_line.h
19:01:20 <m-relay_> <v​tnerd:monero.social> +++ b/src/common/command_line.h
19:01:22 <m-relay_> <v​tnerd:monero.social> @@ -207,8 +207,7 @@ namespace command_line
19:01:24 <m-relay_> <v​tnerd:monero.social>      description.add_options()(arg.name, make_semantic(arg, def), arg.description);
19:01:26 <m-relay_> <v​tnerd:monero.social>    }
19:01:28 <m-relay_> <v​tnerd:monero.social>  
19:01:30 <m-relay_> <v​tnerd:monero.social> -  template<>
19:01:32 <m-relay_> <v​tnerd:monero.social> -  inline void add_arg(boost::program_options::options_description& description, const arg_descriptor<bool, false>& arg, bool unique)
19:02:34 <m-relay_> <d​atahoarder:monero.social> ^ 
19:02:36 <m-relay_> <d​atahoarder:monero.social> ```
19:02:38 <m-relay_> <d​atahoarder:monero.social> monero/src/common/command_line.h:211:126: error: redefinition of default argument
19:02:40 <m-relay_> <d​atahoarder:monero.social>   211 |   inline void add_arg(boost::program_options::options_description& description, const arg_descriptor<bool, false>& arg, bool unique = true)
19:02:42 <m-relay_> <d​atahoarder:monero.social>       |                                                                                                                              ^        ~~~~
19:02:44 <m-relay_> <d​atahoarder:monero.social> monero/src/common/command_line.h:187:140: note: previous definition is here
19:02:46 <m-relay_> <d​atahoarder:monero.social>   187 |   void add_arg(boost::program_options::options_description& description, const arg_descriptor<T, required, dependent, NUM_DEPS>& arg, bool unique = true)
19:02:48 <m-relay_> <d​atahoarder:monero.social> ```
19:03:06 <m-relay_> <v​tnerd:monero.social> lol so much for an easy fix. what compiler is this?
19:03:56 <m-relay_> <d​atahoarder:monero.social> clang 21.1.8
19:05:19 <m-relay_> <v​tnerd:monero.social> let me double check what I did previously, this was from memory
19:15:16 <m-relay_> <v​tnerd:monero.social> I dont know, this works with clang 21.1.8 on gentoo
19:23:07 <m-relay_> <v​tnerd:monero.social> was the `template<>` removed? I get that error if that line is not removed
20:43:21 <m-relay_> <d​atahoarder:monero.social> right, I didn't remove it