15:01:36 <selsta> .merge+ 10318 10319
15:01:36 <xmr-pr> Added
17:32:58 <selsta> any opinion on PRs like this? https://github.com/monero-project/monero/pull/10326 clearly AI generated but would add test cases
17:33:20 <selsta> seems to be quite low level tests of things that are unlikely to break
17:47:37 <sech1> Okay, I approved another PR because it was a single line change. But this... They need to pay us to review this...
17:51:25 <sech1> As for tests: don't accept new test just for the sake of tests. New tests should be added together with an entirely new code, or together with bugfixes - i.e. a test that makes the old code fail + the code fix
17:54:32 <sech1> and yes, it's a PR from the same "team": https://gittensor.io/miners/repository?name=monero-project%2Fmonero (click on "Pull Requests" tab)
17:56:49 <selsta> ok i will close it, also it did not even disclose the fact it's AI
18:28:57 <m-relay> <r​brunner7:monero.social> Cool, that 'combinations_count' method really needs some tests. With priority :)
18:29:46 <m-relay> <r​brunner7:monero.social> That "gittensor" thing at a quick glance looks like some sort of contest?
18:30:21 <m-relay> <r​brunner7:monero.social> "Who can get the most PRs merged into the highest-ranking projects"
22:22:21 <tobtoht> .merges
22:22:21 -xmr-pr- 10299 10312 10314 10315 10316 10317 10318 10319
22:22:31 <tobtoht> done
22:31:16 <selsta> thanks! is there anything missing for https://github.com/monero-project/monero/issues/10308 ?
22:31:36 <selsta> otherwise I'll ask for a tag in the next days