11:08:15 does monero require contributers to sign their commits? 11:12:06 No 11:15:31 why 11:16:34 Why would it 11:17:16 We merge code from anyone, not just paranoid ppl 11:24:18 and nobody is allowed to push directly to the repo. Gpg signing is a nice to have, but really only makes a difference for repos that have people commiting directly to them 11:25:00 it's not hard to make a key. No harder or crazier than washing hands before meals. 11:25:00 Can you guys offer suggestions/feedback on PRs to feather or cake? 11:25:16 only core do push, right? 11:25:45 and they sign their commits? 11:48:04 They dont 11:48:17 [#monero-community-dev:monero.social](https://matrix.to/#/%23monero-community-dev:monero.social) 11:48:34 bruh, they should 11:48:46 they dont push to the repo* 11:48:58 oh ok. 11:49:04 They go thru prs as well 11:50:54 You could say that its preferred that people sign their commits, but _nobody_ is checking, and we dont even require you to use git. You can send code via a pastebin 11:50:56 I actually checked pushes https://github.com/monero-project/monero/commits/master/ known developers sign their commits, except some other community contributors 11:51:23 https://matrix.monero.social/_matrix/media/v1/download/matrix.org/uhlluuoGlmnWthnxpIxNZZKq 11:51:28 Navid and vtnerd are known devs 11:51:41 shows "Verified" if they sign commits 11:52:01 https://matrix.monero.social/_matrix/media/v1/download/xmr.mx/VQyqcDgXIAvwaRusIustdGNO 11:52:16 would be good if they sign their commits then 11:52:31 click on 3 dots 11:52:33 Yeah, some sign (tob), some sign sometomes (jeffro), some dont sign ( a bunch more) 11:53:01 ? Its not signed 11:53:23 yeah, indeed, weird as his latest commits are signed 11:53:38 i'm sure impersonating someone is fairly rare, and in serious cases, might be punishable 11:53:39 https://matrix.monero.social/_matrix/media/v1/download/xmr.mx/juANMhWaQmEXMdQEkdcRKvsv 11:53:41 actually majority of his commits 11:53:54 in any case the devs all sign a deterministic guix build at least for feather 11:54:05 Nobody cares - the prs are reviewed 11:54:22 ya its just a formality or extra security measure for nerds ig 11:54:31 We sign deterministic gitian builds for monero 11:54:40 can you move this conversation to another channel 11:54:43 not rare, and you can't punish if you are not enforcing commit signing 11:55:07 #monero 11:56:52 anyway my request not tonight another time, but i have a tricky PR in the works for feather/cake that's almost a hybrid between offline and continuous sync 11:57:32 which after i started working on it, started feeling so wrong, like paddling up river. But it's a convenience factor, too 11:57:52 [#monero-community-dev:monero.social](https://matrix.to/#/%23monero-community-dev:monero.social) [@ggdev:mdev.nutra.tk](https://matrix.to/#/@ggdev:mdev.nutra.tk) 16:22:23 why is every stagenet xmr faucets down bru 16:22:34 even the stagenet explorer is down 16:45:50 @plowsof - Hey, just wanted to ping you here since I saw you're in this group. I posted my completed RoboSats-XMR fork on the bounty page a few hours ago (2.009 XMR bounty). 12/12 tests passing, code's on GitHub, everything's done except I need a tiny bit of stagenet XMR to finish end-to-end testing. Could you take a look when you have a moment? Thanks! 16:46:39 plowsof - Hey, just wanted to ping you here since I saw you're in this group. I posted my completed RoboSats-XMR fork on the bounty page a few hours ago (2.009 XMR bounty). 12/12 tests passing, code's on GitHub, everything's done except I need a tiny bit of stagenet XMR to finish end-to-end testing. Could you take a look when you have a moment? Thanks! 17:45:22 sweetkanoe: Please drop your stagenet address here, I will send something 18:06:46 57AMFjwXiSS39p4WU7zFNKZ3RKopHjnta1sTP75FhHK5GrJ2uGu3LELSEF3F6LirwNXyuQxuw6uGABQH9No1UsurE6136ko 18:06:46 thanks :) 18:09:47 926830119ed33ddc2d00c3a11d0759beae5895ad09fc5cb8050a6b285b30ffdf 18:14:53 Monero Bounties 18:20:50 idk why but i havent received it like fr, i also tried a faucet but it also showed sent but i didnt recieve that either 18:21:20 7 confirmations, idk 18:21:40 some sync issue 18:22:10 ah prob yeah, i will wait i guess 18:22:29 Are you connected to a node..? 18:22:30 what's your stagenet height? it's in block 2067633, you should have it... 18:23:49 yep that was the error 18:24:03 no daemon connected 18:24:09 am dumb 18:32:01 I mined you some coinbases that will have a locktime 60, hope your code handles edge cases >:D 18:33:30 lol 18:34:25 sweetkanoe: How did you test it on stagenet/testnet before submitting to the bounty? 18:35:03 Since you didn't have stagenet coins 18:36:02 i tested it on stagenet by running monero-wallet-rpc in stagenet mode and connecting to public nodes. faucets were all down so i asked around in the monero matrix rooms and someone sent me a bit of stagenet xmr to work with. the robosats fork uses that rpc for everything — generating subaddresses, handling 10-block locks, checking balances, sending between wallets. all 12 tests 18:36:02 pass. just waiting for the wallet to sync so i can finally run an actual trade from end to end. 18:36:06 am sure i got enough time before he tests the code 18:37:28 Were way off topic 18:37:41 Nove to bounties room plz, or Monero Community Dev 18:38:34 sorry for that, again. 18:47:53 got the xmr, thanks dude u saved me big time 18:48:26 np bruv frfrf