00:30:11 <m-relay> <v​tnerd:monero.social> Am I supposed to respond on GH or codeberg? It's going to be funky if you can't respond directly on GH
00:31:03 <m-relay> <j​pk68:matrix.org> Yeah, sorry about that. Whatever works for you
00:31:14 <m-relay> <j​pk68:matrix.org> GH is fine, or just Matrix
00:33:34 <m-relay> <j​pk68:matrix.org> Unless you happen to have a Codeberg account already or something
00:37:19 <m-relay> <o​frnxmr:xmr.mx> Id say to put review comments directly on github
01:08:32 <m-relay> <j​pk68:matrix.org> Thanks, made some fixes. I think the mirror will have to be manually updated
01:08:48 <m-relay> <j​pk68:matrix.org> cc ofrnxmr
01:23:15 <m-relay> <j​pk68:matrix.org> I ended up adding a runtime check (before the second review comment), but I can still change it if you'd like
11:55:05 <tobtoht> given that there is no support to remove miniupnpc outright (#10012) and a replacement won't be ready soon, I would like to request review of #9273, which updates it and moves it to depends.
11:56:24 <m-relay> <o​frnxmr:xmr.mx> I find it utterly useless. Does _anyone_ even have success with it?
11:57:13 <m-relay> <o​frnxmr:xmr.mx> Its quite literally worked for ne zero times across probably 10 routers. Manual port forwarding always required
12:02:12 <tobtoht> I would still prefer to just remove it. If it doesn't work (reliably), it's just a maintenance burden and vulnerability liability for nothing.
12:04:00 <m-relay> <o​frnxmr:xmr.mx> I vote to remove it.. useless garbage
12:04:04 <m-relay> <o​frnxmr:xmr.mx> Imo
12:04:31 <tobtoht> ok, I will update 10012
12:25:38 <selsta> .merge+ 10449
12:25:38 <xmr-pr> Added
12:34:57 <selsta> .merge+ 10461
12:34:57 <xmr-pr> Added
15:48:20 <selsta> is anyone here against removing upnp support?
15:56:31 <m-relay> <s​yntheticbird:monero.social> no one has ever been for upnp in the first place
15:56:45 <m-relay> <s​yntheticbird:monero.social> i beg you
15:56:49 <m-relay> <s​yntheticbird:monero.social> get rid of it
16:16:05 <m-relay> <i​xr3:matrix.org> Yes remove
16:52:28 <m-relay> <r​avfx:xmr.mx> Nuke it!
17:05:09 <selsta> .merge+ 10454 10455 10459
17:05:09 <xmr-pr> Added
20:31:25 <m-relay> <i​xr3:matrix.org> @selsta  the v0.18.5.0 release to-do list looks great
20:48:51 <selsta> hope we can get it out next week