00:42:38 selsta: I might be missing something, but is there a reason I should include if it compiles without it? 00:42:46 (responding to your review comment) 00:44:43 If you use it and it's not included in the .cpp or .h I'd include it 00:45:22 It's useful for compatibility purposes. Omitting it is relying on particular libraries to indirectly include the feature 00:45:44 in the past we had builds failing suddenly because some compiler suddenly got more strict 00:47:04 Thanks, good to know 00:52:32 jpk68: there are open PRs regarding man pages, just pointing it out so that you don't duplicate work 00:52:57 I know, mine is for monero-wallet-cli specifically, not the daemon, as the others are for 00:53:16 Thanks for the heads-up, though :) 00:55:57 Not counting the one PR that had them converted with Pandoc, I mean 01:19:32 Alright, I pushed fixes and added a test case for incorrect version byte. The mirror might take a bit to get updated but that's fine 01:20:53 Somehow also just realized that every (valid) onion address ends with "d" :P 17:58:19 selsta: Would you mind uploading a pastebin of the build error for 10612? 17:58:30 It works on my machine 17:59:02 it can't find the boost header 17:59:05 https://mrelay.p2pool.observer/p/n9fB24MLY3BuM1c3/1.txt (code snippet, 4 lines) 18:00:15 Have you benched the improvement? Is it even worth the micro optinmiization? 18:01:06 No, but what would be the harm in changing it? It would clearly be much slower if you included the entirety of Asio everywhere 18:02:45 its not clear if it doesnt build and hasnt been compared 18:06:28 Well, that's strange... if you look on my fork, it's a different header 18:06:50 https://github.com/monero-project/monero/pull/10612/files 18:06:50 https://codeberg.org/jpk68/monero/pulls/15/files 18:08:30 Maybe sent sneed a different patch? 18:09:18 Youre right that the prs dont match. 18:09:23 Pretty sure I didn't, I just gave him the link to my fork 18:09:44 Anyways, I pushed a fix for the other one and both should be updated soon 18:48:38 yeah sorry, that was my fault 18:49:54 You're fired 18:50:40 what i do.. is i just add jpks remote, then checkout the branch, then push it as-is to my repo 18:50:46 To my remote* 18:54:56 Don't worry about it 18:55:05 I just wanted to let people know what was going on 19:20:08

Jpk, i had rights to the merkle roots verification scheme before this group. How can we resolve this? 19:20:39

It seems this is an underlying schema to the functionality of the coin cryptographic protocall 19:22:23 Apologies if this is rude, but I have no idea what you're talking about, I am not the right person to answer this question, it sounds like you're trolling, and this is the wrong channel anyways 19:23:12

Ok maybe u are the wrong individual to inquire. Who made the game? Do u know or are aware? 19:23:54 #monero-community:monero.social 19:24:56

Eh 19:25:19 Please move this convo to the channel I linked above. This is the wrong channel ;) 19:25:22

What do u think of the situation? 19:25:28 Wrong channel 19:25:30

Ok 19:25:42

K 19:58:22 selsta: What do you mean by your comment? 19:58:49 Nothing seems off on my end 19:59:26 sneedle fixed it after my comment 20:00:47 sorry for the inconvenience, today's not my day, to my excuse I need to sleep 20:02:38 DW, not a big problem 20:02:44 Alright, looks like all three are good to go now 20:36:42 vtnerd: WIN32 is apparently defined in , or by MinGW. In any case, I'm fairly certain it's not by us 20:36:45 https://stackoverflow.com/a/74084728 20:40:00 Then why the switch to _WIN32 ? 20:40:47 Because it can be defined falsely (by the user or otherwise), and requires headers 20:40:55 This is explained in the post I linked to above 20:41:43 On the other hand, _WIN32 is strictly compiler-defined and can't be messed with