18:01:21 <selsta> .merge+ 10607
18:01:21 <xmr-pr> Added
18:36:06 <br-m> <jpk68:matrix.org> vtnerd: I made some tweaks to 10554 to address review comments. I think it would be better to keep a forward decl of from_onion_v3_const in the header, to avoid rearranging half of the code in the source files
18:38:09 <br-m> <ofrnxmr> Did u address the whitespace tho 🥴
18:38:19 <br-m> <jpk68:matrix.org> Yes ;)
18:39:21 <br-m> <ofrnxmr> Not pushed yet?
18:39:24 <br-m> <jpk68:matrix.org> I guess I'll have to submit another one removing it after... more commits for me :P
18:40:53 <br-m> <jpk68:matrix.org> Why are there random line breaks in the middle of copyright comments in the first place?
18:41:37 <br-m> <ofrnxmr:xmr.mx> Who knows, who cares :)
18:42:04 <br-m> <ofrnxmr:xmr.mx> Check the git blame and get mad at someone for fudging it 11 years ago
18:42:53 <br-m> <vtnerd> @jpk68: why does the entire function need to be in the header? Why not forward declare and drop constexpr - its not constexpr is being used anywhere
18:43:07 <br-m> <jpk68:matrix.org> I removed it in the header, yes
18:43:13 <br-m> <jpk68:matrix.org> Sneedle just has to update the mirror
18:44:17 <br-m> <jpk68:matrix.org> It was just originally there because it came from P2Pool
18:45:41 <br-m> <syntheticbird> @ofrnxmr:xmr.mx: cut the blame and just get mad
18:45:51 <br-m> <syntheticbird> 👍️
18:54:34 <sech1> It doesn't have to be constexpr in Monero's code because it's not used to initialize any constexpr values
18:54:46 <sech1> and it doesn't have to be in the header in this case
19:12:35 <br-m> <sneedlewoods_xmr:matrix.org> is this fine to push? https://codeberg.org/jpk68/monero/pulls/13/files
19:12:35 <br-m> <sneedlewoods_xmr:matrix.org> or should constexpr get removed first from from_onion_v3_const()
19:25:31 <br-m> <ofrnxmr:xmr.mx> I'd waif for the update
19:25:53 <br-m> <ofrnxmr:xmr.mx> No need to run an extra 1.5hrs of ci and store an extra 150mb of binaries
19:50:06 <br-m> <jpk68:matrix.org> vtnerd: Do you have an opinion on the above?
19:53:41 <br-m> <ofrnxmr:xmr.mx> @vtnerd: Didnt both of them say to drop it
19:54:21 <br-m> <jpk68:matrix.org> Sorry, I must have misread that
19:54:34 <br-m> <jpk68:matrix.org> My bad
19:57:14 <tobtoht> .merges
19:57:14 <xmr-pr> 9473 10084 10512 10531 10533 10543
20:04:19 <br-m> <jpk68:matrix.org> Done.
21:48:35 <selsta> .merge+ 10609 10610
21:48:35 <xmr-pr> Added