05:38:07 <br-m> <r4v3r23> yes, authorship got mangled somehow, polyseed is under also czarek for some reason > <@tobtoht> that's my code lol
05:39:36 <br-m> <ofrnxmr:xmr.mx> should be an easy fix. just need to drop the commit and re-commit it as authored by tob
05:40:51 <br-m> <r4v3r23> @tobtoht: so its a straight wallet2 implementation? is that something that could be PR'd? if were all using it, it probably makes sense to just add it to codebase
05:41:16 <br-m> <r4v3r23> @ofrnxmr:xmr.mx: yeah lemme see if i can just overwrite it
05:45:45 <br-m> <ofrnxmr:xmr.mx> git rebase -i HEAD~5
05:45:45 <br-m> <ofrnxmr:xmr.mx> change "pick" to "edit" next to the commits that need to be changed[... more lines follow, see https://mrelay.p2pool.observer/e/1Iy_mo0LWUxBZ2wy ]
06:12:41 <br-m> <r4v3r23> yeah i did it
06:13:32 <br-m> <r4v3r23> email showed up as tob⊙fo so just used that
06:51:24 <br-m> <ofrnxmr:xmr.mx> Yeah i might have written that down wrong
06:51:46 <br-m> <ofrnxmr:xmr.mx> Yep, its tob
12:11:20 <selsta> https://github.com/monero-project/monero/issues/10545 would need reviews
12:12:46 <selsta> .merge+ 10749 10750 10751
12:12:46 <xmr-pr> Added
14:44:43 <tobtoht> .merges
14:44:43 <xmr-pr> 10742 10743 10749 10750 10751
14:44:49 <tobtoht> done
14:52:44 <br-m> <r4v3r23> tobtoht could your coin control changes be used as the basis for a PR?
14:58:09 <br-m> <r4v3r23> selsta  also, since the airgapped signing feature has now been more or less standardized, can we something like this added to monero? https://github.com/feather-wallet/monero/commit/9a29723f33abb6dcc2bdd22bce5b8350ed235bac.patch
14:58:53 <selsta> if someone PRs it yes, but I don't have time for these features at the moment
14:59:14 <br-m> <r4v3r23> selsta: sure, im thinking for v0.19
16:48:49 <br-m> <jpk68:matrix.org> Is anyone opposed to 7201? It looks fine to me
17:10:33 <br-m> <rbrunner7> 7201? You maybe missing a digit here?
17:11:11 <br-m> <jpk68:matrix.org> Nope :)
17:11:30 <br-m> <jpk68:matrix.org> simplewallet: Unify the formatting of help texts
17:12:01 <br-m> <tobtoht> Well, it would need to be rebased first.
17:12:21 <br-m> <jpk68:matrix.org> True, but asides from being out of date, I mean
17:13:31 <br-m> <rbrunner7> I think we don't usually do such more or less pure refactorings. We don't even correct the dumbest indentations ...
17:14:16 <br-m> <rbrunner7> I if being the Monero CEO would order to do that differently, but well ...
17:14:19 <br-m> <tobtoht> There are mixed tabs and spaces in critical wallet2 tx construction code that I stumble over every time... T.T
17:19:05 <br-m> <tobtoht> @jpk68:matrix.org: LGTM at a glance.
17:19:51 <br-m> <jpk68:matrix.org> The rule for "no refactors" might not apply here since it's user-facing, but what do I know
17:21:17 <br-m> <tobtoht> The bar should be exponentially higher the closer it gets to consensus, yes.
17:21:34 <br-m> <rbrunner7> Whoever wants to rebase that would probably have to check very carefully whether some texts were reformulated in the meantime. Or can we fully rely on git to produce a merge conflict when that happened?
17:21:40 <br-m> <rbrunner7> *if that happened
17:22:07 <br-m> <ofrnxmr:xmr.mx> should be a merge conflict
17:22:18 <br-m> <tobtoht> Might be easier to "re-do" than rebase.
17:22:25 <br-m> <rbrunner7> Right
17:22:41 <br-m> <jpk68:matrix.org> Yeah, that's what I was thinking
19:17:46 <br-m> <jeffro256> @tobtoht:monero.social: that and process_new_transaction() are pretty horrible to look at > <@tobtoht> There are mixed tabs and spaces in critical wallet2 tx construction code that I stumble over every time... T.T
19:37:46 <br-m> <jpk68:matrix.org> @jeffro256: Oh my god, that's insane. Just looked at it now for the first time :((
19:38:18 <br-m> <jpk68:matrix.org> How does one even understand what's going on there
19:41:44 <br-m> <tobtoht> I think I PR'd a fix for this once (#7001a moo told me
19:50:30 <br-m> <tobtoht> Let's strive to make life a little easier for our co-devs going forward shall we?