14:26:45 <br-m> <sneedlewoods_xmr:matrix.org> For #10787 (https://github.com/monero-project/monero/pull/10787/changes) the file contrib/epee/include/net/helper.h has mixed tabs and spaces. The majority are tabs (but some tabs are messed up, e.g. see here (https://github.com/monero-project/monero/blob/abe4eb60ea62f357bd71efc9037dbbc021cd6271/contrib/epee/include/net/net_ [... too long, see https://mrelay.p2pool.observer/e/ovfl-40LRVdYOUg1 ]
14:26:45 <br-m> <sneedlewoods_xmr:matrix.org> https://github.com/monero-project/monero/blob/abe4eb60ea62f357bd71efc9037dbbc021cd6271/contrib/epee/include/net/net_helper.h#L374-L381
14:26:45 <br-m> <sneedlewoods_xmr:matrix.org> jpk68s PR initially used spaces and is now updated to use tabs. I'd like to hear other opinions if you prefer tabs or spaces in this case.
14:28:49 <br-m> <ofrnxmr:xmr.mx> Depends on the goal. Consistency, sanity, mass refactoring?
14:28:49 <br-m> <ofrnxmr:xmr.mx> We also have files with the wrong line endings, but im against touching things for the sake of touching things
14:30:43 <moneromooo> Tabs are control characters. Canonical behaviour is "go to next multiple of X" (typically 8). Using tabs will pretty much always end up fucking something up somewhere. But since I'm not hacking on monero anymore...
14:34:53 <br-m> <sneedlewoods_xmr:matrix.org> I prefer spaces in this case, because the file is already inconsistent. I would stay with tabs if the entire file would use tabs, even though I generally prefer spaces. But that's just my opinion.
14:36:16 <moneromooo> For patches, I'd change only lines I already change (and possibly immediate context if it feels best). Whitespace change spam is annoying and increases conflicts when patching, merging, rebasing...
14:38:20 <moneromooo> I hesitate to say common sense because it's more preference, but I'd rank in order of preference: do not change, use whatever the surrounding code uses, use whatever the file/project typically uses, use spaces, use tabs.
14:39:08 <br-m> <jpk68:matrix.org> @sneedlewoods_xmr:matrix.org: Same
15:00:04 <br-m> <ofrnxmr:xmr.mx> The whole file is already using tabs?
15:02:13 <br-m> <jpk68:matrix.org> Most of it
15:02:43 <br-m> <jpk68:matrix.org> We should just replace all tabs with spaces using clang-format or something
15:03:49 <br-m> <ofrnxmr:xmr.mx> Or not
18:18:19 <selsta> .merge+ 10700
18:18:19 <xmr-pr> Added
18:50:20 <UkoeHB> If majority are tabs, the file was likely originally tabs and some patches added spaces. Probably 'better' to use tabs, so tab/space formatting doesn't get even worse.
19:36:27 <br-m> <sneedlewoods_xmr:matrix.org> I checked git blame and it seems from 2014-2018 there were some patches which introduced spaces (some even used mixed tabs + spaces in a single patch), but since then only tabs were added, e.g. in the latest patch by vtnerd.
19:36:27 <br-m> <sneedlewoods_xmr:matrix.org> Now I also tend to lean towards changing to tabs, but still not a strong opinion, so I'd leave it with spaces for now, because there were also people preferring it that way.
19:36:27 <br-m> <sneedlewoods_xmr:matrix.org> Not sure if we need to do a vote for this.
19:43:14 <br-m> <jpk68:matrix.org> It is worth noting that no whitespace was changed on lines that weren't edited anyways
19:43:25 <br-m> <rbrunner7> My last take from the epic "tabs versus spaces" wars that rage between different factions of devs was "the spaces are winning"
19:43:31 <br-m> <jpk68:matrix.org> That being said, I agree that most people are in favour of keeping tabs, and that's fine with me
19:44:14 <br-m> <rbrunner7> (Overall, over all languages, devs, editors etc.)
19:53:04 <br-m> <jpk68:matrix.org> Looks like the PR can be updated again? If anyone wants to keep the spaces, then just give a thumbs-down maybe