15:08:11 <selsta> .merge+ 10796 10797
15:08:11 <xmr-pr> Added
15:45:15 <br-m> <milas900:matrix.org> Probably use AI to remove > <@thomasbuilds:matrix.org> My goal with this PR is to remove all the dead code in the monero repo, what you think? https://github.com/monero-project/monero/pull/10809 ?
16:09:28 <tobtoht> .merges
16:09:28 <xmr-pr> 10597 10598 10790 10796 10797
16:11:17 <selsta> .merge+ 10824
16:11:17 <xmr-pr> Added
16:54:20 <br-m> <thomasbuilds:matrix.org> @milas900:matrix.org: yes after seeing that contributors kept finding typos after my codespell cleanups I figured it would be better to use AI to tackle this fully, I set up subagents to read entire codebase in search of spelling issues and well many findings but idk if monero should address this tbh
16:54:20 <br-m> <thomasbuilds:matrix.org> https://github.com/thomasbuilds/monero/commit/e8f996851b6a1628bcad38ca900224707e14e86a
16:56:17 <br-m> <ofrnxmr:xmr.mx> the ones that are just comments.. i say yolo the changes in
16:57:00 <br-m> <ofrnxmr:xmr.mx> there are 2 schools of thought: 1) dont touch code / only touch comments. 2) fix everything at once
16:57:26 <br-m> <ofrnxmr:xmr.mx> i think either way it would be a good idea to add something like codespell to check the diffs on ci runs
16:58:30 <selsta> i'm against renaming variables, even if done at once
16:59:33 <br-m> <thomasbuilds:matrix.org> selsta: yes though do we care about fixing typos in comments/string literals if there are still typos in variable, function names?
16:59:57 <br-m> <thomasbuilds:matrix.org> like it seems to me the job can't be fully completed
17:01:37 <br-m> <ofrnxmr:xmr.mx> in general, i dont think we care about fixing old spelling errors. oonly reasons to fix them, are to avoid spelling-error fix prs, or if already touching the related code
17:03:05 <br-m> <jpk68:matrix.org> Aside from function names, I am personally in favour of fixing typos/grammar issues (which is probably not hard to tell from my past PRs)
17:03:36 <selsta> thomasbuilds: anything that is end user facing needs to be fixed, comments can be fixed, anything else i'm against
17:04:45 <br-m> <jpk68:matrix.org> @ofrnxmr:xmr.mx: There would be no good reason to keep things the way they were here, for example:
17:04:45 <br-m> <jpk68:matrix.org> https://github.com/monero-project/monero/pull/10447/files
17:04:57 <br-m> <thomasbuilds:matrix.org> selsta: I'd assume you include string literals too?
17:07:35 <selsta> if they show up for the end user somewhere yes
19:16:43 <br-m> <jpk68:matrix.org> https://github.com/monero-project/monero/pull/10828/files#diff-1791ca6db56ff6236c17c6b8c2d6bc1516adbf806345d2e0ffc3b3a1b60e8287R1461
19:17:00 <br-m> <jpk68:matrix.org> No way, AI knows the number of "R"s in "raspberry" :D
19:19:55 <br-m> <jpk68:matrix.org> For the last one in device_ledger.cpp, I think I tried to fix that in an earlier PR, but didn't get a response when I asked if it was supposed to be "use" or "unset"
19:20:27 <br-m> <jpk68:matrix.org> Looking at the context, it probably is "use" but I could be wrong
19:21:02 <br-m> <ofrnxmr:xmr.mx> It probably just ran codespell
19:21:37 <br-m> <jpk68:matrix.org> He said he used AI since codespell left out a bunch last time
19:22:40 <br-m> <thomasbuilds:matrix.org> haha lmao > <@jpk68:matrix.org> No way, AI knows the number of "R"s in "raspberry" :D
22:20:49 <selsta> .merge+ 10646 10774
22:20:49 <xmr-pr> Added