05:15:35 <xmr-pr> JossieEtheridge opened pull request #10990: Fix long-standing 'Next span is not empty' sync stall (#8194)
05:15:36 <xmr-pr> > https://github.com/monero-project/monero/pull/10990
05:25:17 <br-m> <thomasbuilds:matrix.org> omg this PR wtf
05:43:37 <br-m> <ofrnxmr> I also think they hit that bug because they ser block-sync-size-100
05:43:37 <br-m> <ofrnxmr> "Measured real, successful 100-block span completions on this node taking
05:43:37 <br-m> <ofrnxmr> 2-26 seconds each. With a 2-second threshold, any peer that goes briefly
05:43:37 <br-m> <ofrnxmr> quiet — completely normal under real network conditions — gets its[... more lines follow, see https://mrelay.p2pool.observer/e/uKH9hZsLSHVET0Nx ]
05:44:13 <br-m> <ofrnxmr> block-sync-size=100*
06:30:50 <br-m> <thomasbuilds:matrix.org> his LLM is so bad he didn't realize he's fixing a closed issue lmao
06:38:51 <br-m> <thomasbuilds:matrix.org> What I don't understand from github is that it included 20 participants in this PR and there are 0 reviews/comments.
06:38:51 <br-m> <thomasbuilds:matrix.org> 20 ppl received notification for this slop PR rip
06:39:57 <br-m> <ofrnxmr:xmr.mx> @thomasbuilds:matrix.org: Fixong like 5 closed issues from v0.12
06:40:34 <br-m> <ofrnxmr:xmr.mx> aNd fixing a self-induced issue
06:40:50 <br-m> <ofrnxmr:xmr.mx> And pushing release code to master
06:41:11 <br-m> <ofrnxmr:xmr.mx> And not checking if fix is already on master
06:41:17 <br-m> <thomasbuilds:matrix.org> lol I mean he joined github in April what can you expect
06:42:05 <br-m> <thomasbuilds:matrix.org> this is his 1st ever contribution
06:43:21 <br-m> <ofrnxmr:xmr.mx> @thomasbuilds:matrix.org: I only see 3
06:43:30 <br-m> <thomasbuilds:matrix.org> now yes because he forced pushed
06:43:57 <br-m> <ofrnxmr:xmr.mx> @thomasbuilds:matrix.org: Why? He's fixinf a non-issue
06:44:17 <br-m> <thomasbuilds:matrix.org> he doesn't get it
06:45:58 <br-m> <ofrnxmr:xmr.mx> botched rebase too
06:46:14 <br-m> <ofrnxmr:xmr.mx> Re-added variables that arent used anymore
06:46:27 <br-m> <ofrnxmr:xmr.mx> One of which causes his runawayspans issue
06:47:19 <br-m> <ofrnxmr:xmr.mx> (*thomas licking his lips at dead code)
06:47:27 <br-m> <thomasbuilds:matrix.org> lmao
06:56:37 <br-m> <jeffro256> May I review beg on https://github.com/monero-project/monero/pull/10934?
07:00:35 <xmr-pr> thomasbuilds opened pull request #10991: cryptonote_core: remove dead code
07:00:36 <xmr-pr> > https://github.com/monero-project/monero/pull/10991
07:44:28 <sech1> 10934 is huge, I would review it but I don't have time today
09:30:35 <xmr-pr> plowsof opened issue #10992: wallet2_api: `doInit()` discards `use_ssl` (onions still attempt TLS h...
09:30:36 <xmr-pr> > https://github.com/monero-project/monero/issues/10992
11:45:35 <xmr-pr> thomasbuilds opened pull request #10993: wallet2_api: skip the TLS handshake on Tor/I2P daemons
11:45:36 <xmr-pr> > https://github.com/monero-project/monero/pull/10993
13:08:09 <br-m> <borderless_dev15:matrix.org> Looking for US junior developers to join our team! Fully remote position with room for professional growth and solid income potential. Interested? Feel free to shoot me a DM or connect with me on Linkedin: https://www.linkedin.com/in/brando-martinez-b23833b7!
13:39:58 <br-m> <rbrunner7> Well, how about solid income instead of merely solid income potential :)
13:41:23 <br-m> <hbs:matrix.org> @rbrunner7: That's a potentiality
14:58:45 <br-m> <jpk68:matrix.org> I got some insane review comments yesterday > <@thomasbuilds:matrix.org> his LLM is so bad he didn't realize he's fixing a closed issue lmao
14:59:18 <br-m> <jpk68:matrix.org> https://github.com/monero-project/monero/pull/10976#pullrequestreview-4792381477
14:59:18 <br-m> <jpk68:matrix.org> https://github.com/monero-project/monero/pull/10984#pullrequestreview-4792381594
15:31:28 <selsta> .merge+ 10951 10952 10950 10949
15:31:28 <xmr-pr> Added
15:53:55 <tobtoht> .merges
15:53:55 <xmr-pr> 10747 10876 10949 10950
19:28:54 <selsta> .merge+ 10459
19:28:54 <xmr-pr> Added
19:48:34 <tobtoht> typo? 10459 is already merged 
19:49:25 <br-m> <jpk68:matrix.org> I think he meant 10458
19:54:13 <selsta> .merge+ 10458
19:54:13 <xmr-pr> Added
20:37:51 <br-m> <jpk68:matrix.org> ^ Has two approvals now, just FYI
21:15:35 <xmr-pr> jpk68 opened pull request #10994: chore: consolidate anonymity networks info
21:15:36 <xmr-pr> > https://github.com/monero-project/monero/pull/10994
22:30:35 <xmr-pr> jeffro256 opened pull request #10995: wallet: upstream misc stuff before FCMP++
22:30:36 <xmr-pr> > https://github.com/monero-project/monero/pull/10995
22:31:17 <br-m> <jeffro256> ^ this PR is a fairly simply review, and gets some churn out of the way before the Carrot/FCMP++ integration reviews 
22:31:33 <br-m> <jeffro256> *fairly simple