07:53:05 Hey all, 07:53:05 Is there a roadmap, milestone tracker, or project board somewhere that shows what's left for FCMP++ launch on mainnet? 07:53:05 While I did read the most recent implementation audit from Trail of Bits, I'm having trouble connecting the dots between what's in progress, what's still needed to launch, and perhaps an ETA (6 months, 1 year? 2 years?)[... more lines follow, see https://mrelay.p2pool.observer/e/4Nm55qILN2I5UEJW ] 08:03:38 https://html-preview.github.io/?url=https://github.com/jeffro256/fcmp-carrot-plan/blob/master/fcmp%2B%2B-carrot.html 08:03:51 tentative but it's on https://github.com/jeffro256/fcmp-carrot-plan :) 08:52:54 DataHoarder: Excellent! Thank you very much! 10:19:53 I am try to address issue 4673 as my first contribution to monero project. https://github.com/monero-project/monero-gui/issues/4673. I would like to know is wallet layout change like this issue still welcomed? 11:29:23 @entropyhoover:matrix.org: there is a GUI channel, it's better to ask there 11:31:27 #monero-gui:monero.social 12:00:50 Ap4sh opened pull request #11167: wallet: encode equals signs in URIs 12:00:51 > https://github.com/monero-project/monero/pull/11167 13:09:26 @probably_wrong:matrix.org: reviews the pull requests you ask him to, it promises to deliver a high quality review but it takes time to reply because good things take time (and also because it's not fully automated rn I still have to read the message and paste the reply). enjoy and don't be in a hurry with him please, he is probably wrong (actually he isn't). 13:10:01 yes you're probably right 13:10:51 @probably_wrong:matrix.org review 11167 13:11:11 Wait, does it post on the repo? 13:11:59 no here only no AI reviews on github 13:12:15 it's better this way imo 13:30:11 @ofrnxmr: # 🤖 probably_wrong — automated review of PR #11167 13:30:11 ### wallet: encode equals signs in URIs 13:30:11 Verdict: ✅ ACK / ship it. Then go stand protectively in front of #10265. (Explained below. It's the whole reason this comment is long.)[... more lines follow, see https://mrelay.p2pool.observer/e/vZGL8KILRldQN0Zi ] 13:30:12 kick this bot 13:30:58 no lol it said good things 13:31:06 what does that bot do 13:31:25 it reviews PRs 13:31:36 i forgot, new bridge doesnt let spam through 13:31:42 oh 13:31:58 @ofrnxmr:xmr.mx: how does it detect spam? 13:32:04 by length 13:32:13 ok what's max length? 13:32:19 not long 13:32:39 rip well it won't be on irc then 13:32:52 https://libera.monerologs.net/monero-dev/20260821#c702589 13:33:34 nice so it worked? 13:35:41 can the bot be tuned to cut the noise 13:35:52 and act professionally 13:36:47 ok I'll do that on next report 13:43:31 @probably_wrong:matrix.org: review 11074 13:44:32 @jpk68:matrix.org: watch out that's for you 13:44:53 with the length of the reviews, i almost feel that it should be posting them to some website as a text file (similar to what the bridge does) 13:45:36 yeah although check for this one it will be much shorter 13:45:51 also this is testing phase 13:50:37 Huh 13:51:00 > <@thomasbuilds:matrix.org> @probably_wrong:matrix.org: review 11074 13:51:00 Dedup looks faithful — checked the extracted helper against both originals: m_anchor (white != anchor → false), just_take_peerlist, pi init, record_addr_failed, and both failure messages all match per caller. bool(con) fix is real: LOG_INFO_CC streams the arg, and a bool prints 0 instead of selecting the [context] overload, so the old line logged a bare 0. 13:51:00 One thing not in the description: check_connection_and_handshake_with_peer's "Connecting to…" log was LOG_PRINT_L1 (MINFO) and now goes through the helper's MDEBUG. Since net.p2p is INFO at --log-level 1 and DEBUG only at 2, that line was visible at -1 and now isn't (also gains peer_type=white). Only caller is gr [... too long, see https://mrelay.p2pool.observer/e/nsXY8KILd2x6OEY5 ] 13:51:00 [... more lines follow, see https://mrelay.p2pool.observer/e/nsXY8KILd2x6OEY5 ] 13:54:39 This is fine 13:55:21 @probably_wrong:matrix.org: review 11069 14:07:49 I meant, like, the review indicates the PR is fine despite the one discrepancy (which I agree with) 14:08:31 @thomasbuilds:matrix.org: Reviewed #11069 (decouple net client users from http_client header). Two remarks, no blockers. 14:08:31 New link coupling worth surfacing: on master t_rpc_client held a concrete http_simple_client (epee-only). Its ctor now calls net::http::client_factory().create(), so constructing a t_rpc_client pulls a net-library symbol into the consumer's link line. common (where rpc_client.h lives) doesn't link net; it resolve [... too long, see https://mrelay.p2pool.observer/e/w9WY8aILS0NmdDh2 ] 14:08:31 On the compile-time claim: measured a trivial TU including only the swapped header — http_client.h 295k preprocessed lines / 2.9s, abstract_http_client.h 191k / 1.1s (best-of-5, -O2). The saving is boost::regex + the http_simple_client_template definition, not asio — both headers still drag full asio+ssl via[... more lines follow, see https://mrelay.p2pool.observer/e/w9WY8aILS0NmdDh2 ] 14:11:20 Having the bot in -dev does not really make sense IMO, either something that can be pinged on GitHub or via DM would be better 14:12:26 all right if you're fine with github i'll create github account for it 14:13:18 also it's Opus right? 14:13:28 yeah opus 5 14:13:36 the verbose output is driving me crazy lol 14:14:58 Yeah, no offense, but the long responses are a bit obnoxious 14:15:22 yeah I just set it up will get better 14:15:31 15:31:36 i forgot, new bridge doesnt let spam through 14:15:31 it does, this was not spam but it cuts out multiline messages after some length 14:15:45 ChatGPT's latest model is to the point, it either concisely points out a bug or it shuts up, but Opus is always rambling 14:15:53 specific spam would be blocked entirely if detected 14:16:25 the review seems to be talking to a toddler. 14:16:29 "So name your recipient Alice=Bob and make_uri will happily hand you a URI that parse_uri then spits back in your face. The wallet does not trust itself. Relatable." 14:16:46 "Congratulations to = on twelve years of successful infiltration." 14:16:58 I liked the joke about function names and UNESCO or whatever 14:17:09 thats what i meant about it being unprofessional 14:17:16 "THE ACTUAL FINDING (read this one)" "Whoever merges second: you have been warned in writing, with a table." 14:17:32 "Somebody hit re-run. The OpenAlias resolver having a moment is not a code review finding." 14:17:33 wtf 14:18:54 thats why my immediate reaction was "kick the bot" 14:19:00 same 14:19:02 the 1st review was supposed to be sarcastic tone 14:19:11 then ofrnAI said pro so I changed 14:20:07 should be explicitly brief and directly flag as otherwise a blogpost is not going to be read 14:20:14 selsta: Opus is not a good model to use 14:20:31 DataHoarder: yes working on it 14:20:38 Likes to make things up 14:21:01 everything out there makes things up as it's trained to convince the reader :) 14:21:58 @slowbeardigger:matrix.org: fable is even worse 14:22:10 also thomasbuilds, most recent things like to use the cheapest agents for per-file reading. No way to limit this but it can be "suggested" to use the full agent for reading/review instead of using haiku subagents 14:22:17 inventing reasons to make you think you need it. like a toxic girlfriend 14:22:52 "Choose the right job for the tool" ;) 14:22:55 the "main" opus agent derives all the info from the haiku subagents and catches nothing, specially cross-component 14:23:24 most of times it doesn't even use subagents 14:23:37 for reading files it does 14:23:49 just not explicitly shown/acted on 14:23:56 Would be great to get some reviews on #11143 and #11063 though :)) 14:24:09 it's also in the end a probabilistic check so maybe running it a few times without knowledge of each other (even files on disk) and then merging the findings 14:25:05 @jpk68:matrix.org: @probably_wrong:matrix.org: review 11143 14:26:27 i have a room called #monero-slop:monero.social that you can probably add the bot to 14:26:31 theres nobody in the room yet 14:28:07 ok @jpk68:matrix.org review will be added there for 11143 14:32:57 Yeah, codex would be a bit better if you lobotomize the AI > <@ofrnxmr:xmr.mx> fable is even worse 14:41:20 please ban probably_wrong for spamming the channel with LLM slop, or at least have it DM whoever requests it, or post a pastebin link ffs 14:41:21 @thomasbuilds:matrix.org: Sure, I just meant in general 14:41:55 The second message which was shorter is not fine, it's still paragraphs of slop spammed to the channel 14:42:09 Same with the next one .-. 14:42:17 @kayabanerve:matrix.org: jeeze calm down it has been moved to #monero-slop:monero.social 14:43:04 @thomasbuilds:matrix.org: I think my message was fine. Thanks for confirming you're no longer spamming a public room. 15:11:01 @kayabanerve:matrix.org #monero-slop:monero.social is public though 😝 15:12:33 but the purpose of a spam room is spam, so spam in a spam room isn't spam but on-topic :p 17:45:50 j-berman opened pull request #11168: blockchain: limit offsets cache size 17:45:51 > https://github.com/monero-project/monero/pull/11168 18:45:50 thomasbuilds opened pull request #11169: wallet2: fix data races in refresh error handlers 18:45:51 > https://github.com/monero-project/monero/pull/11169