17:00:18 -xmr-pr- mj-xmr opened pull request #3858: CMake: clearer sep. between the library and executable code
17:00:18 -xmr-pr- > https://github.com/monero-project/monero-gui/pull/3858
17:35:23 <mj-xmr[m]> Re: #3858 I'm trying to bring some structure there, because I'd like to have it easier to quickly check the new features visually.
17:35:40 <mj-xmr[m]> and for other reasons, like testability.
19:33:59 <selsta> mj-xmr[m]: I'm fine with adding structure, but what do you mean with "easier to quickly check the new features visually" ?
19:53:13 <mj-xmr[m]> selsta: it means, that it's a prelude of my further reviews. I'd like to be able to quickly checkout a given branch and compile + run. Without working linking this takes some space. In the current situation I have to rely on you approving the feature, while I can only check if it looks technically good from the code alone. I hope it explains it.
19:53:32 <mj-xmr[m]> *without a working dynamic linking.
19:57:50 <selsta> hmm I don't follow
19:58:01 <selsta> what happens when you checkout a branch now?
19:59:38 <mj-xmr[m]> selsta:  I can't link dynamically, because the installed (in `bin`) monero-wallet-qt can't find any dynamic libraries, while all the core executables can.
20:07:18 <selsta> ok and just doing `make` is too slow?
20:15:35 <mj-xmr[m]> Let's say that it could be somehow faster. But the fact that the whole project behaves differently than Core, even if I try to force it, sounds like there may be more bugs to uncover. And this can be done only after enforcing some structure.
20:16:30 <mj-xmr[m]> *done = uncovered.