19:47:05 <selsta> sech1: did you test the installers/windows/Monero.iss changes in your PR?
19:47:31 <sech1> yes, I compiled the installer in Inno Setup
19:48:01 <selsta> ok good
19:48:30 <sech1> the only problem I had is "The [Setup] section must include an AppVersion or AppVerName directive."
19:48:34 <sech1> even without my changes
19:48:47 <sech1> GetFileVersion("bin\monero-wallet-gui.exe") didn't work for some reason
19:49:09 <selsta> oh yes, i edit that manually to 0.17.3.1
19:49:11 <selsta> or whatever
19:49:18 <sech1> So I replaced it with "0.17.3.2", compiled and installed everything
19:49:27 <sech1> then tested that p2pool works without admin privileges
19:49:42 <selsta> on other OS nothing should have changed?
19:50:08 <selsta> directory wise
19:50:23 <sech1> Same directory on other OS
19:50:27 <selsta> ok good
19:50:39 <sech1> But it should be tested too
19:51:05 <selsta> yes will test
19:51:07 <sech1> because I changed p2pool unpacking command parameters (full paths there now)
19:51:12 <selsta> on mac a tleast