00:01:29 <luigi1112> k
02:34:16 <luigi1112> .merges
02:34:16 -xmr-pr- 3972
15:23:23 <selsta> sech1: https://github.com/monero-project/monero-gui/pull/3933
15:23:36 <selsta> one thing i noticed is that it creates the p2pool folder on startup, even if p2pool isn't downloaded / installed
15:23:39 <selsta> is that intentional?
15:24:14 <sech1> do you mean during install?
15:24:23 <sech1> It's the only way to set file permissions
15:24:24 <selsta> no, if you start the .exe
15:24:29 <selsta> no installer
15:25:27 <selsta> but it seems intentional since you added the code to the constructor
15:25:41 <selsta> i was just confused why a folder suddenly showed up on first startup
15:26:02 <sech1> ah, it' probably because P2PoolManager constructor checks for it
15:26:40 <sech1> https://github.com/monero-project/monero-gui/blob/master/src/p2pool/P2PoolManager.cpp#L230
15:27:32 <sech1> This check can be probably moved to P2PoolManager::download()
15:28:04 <selsta> yea would be ideal for the next version
15:28:22 <sech1> but the installer creates this folder anyway
15:28:29 <sech1> with proper file permissions
15:28:38 <selsta> we offer installer and .zip