02:53:29 perhaps the GUI should include a dialogue on first startup regarding storing the blockchain in a custom location 06:48:21 selsta: hello. I'm now trying to make so that the appdata always has an actual release date. https://github.com/BigmenPixel0/monero-gui/blob/flatpak/flatpak/CMakeLists.txt... (full message at ) 06:49:56 s/an/a/, s/error/mistake/ 06:52:25 this will set the release date to when we touched the cmakelists / last git commit, this can be up to a week earlier than the actual release date 06:53:45 setting it to when CI is running would make more sense to me 06:54:52 selsta: But there is also another method with git. 06:55:25 Something wrong in it? 06:56:18 Oops, I understand now. 06:56:32 yes, it won't match with the actual release date since time between last tag and the actual release date can differ by up to a week 06:56:54 selsta: So is it possible to use `date` command there? 06:58:02 https://unix.stackexchange.com/questions/721016/use-sed-to-find-and-replace-a-word-with-the-current-date-while-using-a-sed-fil 06:58:06 I would do it similarly to this 06:58:16 Add a `` placeholder 06:58:35 and then run `sed -rf s//$(date '+%Y%m%d')/g` from CI 07:02:39 And what about $(date '+%Y-%m-%d')? 07:05:15 I don't fully understand how should it work. Get the current date (when CI is working) or timestamp of some file? 07:29:16 "Add a `` placeholder" <- Where? 07:33:00 https://github.com/monero-project/monero-gui/pull/4151/files#diff-4169d3f1f4034bd931225c9222a1ebbc092f77229807d05738b21141b4d84ff9R59 07:33:05 inside the date thing 07:33:27 then you run the sed command so that it replaces with the real date 07:33:38 this is assuming you want to only show the latest version 07:40:31 "then you run the sed command..." <- That looks good, without env. 07:41:11 the command i posted was only an example, you will have to adapt it 08:12:24 "the command i posted was only an..." <- This works:... (full message at ) 08:12:51 I meant without CMake at all 08:13:32 So now it's need to select a "trigger" for cmake subdirectory. Is existing of #FLATPAK_ID good? 08:13:46 selsta: Sorry, I needed to say it. 08:13:55 s/#FLATPAK_ID/$FLATPAK\_ID/ 08:14:38 I wouldn't use CMake for this and just run sed from here https://github.com/monero-project/monero-gui/pull/4151/files#diff-0204cdf2cea745a516b9aa6ee61205f02d0738627a1ae7a74c7800865c3a8115R22 08:15:54 selsta: Also it will need to get the version there. 08:16:05 * it will be need to 08:17:29 ${{ github.event.release.tag_name }} 08:17:47 can also be done from github actions without CMake 08:19:08 selsta: Good, I will do so. 08:22:31 so after each `uses: actions/checkout@v3` I would run 2 sed commands, one that replaces with the current date and one that adds `${{ github.event.release.tag_name }}` 08:22:48 you have a version placeholder and a date placeholder 08:28:53 "you have a version placeholder..." <- ```... (full message at ) 08:29:11 Oops, wait. 08:29:27 the version is wrong 08:29:59 sed -i 's//${{ github.event.release.tag_name }}/g' file 08:30:00 selsta: ``` 08:30:00 sed -i 's//'"${{ github.event.release.tag_name }}"'/g' 08:30:00 ``` 08:32:11 - name: Add version and date 08:32:11 run: | 08:32:11 sed -i 's//${{ github.event.release.tag_name }}/g' monero-gui/flatpak/org.getmonero.Monero.metainfo.xml 08:32:11 sed -i 's//'"$(date '+%F')"'/g' monero-gui/flatpak/org.getmonero.Monero.metainfo.xml 08:32:51 flatpak directory won't be. 08:32:57 * flatpak directory won't be in the final. 09:44:43 looks good assuming the path is correct 09:44:53 and you have to add this after each checkout 10:14:06 "and you have to add this after..." <- Maybe only after the latest? 10:14:23 Prt 3 10:14:25 * Part 3 10:14:46 I don't know when it uses these .xml files 10:14:48 Because the appdata will install there. 10:14:59 then adding it in part3 should be enough 10:15:09 selsta: Ok. 10:16:40 So are there any problems also? I will need to add checkers and everything is fine..? 10:20:11 can you clarify? problems where? 10:20:24 selsta: Problems to push 10:20:42 you can update the PR 10:22:08 selsta: Well, I will update when it works. I'm now at the `flatpak` branch for testing.