02:18:54 <m-relay> <j​effro256:monero.social> Hmmmm i wrote that line which is errorimg out
02:19:28 <m-relay> <j​effro256:monero.social> Does Monero GUI set the c++ standard version somewhere in its CMakeLists?
02:19:45 <m-relay> <j​effro256:monero.social> Because that error will trip if the C++ version is too low
02:22:10 <m-relay> <j​effro256:monero.social> SNeedlewoods @sneedlewoods:monero.social: which CPP file is being compiled when that error occurs
03:43:15 <m-relay> <t​obtoht:monero.social> SNeedlewoods: cherry-pick https://github.com/monero-project/monero-gui/pull/4381
13:37:38 <m-relay> <s​needlewoods:monero.social> jeffro256: I tried with a fresh clone, the error pops up after this message:
13:37:40 <m-relay> <s​needlewoods:monero.social> ```
13:37:42 <m-relay> <s​needlewoods:monero.social> Building CXX object monero/src/common/CMakeFiles/obj_common.dir/threadpool.cpp.o
13:37:44 <m-relay> <s​needlewoods:monero.social> ```
13:41:32 <m-relay> <s​needlewoods:monero.social> tobtoht: it seems something strange is going on, tried to build with the cherry-picked PR (`make debug`), but now when trying to run monero-wallet-gui it complains that `libwallet_api.so` is missing (it's not in `build/lib/` or to be more precise there is not `lib/` in `build/`)
13:41:32 <m-relay> <s​needlewoods:monero.social> I'm trying to figure out why this happens and will report back
14:30:09 <m-relay> <s​needlewoods:monero.social> I haven't figured out the "why", but to reproduce missing libwallet_api.a:
14:30:10 <m-relay> <s​needlewoods:monero.social> 1. `git clone --recursive https://github.com/monero-project/monero-gui && cd monero-gui`
14:30:12 <m-relay> <s​needlewoods:monero.social> 2. add changes from #4381
14:30:14 <m-relay> <s​needlewoods:monero.social> 3. `make debug && cd build/bin && ./monero-wallet-gui`
14:30:16 <m-relay> <s​needlewoods:monero.social> To make it work, run `make` before `make debug`, if `make debug` was used first you can run `rm -rf build/ && git submodule update --init --force --recursive && make && make debug`, `make` alone won't fix it.