02:31:31 <plowsof> we had issues with freetype git repo being offline, i noticed Dockerfile.windows uses --qt-freetype https://doc.qt.io/qt-5/configure-options.html#third-party-libraries , uses freetype bundled within qt whereas the Linux dockerfile clones a freetype git repo instead hm 
02:58:57 <plowsof> -opengl desktop for linux and -opengl dynamic in windows docker (dynamic seems the sane option https://doc.qt.io/qt-5/windows-requirements.html#dynamically-loading-graphics-drivers)
14:06:13 <selsta> this stuff was setup by xiphon ages ago
15:08:37 <selsta> tobtoht_: https://github.com/monero-project/monero-gui/actions/runs/14146373464/job/39634172034?pr=4426
15:08:45 <selsta> is the compiler too old for this syntax?
15:10:14 <m-relay> <t​zadiko:matrix.org> That's structured bindings introduced in C++17
15:10:57 <m-relay> <t​zadiko:matrix.org> Builds fine on Monero. Is the compiler the Monero-GUI uses different?
15:11:21 <selsta> we use C++ 14 in release branch from what i remember
15:11:36 <selsta> though i'm confused why this passed CI
15:17:04 <m-relay> <t​zadiko:matrix.org> Why can't we upgrade the compiler the Monero-GUI uses to use the same one used in Monero project? Is there a reason not to?
15:19:30 <selsta> it's not about the compiler, we have C++17 code in a C++14 project https://github.com/monero-project/monero/blob/release-v0.18/CMakeLists.txt#L99
15:21:02 <m-relay> <t​obtoht:monero.social> also thoroughly confused how this passed ci
15:23:05 <m-relay> <t​zadiko:matrix.org> Where is the build code located for the pipeline located?
15:23:41 <m-relay> <t​zadiko:matrix.org> Is it the Dockerfile?
15:23:50 <m-relay> <t​zadiko:matrix.org> Oh it's probably not, NVM
15:24:39 <m-relay> <t​obtoht:monero.social> https://github.com/monero-project/monero-gui/blob/master/Dockerfile.linux
15:24:48 <m-relay> <t​obtoht:monero.social> Uses Ubuntu 16.04 base image with gcc 5, which is ancient
15:25:20 <m-relay> <t​obtoht:monero.social> we could try bumping it to 18.04 and see how much stuff breaks
15:27:47 <m-relay> <t​zadiko:matrix.org> LOL, yeah I see the build-Ubuntu builds with GNU 13 and the build-docker-linux does with GNU 5.4
15:30:16 <selsta> i will try updating the base imagfe
15:30:18 <selsta> image
15:54:57 <m-relay> <t​obtoht:monero.social> i was able to build with 18.04
15:54:59 <m-relay> <t​obtoht:monero.social> 4c54ea41ca869e89fb5e944f0e3f5243ed27d1e1963ab9d7ca3c4594c01cdc76  monero-wallet-gui
15:59:18 <m-relay> <t​obtoht:monero.social> forgot to run git submodule update
15:59:22 <m-relay> <t​obtoht:monero.social> f621c7d8005e257c9ee099311bd965740b4be99b55458a0147858dbb8c4c44f1  monero-wallet-gui
16:26:06 <selsta> alternatively we could apply a patch in the dockerfile but also 16.04 is ancient
17:15:15 <selsta> tobtoht_: https://github.com/monero-project/monero-gui/pull/4428
17:17:22 <m-relay> <t​obtoht:monero.social> hashes from ci match my local build (https://github.com/tobtoht/monero-gui/actions/runs/14147236386)
17:17:36 <m-relay> <t​obtoht:monero.social> approved
17:17:41 <m-relay> <t​obtoht:monero.social> i think patching will get messy since it uses the bind-mounted monero submodule
17:18:07 <selsta> .merge+ 4426 4427 4428
17:18:07 <xmr-pr> Added
17:18:22 <selsta> now i have to find out why this suddenly fails https://github.com/selsta/monero-gui/actions/runs/14147258151/job/39636066260#step:7:125
17:19:26 <m-relay> <t​obtoht:monero.social> not critical for release since you build gui locally right?
17:19:33 <m-relay> <t​obtoht:monero.social> on macos i mean
17:20:31 <selsta> yes not critical
18:02:24 <m-relay> <t​zadiko:matrix.org> Curious how you knew you needed libpng instead of libpng12
18:03:21 <selsta> libpng12 did not exist and libpng was the next closest thing
18:03:32 <tobtoht_> i guessed the same lol