16:19:01 Would someone mind submitting this to #4573? 16:19:02 https://paste.debian.net/plainh/b68d7733 16:54:41 Another small one: https://paste.debian.net/plainh/d4d596d7 17:52:14 selsta: Sorry for the ping, I was just wondering if you would be willing 17:52:38 or someone else you know of :) 17:54:20 it would probably be best if someone takes over the whole PR since the person in 4573 doesn't want to continue anymore 17:54:45 I would, but unfortunately GitHub kind of hates me 17:54:51 and my account is still (falsely) suspended 17:55:45 did you mean with submitting adding a comment with the patch links, or pasting the patches itself into a comment? 17:56:07 Anything works 17:57:49 The CI stuff is kind of beyond me, but I think I can make some decent progress on the rest of the PR 18:00:46 CI stuff is just getting it to build on all OS 18:01:26 Yes, I know, I'm just not sure I'm super qualified to fix that 18:01:57 added a comment 18:02:20 Thanks :) 18:58:15 selsta if you want i can take over 18:59:08 whatsayjose1980-: I misread the comment in 4573, seems they are still working on it just not interested in fixing CI at the moment 18:59:09 w​hatsayjose1980-: Are you the guy that submitted this PR yesterday? 18:59:11 https://github.com/monero-project/monero/pull/10370 18:59:46 yes 19:00:12 Interesting... 19:00:13 selsta ok 19:02:33 m-relay_ interesting as in? 19:04:15 Uhh, it was an interesting PR 19:07:53 m-relay_ as in? 19:08:09 i am working on something for a private vested group 19:08:28 large swathes of conversion 19:10:38 without the essence mbweb yet private 19:29:15 ok 19:29:54 @plowof sorry for bothering you yesterday mate 19:30:12 it was the highlight of my week, thank you 19:30:23 plowsof :) 19:30:45 but i didnt change anything tbh 19:30:55 they were as they were 19:32:46 thanks mate 19:32:53 logging out now 19:33:14 nice to talk to you, have a wonderful evening 19:33:26 mine is half past night 19:33:51 cheers mate enjoy tthe eve, night is young for you 21:05:51 A few more fixes: https://paste.debian.net/plainh/e6f39911 21:52:25 Shared 21:52:48 There may be more coming ;) 22:06:36 Finish and sell all at once? 22:07:07 Maybe, I guess 22:07:23 The problem is, if two people are working on it, the other person might do work I already finished 22:07:31 or vice versa 22:07:34 I doubt the pr is going to be merged eith its 50+ commits not squashed 22:07:41 So fix conflicts :P 22:08:01 Fair point, but still, it would waste time 22:08:17 This should have been done, like, yesterday 22:08:30 The pr or the migration to qt6? 22:08:56 Qt6 migration. I don't mean to point fingers or anything 22:09:07 Qt5 was deprecated like a year ago 22:09:10 I dont know anything about qt but is this pr even the right way to go about it? 22:09:14 Seems rather messy 22:09:30 Youd think this can be done a lot cleaner(?) 22:09:35 How else would you do it? The new Qt version is full of a huge number of breaking changes 22:09:39 How so? 22:09:44 ^ 22:10:05 Twas a question 22:10:24 My bad :) 22:10:43 I just see 144 files changes and think "this aint getting reviewed " 22:12:03 Make feather wallet look like the gui? :P 22:13:49 And i see stuff like this and wonder "tf?" 22:13:50 ``` 22:13:52 run: DEV_MODE=ON make release -j3 22:13:54 run: DEV_MODE=ON make release -j"$(sysctl -n hw.ncpu)" 22:13:56 ``` 22:13:58 A few lines lower 22:14:00 ``` 22:14:02 run: DEV_MODE=ON make release -j3 22:14:04 run: y make release -j"$(nproc)" 22:14:06 ``` 22:14:08 Like why inconsist 22:14:10 Ent 22:14:28 Yeah, not sure 22:14:30 And `run: y make release -j"$(nproc)"` is a typo? 22:14:32 https://matrix.monero.social/_matrix/media/v1/download/matrix.org/zUlMvHQzzcUfgjCIfXprPKGO 22:14:42 Left is Qt6, right is current release 22:14:52 Still some work to do with shadows and stuff 22:15:08 and the whole balance card thing is just not there (?) 22:15:50 #startfresh 22:15:56 We might be in for a slight unintentional redesign :) 22:17:08 The CI changes dont seem to all be coherent 22:17:35 OP did say that they couldn't really fix it 22:17:37 https://github.com/monero-project/monero-gui/pull/4573#issuecomment-4081857258 22:17:42 So i guess my question is mainly, is the rest of the pr somethimg we shoukd be buikding off of? 22:18:10 The ci isnt juat annoying to fix, it looks like it was broken 22:18:27 Revert all changes to it, and do it properly :D 22:19:08 I guess I can always rebase to my fork on Codeberg, and then submit from there or something 22:19:15 A couple sane changes a bunch lf random unnecessary ones dont inspire confidence for the rest of the pr 22:19:39 Its easy for ie me to clobe for codeberg fork and pish the branch to my github 22:19:53 Might be rude to take credit for it though, since I will have done maybe 10 out of the 54 commits 22:19:57 Thanks :) 22:21:27 Still(wondering): what llm does those commit titles 22:22:28 OP said they cant be bothered to fix it right now, but their git is hidden so i cant see their work 22:39:56 plowsof: Not everything is vibecoded... maybe some of us are just NPCs :) 22:42:44 ofrnxmr Got another one for you 22:42:45 https://paste.debian.net/plainh/858d7974 23:06:22 I would ideally like Qt 5 and 6 support simultaneously but not sure if that's possible