01:19:57 linking to dbus from ubuntu packages gives the systemd error/ requirement. 01:19:57 therefore i have used the same pattern as for other dependencies in the dockerfile to git clone the source and build it statically without the systemd requirement. 01:19:57 the pr is ready for review 09:41:52 waozi: please squash and also undo unrelated newline changes 10:07:20 .merge+ 4618 10:07:20 Added 13:12:17 selsta: done 13:19:34 nvm i don't know how to squash i'll just d o a fresh pr again 13:20:34 git rebase --interactive master 13:20:42 and then set them to s 13:20:48 apart from the main commut 13:20:51 commit 13:24:14 i tried that, it showed all the commits from the last time i had as well, tried to delete them since i got a comlpained about that last time and now everything is gone so i mut have made a mistake along the way trying to squash it. 13:24:14 have to start from zero 13:25:05 i'll delete my fork and start from scratch so there are no extra artifacts or unwanted commits 14:22:20 here third attempt at not having extra commits so it can be reviewed 14:22:20 https://github.com/monero-project/monero-gui/pull/4622 17:41:23 .merges 17:41:23 4618 17:47:37 @waozi:matrix.org What I just do is this: say you have 3 commits you want to squash into one. Do git rebase -i HEAD~3 and then change all commit lines from 'pick' to 'squash' except the first one 17:47:50 And then also remove the commit messages in the next screen, aside from the one you want to keep 17:48:58 https://www.youtube.com/watch?v=IlFK3JGCDqU 21:57:31 thanks, my mistake was rebasing with master, since my master branch had the old commits we already avoided in the second pr, and by rebasing with that it became a mess 21:58:16 moving forward we now have a pr that has no further commits, just 1 commit 22:00:19 is this the default practice if i have to do any change to the pr is to always squash into 1 commit? just so i know for next time 22:08:35 @waozi:matrix.org: Yes 22:12:53 You should also probably checkout a new branch from master for each PR, so that all your commits don't get tangled together 23:01:59 s/probably/definitely 23:30:25 okay thanks