08:59:56 <br-m> <321bob321> https://github.com/monero-project/monero-gui/issues/4533
08:59:56 <br-m> <321bob321> got the same issue again. Not sure if the ledger update fixed it or closing and opening fixed it
17:20:36 <selsta> -,merge+ 4627
17:21:49 <plowsof> ;_;
17:22:38 <selsta> .merge+ 4627
17:22:40 <selsta> lol
18:29:13 <selsta> .merge+ 4631
18:29:13 <xmr-pr> Added
18:31:59 <br-m> <jpk68:matrix.org> Hear ye, hear ye, do we have any opinions on this UI layout?
18:32:12 <br-m> <jpk68:matrix.org> https://mrelay.p2pool.observer/m/matrix.org/gYbxpnrxMAZciUWEyezsoySj.png (clipboard.png)
18:32:44 <br-m> <jpk68:matrix.org> Another variant:
18:32:49 <br-m> <jpk68:matrix.org> https://mrelay.p2pool.observer/m/matrix.org/cofmKJEjMajDPWlZWpMmjfOH.png (clipboard.png)
18:41:11 <br-m> <jpk68:matrix.org> The tabs could also look like the selection in SettingsNode, maybe
18:41:45 <selsta> i prefer the first
18:50:55 <br-m> <ravfx:xmr.mx> Let me know where there is a new version to test on windows platform!
18:53:35 <br-m> <jpk68:matrix.org> Here is yet another option:
18:53:40 <br-m> <jpk68:matrix.org> https://mrelay.p2pool.observer/m/matrix.org/UuXBBSCCMNRrIloTATRMGmSq.png (clipboard.png)
18:59:47 <br-m> <jpk68:matrix.org> This one could also use the other I2P logo rather than the mascot
19:07:16 <selsta> should socks5 setting be moved there from interface?
19:07:44 <selsta> so you have none, socks5, i2p
19:07:59 <selsta> i think the last screenshot has the best design so far
19:10:00 <br-m> <jpk68:matrix.org> selsta: It's hard to gauge whether or not that will be easy to do. But if it is, I don't see why not
19:18:06 <selsta> should be easy, just design wise it needs be be clear that i2p is a daemon setting while socks5 is a gui setting
19:18:38 <br-m> <jpk68:matrix.org> How would you give an indication of that other than just text?
19:20:57 <selsta> you could also have socks5 gui + i2p hmm so ignore for now
19:53:54 <br-m> <ofrnxmr:xmr.mx> Does socks5 also apply to --proxy on monerod?
19:54:55 <br-m> <ofrnxmr:xmr.mx> I think the problem with the screen is that it it is a choice between i2p and nothing, when you can technically run i2p + onion + tor(socks)
19:55:59 <br-m> <ofrnxmr:xmr.mx> So perhaps, if moving a socks option there, it should be for the daemon's --proxy
19:58:51 <selsta> no, socks5 does not apply --proxy to monerod
20:02:53 <br-m> <ofrnxmr:xmr.mx> Whereas the main setting's socks option is for the wallet?
20:03:22 <selsta> yes, when using a remote node, and for stuff like fiat price
20:08:07 <br-m> <jpk68:matrix.org> ATM I think I will go with what's in the last screenshot, without SOCKS5
20:27:38 <br-m> <ofrnxmr:xmr.mx> The last screenshot will need to be redone as soon as someone adds proxy or onion support
20:28:00 <br-m> <ofrnxmr:xmr.mx> So i'd nack on premise that it should expect to be have those added at some point
20:29:25 <br-m> <jpk68:matrix.org> Okay, so the first then?
20:30:22 <selsta> well the first also can only select one
20:30:31 <selsta> so it's not better just different design
20:31:24 <br-m> <jpk68:matrix.org> How do you suggest doing this then?
20:40:04 <selsta> I don't know, thinking about this has always overwhelmed me that's why there was never any proper Tor / I2P integration and people had to set custom daemon flags.
20:40:46 <selsta> socks5 can apply to daemon or wallet, tor can apply to daemon-wide and tx only, i2p has sam and socks5 and tx only
20:41:12 <selsta> getting this done in a neat way is next to impossible or I don't have the creativity for it
20:41:32 <selsta> also settings can be combined but only with specific rules
20:44:07 <br-m> <jpk68:matrix.org> Okay, good to know. I still think one of the three sent above should be fine for now, as it works just like it should
20:44:24 <br-m> <jpk68:matrix.org> The anonymity networks tab only appears in the 'Advanced' mode of the GUI anyways
20:44:40 <br-m> <jpk68:matrix.org> If there are breaking changes later, well, we can just deal with that when it happens :P
20:45:58 <selsta> Why is I2P SAM getting an entry but not Tor for example? Like that needs a rationale before it's merged. And I know you are funded to add I2P SAM support, I'm talking about from a GUI maintainer perspective.
20:47:27 <br-m> <jpk68:matrix.org> Because Tor is just a SOCKS proxy, no?
20:47:37 <br-m> <jpk68:matrix.org> There is also the Tor Control protocol but we don't support that (yet)
20:48:20 <selsta> Yes, but how is this relevant for the end user if it's using SOCKS5 or not for having Tor integration in the GUI?
20:48:56 <selsta> I don't see anything inherently relevant for SAM that it needs a GUI entry while Tor does not, both just set IP / port?
20:50:38 <br-m> <jpk68:matrix.org> The SAM support baked into the GUI (specifically, the page for it) exists to allow the user to have only the GUI software configured, without requiring outside configuration. If you want to use Tor or I2P SOCKS, you download the software for that and manually set up the SOCKS tunnel(s). For SAM, you just get the software running without the second step
20:51:17 <br-m> <jpk68:matrix.org> IMO the existence of such a pathway for 'easy' setup justifies them being separate at this point in time
20:52:24 <selsta> but for Tor you just have to run it and it already has a default IP / port, I never saw how SAM is easier but maybe I'm missing something
20:53:38 <selsta> I just don't want to merge something that is incompatible with other settings design wise and will need to be reworked in the future
20:54:17 <br-m> <jpk68:matrix.org> Fair, but if that's the case then it would be good to have some criteria for that :)
20:54:35 <selsta> design wise, I think it makes most sense to add it to Settings -> Node
20:54:43 <br-m> <jpk68:matrix.org> I would not mind reworking general proxy stuff in the GUI, but that seems to be beyond the scope of this current work
20:54:56 <selsta> the bootstrap daemon address / port box is getting removed
20:56:12 <selsta> that makes it clear that the setting is applied to a local node and local node only
20:56:21 <selsta> having a separate tab makes it unclear where the setting is applied
20:56:35 <br-m> <jpk68:matrix.org> That does make sense