10:45:02 <xmr-pr> EntropyHoover opened issue #4686: Dead code in DaemonManager::start
10:45:03 <xmr-pr> > https://github.com/monero-project/monero-gui/issues/4686
11:41:29 <br-m> <entropyhoover:matrix.org> Also this piece of code seems redundant #ifndef Q_OS_WIN
11:41:29 <br-m> <entropyhoover:matrix.org>     arguments << "--detach";
11:41:29 <br-m> <entropyhoover:matrix.org> #endif
11:42:11 <br-m> <entropyhoover:matrix.org> If we are already doing     bool started = m_daemon->startDetached(m_monerod, arguments);
11:42:11 <br-m> <entropyhoover:matrix.org> in daemonManager.cpp?
11:47:41 <br-m> <ofrnxmr> @entropyhoover:matrix.org: https://github.com/monero-project/monero-gui/pull/4581
11:58:15 <br-m> <entropyhoover:matrix.org> Seems closed due to qt 6 migration? So the issue right now is waiting for the migration rewrite?
12:02:13 <br-m> <ofrnxmr> I think so
12:04:15 <br-m> <thomasbuilds:matrix.org> yeah
12:06:23 <br-m> <entropyhoover:matrix.org> So if I write code about this issue, should I create a separate pr or put in this https://github.com/monero-project/monero-gui/pull/4659?
14:32:38 <br-m> <ofrnxmr> you can build on top of 4659, or you can wait
14:33:00 <br-m> <ofrnxmr> Id just say try not to write something that will be invalidated shortly
16:52:04 <selsta> .merges
16:52:04 <xmr-pr> 4681 4682
16:53:22 <br-m> <jpk68:matrix.org> #4592 has an approval
16:53:25 <tobtoht> done
16:54:20 <br-m> <jpk68:matrix.org> #4685 and #4680 may be good as well
16:54:41 <br-m> <jpk68:matrix.org> #4679 needs another look
17:15:02 <xmr-pr> selsta opened pull request #4687: Sign: show signed message key type
17:15:03 <xmr-pr> > https://github.com/monero-project/monero-gui/pull/4687
17:30:59 <selsta> .merge+ 4679
17:30:59 <xmr-pr> Added
17:41:56 <selsta> .merge+ 4688
17:41:56 <xmr-pr> Added
18:17:42 <selsta> .merge+ 11199
18:17:42 <xmr-pr> Added
18:17:46 <selsta> .merge- 11199
18:17:46 <xmr-pr> Removed
19:17:15 <tobtoht> .merges
19:17:15 <xmr-pr> 4679 4688
19:18:43 <tobtoht> done