07:55:33 would be nice to merge 4659 10:03:25 we can't merge 4659 before we have v0.18.5.3 out 16:00:33 SChernykh opened pull request #4715: p2pool v4.18.1 16:00:34 > https://github.com/monero-project/monero-gui/pull/4715 17:17:20 For #4714 I think we should simply move the fiat option into a higher position in settings, this naturally gives the fiat selection more space 17:18:07 Selsta suggested make the dropdown box drop upwards, but I think this is tricky to implement, also very counter intuitive 17:20:44 Also we probably need to make the fiat selection menu horizontally wider, with the name of each currency actually behind the 3 letter symbol. Because the symbol alone might be confusing for the user 17:22:45 It is also very difficult to locate the currency by staring at the symbols. Add the according national flag before the currency symbol should make it much more intuitive. This could easily be done by AI 17:26:52 Also the best is to add a search bar, so users could type the currency name or symbol to locate the currency, without need to scroll the drop down menu. This would be more useful if we choose to add more fiat options in the future. 17:27:10 I could build a pr on top of your current one @jpk68:matrix.org if you are happy? 17:32:42 Personally, I don't think adding national flags, full names, or a search bar would be necessary or particularly useful. Surely anyone who intends to use this option will know what the ticker for their desired currency is? The settings only has to be enabled once, regardless 17:33:12 You're free to open a PR based on mine if you'd like, though :) 17:36:01 Regarding the comment from plowsof, even in the "worst" possible window orientation (from what I can tell), you can still see 4-5 currency options in the dropdown menu. I wouldn't be opposed to fixing this, though it seems fine as it is 17:44:55 @jpk68:matrix.org: Not so true, maybe things like usd is obvious, but not for smaller currencies. I have met many people in new zealand and they do not know nzd is their currency name. Also I think the flag - symbol - name is a pretty standard practice for locale displaying, also easy to implement, so better to just to stick to this? 17:48:00 > I have met many people in new zealand and they do not know nzd is their currency name. 17:48:00 I find that a bit hard to believe, and if it's true, that's pretty ridiculous 17:48:30 Why not just stick to the regular path, how the code is now? Feather and Electrum don't show the full 'prose' names of currencies 17:49:22 Also, that's going to create more future translation work. For example, is someone with their locale/language set to Spanish supposed to see "dólar americano" instead of "American dollar"? 17:51:20 @jpk68:matrix.org: You are right on this, maybe only add the flag to reduce the translation burden. I should work my idea out before the weekend, and we can see if it looks better? 17:52:30 No offense, but I don't think this is really an issue in any capacity. Why not just submit a patch to add flags after #4714 is merged, and see if people are receptive? 17:55:57 National flags dont always = currency afaik > <@entropyhoover:matrix.org> It is also very difficult to locate the currency by staring at the symbols. Add the according national flag before the currency symbol should make it much more intuitive. This could easily be done by AI 19:10:09 https://mrelay.p2pool.observer/m/matrix.org/gytXqiZzIwZaKYaRwLqdClRT.webm (Screencast from 22-09-26 20:03:41.webm) 19:11:25 y: head.y + head.heigh -> y: head.y - droplist.height 19:14:10 1 line fix, currency symbols? even easier, everything will be fine 19:15:17 i observed a 0.01~% difference today for the 'eur' price abstraction , should be ok lol 19:15:55 i have not tested merchant mode...... dont know much about it 19:19:18 merchant mode accepts an xmr value you manually enter, no need to test 19:22:50 NZD symbol is $ so thats not much help! 20:15:25 .merge+ 4715 20:15:25 Added