13:00:02 "https://github.com/monero-..." <- Yes. When we're discussing user facing warnings, it's a game of words. 13:00:32 ""Until @8149 is merged, this..." <- There's no experiment without 8149. It's 8149 which is the experiment (until we have sufficient review/work on it), 14:21:11 "Yes. When we're discussing..." <- wow 14:24:58 Gotta agree with kayabanerve here: the point of adding the CLI flag was to signal to the user: DON'T USE THIS YET UNLESS YOU WANT YOUR FUNDS STOLEN, so that's what kayabaNerve 's change does. Yes, it's a game of words, like all UX features. 14:25:14 "There's no experiment without 81..." <- blind merges - no experiment, audit on resubmit of pr - experiment; facepalm 14:25:28 I made that comment to say sure, it is, but that doesn't mean anything. 14:25:51 ooo123ooo1234567: 8149 wasn't merged due to still needing review and a few edits. 14:25:58 jeffro256[m]: it would be better to read before reviewing PRs, instead of discussing game of words in warnings 14:26:05 It's not being blindly merged. 14:26:08 > <@jeffro256:monero.social> Gotta agree with kayabanerve here: the point of adding the CLI flag was to signal to the user: DON'T USE THIS YET UNLESS YOU WANT YOUR FUNDS STOLEN, so that's what kayabaNerve 's change does. Yes, it's a game of words, like all UX features. 14:26:08 * it would be better to start code reading before reviewing PRs, instead of discussing game of words in warnings 14:26:35 I did submit a review for 8149 .-. 14:26:46 > it would be better to start code reading before reviewing PRs, instead of discussing game of words in warnings 14:26:47 It's also undeniable the current multisig is unsafe .-. 14:27:09 One is significanly easier to do than the other, and can be merged today 14:27:16 kayabanerve[m]: wow, what's the source of such undeniable fact ? 14:27:44 ooo123ooo1234567: ... do you want me to link Drijver's paper? 14:28:05 > wow, what's the source of such undeniable fact ? 14:28:05 lol 14:28:05 Or cite the issue I found within Monero multisig only 8149 fixes? 14:28:14 Or cite koe? 14:28:24 Are you suggesting the current multisig isn't unsafe? 14:28:29 You may be the most incompetent developer here if so. 14:38:14 "You may be the most incompetent..." <- discussing the most unimportant code in a test without reading it, parroting info found by others - competent, asking what's the source of problem fixed in resubmit of my pr - incompetent; facepalm 14:41:13 I don't know what resubmission you're referring to yet I'm literally not discussing any of your PRs right now. I'm discussing Monero's master which has had no changes to its signing process. 14:42:15 Your PR on the matter would fix one issue, and leave at least one other. koe's fixes all issues I know of, and may not handle ones I don't. 15:00:32 kayabanerve[m]: the burning bug was punted to a follow-up PR due to scope creep 15:01:40 burning issue* 15:01:41 "Your PR on the matter would..." <- indeed, sufficiently competent reply for MAGIC fund board member 15:02:58 UkoeHB: ... am I blind or did I pull up an old commit then? Or because I've read your exact code in the past with the hash construction, did I just mentally fill it in? 15:03:01 Regardless, that's problematic af for me. I'll try to review what happened in a few. 15:03:10 Also, I must say bickering with perfect-daemon is a waste of time and energy lol (not to mention basically spam). 15:03:13 kayabanerve[m]: wow, discussing PR without reading it's content 15:03:25 ooo123ooo1234567: I really don't care for your ad hominem attacks. 15:03:29 UkoeHB: True lol 15:04:14 I'll check my browser history in a few and see where I slipped. Not really acceptable on my end, so will work it out. 15:05:09 UkoeHB: indeed, wasting time and energy with professional auditors is much better 15:06:18 kayabanerve[m]: If you would read code / content of PRs then it would be possible to discuss it, otherwise you don't follow the context 15:06:46 I think I saw tx_secret_key and wrote it off, as an isolate expanded into the set of keys, forgetting that wallet2 separates into tx_secret and aux/additional .-. I'll update my comments. 15:07:08 > <@kayabanerve:matrix.org> I really don't care for your ad hominem attacks. 15:07:08 * If you would read code / content of PRs then it would be possible to discuss it, otherwise it's impossible without shared context 15:11:35 "Also, I must say bickering..." <- indeed, unimportant changes on top of resubmitted pr - not spam / not waste of time and energy 15:19:00 "Also, I must say bickering..." <- indeed, discussion about review process of PRs before merges is unimportant and waste of time and energy 15:30:01 "I really don't care for your..." <- is there any reason why it's acceptable to discuss code/PRs without reading them ? 17:05:18 please stop with the endless quoting / replies. it's making the channel undreadable. 17:05:44 ooo123ooo1234567: it's sufficient to just tag the person you're replying to 17:06:04 we can all scroll back if needed, to see the context. 17:21:14 https://github.com/matrix-org/matrix-appservice-irc/blob/develop/src/bridge/MatrixHandler.ts#L58, it's automatic decision of matrix-irc bridge whether to use just name or name + prefix 17:21:41 from matrix side it's always reply to msg