00:07:05 DataHoarder[m]: It's been applied to the spend-auth transcript and generators, and I was not planning to expand that to all of helioselene. 00:08:47 should it use its own personalization string, to prevent possible reuse across different context (though I don't see what benefit it'd bring) 00:09:18 it was applied to the hash to point, which affected the generators indeed 00:10:52 I was going through the codebase a few days ago and saw still some raw blake2b usages 00:12:57 In general, I'd say that's unnecessary. There were specific reasons for doing so for generators and the signature. 00:35:47 Apologies if this is not the best channel, but why include these headers here? 00:35:47 https://github.com/j-berman/monero/blob/99030fb93f0bcc01f0eaa485b464e0b9553b4683/src/fcmp_pp/fcmp_pp_rust/fcmp%2B%2B.h#L39-L40 00:36:46 stdint.h for uint8_t, stdalign for alignof? 00:36:57 it doesn't include other headers from elsewhere 00:37:11 I'm stupid, nevermind. I thought this was a C++ header 00:37:31 #ifdef __cplusplus :D 00:37:38 it's both, C++ and C :) 00:37:49 The first is deprecated in C++, and the other one could be instead 00:37:53 also, it's its own compiler unit 00:38:04 Yeah, I didn't realize it was supposed to be compatible with C, otherwise they could be changed 00:38:29 I think stdalign is a C++ keyword nopw 00:38:32 yeah, when exporting stuff for C-header consumption (always that #ifdef __cplusplus) it needs to either be C or have the includes also gated between #ifdef __cplusplus