16:33:30 https://github.com/monero-project/monero-site/pull/2156 plowsof ? What's the purpose of this pr? Looks like you just cherrypicked my commit and added stuff on top of it. You didn't even reference the already open pr anywhere. Seems like it's just going to be source of confusion. 16:48:32 ErC: forgot to add a ref as only posted it earlier (it replaces 2131) and is ready for review. ive deconstructed your pull request after the suggestions https://github.com/monero-project/monero-site/pull/2131 requested a diff history 16:49:24 so you take my pr and open a new one based on it without a word? Cool. 16:49:45 Your pr? Your commits are creditted from what i can see 16:50:33 i and others made a word in 2131, so rather take action 16:51:30 That's going to be a waste of time. Still, i wished you had a minimum of courtesy and talk to me or make a comment 16:51:43 he did comment 16:51:47 As did hinto 16:51:53 And i asked here for the diffs as well 16:52:18 anyway. i'm not the maintainer, so you are wasting somebody else's time. 16:52:29 Talk abiut confusion and expecting reviewers to do local comparisons. 16:52:36 I already explained why adding those commits on github doesn't make sense and doesn't help with the review process 16:52:52 The reviewers disagree 16:52:58 people can look at the diff locally in 5 seconds. 16:53:02 Hence thr reviee comments 16:53:14 https://github.com/monero-project/monero-site/pull/2156/commits is very clean 16:54:44 The only time plowsof wasted was his own. 16:56:31 Asking people to download and do local diffs is asking people to waste their time. and you made far more changes than necessary, turning a paper wallet into an online generator without updating the documentation. 16:56:31 the issue: moneroaddress.org 16:56:31 the rest of this is a waste of time 16:58:03 Ive had a pr ready to delete the offending sections for well over a month. Hosting o getmonero =/= changing the use case of the page and writing instructions that dont work 16:58:09 Spelling errors and all 16:58:25 If your pr gets reviewed, it will need to be re-reviewed because you have to squash the commits first. So adding all commits like that it's literally a waste of time to anyone that will want to review your pr. And no, leaving the commits inside the repo so you guys can see the diff on github doesn't make sense 16:59:11 Anyway. Feel free to spend your time as you prefer. Still a minimal of courtesy was expected at least from plowsof. Not cool. 16:59:41 ive seen worse but hey, im not pointing fingers 17:07:06 i still welcome anyone to review my pr and suggest improvements. Also to the spelling errors 🙂 17:17:12 i wouldn't squash the commits in this case so that authorship information gets retained and it's clear what is from the original and what changes are applied 17:17:47 bridge dead again, reposting my comment 17:17:54 i wouldn't squash the commits in this case so that authorship information gets retained and it's clear what is from the original and what changes are applied 17:18:12 having separate commits doesn't hurt anyone in this case and is the preferred way to do it 17:19:21 i disagree, but if that's what people prefer, i would have preferred people talking to me directly instead of taking my pr and reopen it. 17:19:57 Just a reminder that only two reviewers expressed the preference, one i don't know and the other one is an extremely toxic individual that i ignore. 17:20:51 so, plowsof who opened the pr didn't mention once his preference too. 17:22:28 if more people would have preferred leaving the commit i would have added it without problems, even if i disagree with it as i did multiple times in past. 17:23:27 taking somebody elses's pr and reopening it changed behind his back it's not nice. This workgroup has been working fine and cooperative for years, let's not start now to behave shadily and in corners 17:40:01 i pinged luigi about the pr. If he agrees with leaving the commit i have no problem with adding it. 17:46:36 Erc please stop 17:47:04 it wasnt your pr to begin with anyway, so get off that horse and just be a professional. Not here to tear apart your lies or bad memory 17:50:37 wasn't my pr? 17:50:46 uh huh 17:51:01 You claimed it wasnt important. Wasnt even your idea 17:51:31 isn't it clear that i'm adapting moo's work on getmonero? There is a clear list of the changes i introduced 17:52:18 issue: moneroaddress.org 17:52:42 anyway i have no interest in talking to you. I just wished i would have been contacted by plowsof first. As i said adding the commit isn't an issue if many people prefer it or the maintainer does 17:52:44 what are we fighting about 17:52:55 kid stuff 17:52:56 :( 17:52:56 can we just ask moneromooo what he prefers 17:53:02 mooooo 17:53:15 Luigi its not jist the diffs 17:53:23 lol you are the maintainer. It's about what you prefer 😛 17:53:35 No it isnt 17:53:36 i don't think moo cares if we add an extra commit to getmonero 17:53:39 🙂 17:53:40 This isnt a dictatorship lol 17:56:47 All this time wasted when people could have written a couple of comments on github and avoid the issue altogether. 17:58:22 as the dictator I take too many opinions into account 17:59:04 I don't think cluttered history (by one commit?) is a big deal at all 18:00:01 Alright (it's a huge commit). Problem solved then. How easy could have been. i'll add the commit tomorrow 18:00:10 good work team 18:00:50 Thanks guys 18:00:51 worst dictator ever 18:00:54 And gals 18:01:07 lol. Creates the mess and then thanks people whose time he wasted 🙂 18:04:09 Lol dont be mad that youre doing what i tokd ya to 18:06:51 it's called collaborative development. In the last 3-0 or so years working on getmonero i added many things i disagreed with. I always tried to maintain a high level workgroup with open discussions and free exchange of feedback. 18:07:06 so, let's try to keep it that way 18:08:39 If these standsrs would have been kept. This wasted time would have been a couple of comments on a pr instead. 18:08:55 Theres comments on the pr 18:09:02 Maybe you cant see them or something? 18:10:12 there are two comments. One if from you, which i ignore and the other one is from somebody i don't know. No, that's not enough for making me change a pr to something i disagree with. A higher amount or the maintainer will do it, as you have seen. Being collaborative instead of distructive can be easy 18:10:29 Nvm. You ignored becauae you didnt recognize hinto. And plowsof first comment came through in an email but i couldnt find it on github 18:11:08 Ignore me now but listen 5 mins earloer 18:11:14 So when i find your errors, you fix en 18:11:40 but i ask you to post the diff so i (and anyone else casually stolling by) can check that as well 18:12:00 as long as you behave toxic as fuck everything you say i ignore. So, keep that in mind 18:12:25 so why did you fix my reported issues 18:12:54 toxic? To bad actors 18:13:13 because they were legit and you reported them in a nice and respectful way. 18:13:31 all the toxic stuff i just ignore 18:13:43 Asking for diffs is toxic? 18:14:15 Now youre doing it bcauae daddy told you to 18:15:31 as you know, im better at being as asshole than you. Keep it professional and i do the same. 22:43:17 https://www.getmonero.org/community/hangouts/ some matrix rooms addresses are oudated, namely #monero-website:matrix.org and #monero-research-lab:monero.social also worth considering delisting #monero-hardware since the channel has essentially been dead for years now 22:44:09 i think it'd also be cool to share the monero matrix space link in that page, maybe above - on Workgroup Resorces 22:45:38 https://www.getmonero.org/community/workgroups/ here too 23:38:02 charuto thanks, i think only monero-site is wrong? monero research lab is on monero.social 23:38:46 are we haveno.network or monero.social here 😵 23:38:56 plowsof11: the links for mrl are linking to monero-research-lab:matrix.org 23:39:07 which is a working alias, but probably not ideal. 23:40:08 * charuto uploaded an image: (31KiB) < https://libera.ems.host/_matrix/media/v3/download/matrix.org/zsgbnPjSMCdiZRydgOPTkeqw/image.png > 23:40:11 apparently, neither 23:40:29 ah sorry, thanks, will fix 23:41:10 and +1 for showing the monero space there 23:55:40 so the MATRIX button to link to https://matrix.to/#/#monerospace:monero.social? great idea