16:53:31 will use the mails icon from lucide > <@basses:matrix.org> there's also https://www.svgrepo.com/vectors/newsletter/ and https://www.svgrepo.com/vectors/news/ 17:02:42 redsh4de > git rev-parse --path-format=absolute --show-toplevel --git-path hooks --git-path info --git-dir 17:02:42 2026-Jan-19 16:57:18.840219 17:02:42 10.25 │ fatal: not a git repository (or any of the parent directories): .git 17:02:53 did some untested slop creep its way in somewhere 17:02:55 :D 17:03:31 this is likely due to my WSL crashing upon commit today 17:03:32 can help/post logs proper soon,,, need charger 17:03:38 corrupted some things, had to wipe everything 17:07:39 @basses:matrix.org: https://getmonero-redesign-impl.vercel.app/ar/blog/tags/releases/ 17:07:39 deployed localization updates for blog tags & the external resource button layour improvements 17:08:16 https://beta.monerodevs.org/downloads/ needs an info aside below cards saying something like "looking for mobile wallets or other community created wallets, visit /community (link) 17:09:15 https://mrelay.p2pool.observer/m/matrix.org/utxTakoCPkCaWatiLqoPYLLk.png (clipboard.png) 17:09:16 placed here 17:10:28 maybe above the cards so its more visible - similar pattern is already being used for the /hangouts and /workgroups pages 17:10:28 https://beta.monerodevs.org/community/workgroups/ 17:10:38 i'll try both and see how it looks 17:11:17 https://paste.debian.net/hidden/d4a25448 17:11:55 ctrl+f fatal (to see the git line) 17:14:46 undefined '$NIXPACKS_PATH' also , hm 17:16:44 the deploy fails started with https://github.com/redsh4de/monero-site/commit/e5680ee5c9861deede00e6b1bcfb1b081a704832 , @ lefthook install 17:16:57 i see, it's the pre-commit hook installer 17:16:57 it's trying to install hooks to the .git folder, but it is missing 17:17:38 fix da hallucination 17:18:50 not a hallucination, CI=true works with github actions for CI to skip trying to install as GA automatically sets it as per lefthook docs, but i guess it doesn't work here due to the variable not being set 17:19:02 the shitty way to fix it is to add CI=true to the monerodevs deployment step 17:19:13 good way is to figure out a more platform agnostic way to skip it 17:47:45 @redsh4de:matrix.org: fwiw this is the recommended way: https://lefthook.dev/usage/envs/CI.html 17:49:11 I dont know how husky works, never used or looked into it 17:49:22 But whats wrong with traditional pre-commits? 17:49:45 They dont / shouldnt run or install except for manually 17:51:02 example https://github.com/basicswap/basicswap/pull/333 17:51:16 this might have changed, but iirc they are not version controlled 17:51:51 @ofrnxmr:xmr.mx: .pre-commit-config.yaml controls versions 17:52:23 i see, you mean the pre-commit package, was talking about the traditional .git/hooks folder setup 17:52:40 that was what i looked into first, but i didn't like the Python dependency 17:53:14 Husky/Lefthook can be executed directly from the Node package manager without needing to use pip - makes sense to use a solution like that when the whole codebase already uses NPM 17:53:51 precommits are installed locally, and run when making commits 17:54:27 So it shouldnt even be installing for the deployment 17:56:44 Linters = run on github ci 17:56:44 pre-commit = run locally when making commits 17:56:44 neither should have any effect on build or deploy, no? 17:57:05 Yes, that's why there was a CI env variable check which would skip the lefthook installation if it was true 17:57:05 Issue is that the monerodevs CI does not set the env variable to true, and lefthook doc assumes that most CI's would 17:57:05 I pushed a change that relies on the postinstall scripts instead of the prepare scripts with a filter. Not sure how they work under the hood, but maybe they have a smarter filtering 17:57:43 Im saying, none of these needs to be a part of the website 17:58:01 Shoukd be contained to .github/workflows and lint config files 17:59:08 running linters on ci should be exclusive ci job, not a build flag (?) 18:00:22 Right, it is like that - it's not a part of the build step 18:00:23 The issue here was that on package install to build the site, it was also trying to install the pre-commit package when it shouldn't 18:01:06 @redsh4de:matrix.org: looks like the postinstall scripts are smarter, this works 18:04:19 latest back up on https://beta.monerodevs.org/ 18:11:45 the PR causing the issue has a failing workflow @ CI / Build (push) 18:15:03 That was due to a different issue - I hadn't set the CI=true check in the prepare script, i added it after noticing the failing workflow 18:15:03 On CI, it installs only production packages via the --prod flag. lefthook is a developer depenency - not a package that is needed for production, so it was skipped. But the prepare script doesn't know that, so it tried to run the lefthook install command despite it not being installed, causing the error 18:15:36 https://mrelay.p2pool.observer/p/iPTdh94KNmhodzFh/1.txt (code snippet, 23 lines) 18:15:36 Anything here is skipped/not needed when building 18:54:06 added @basses:matrix.org, looks pretty good > <@redsh4de:matrix.org> i'll try both and see how it looks 18:54:06 https://beta.monerodevs.org/downloads/ 23:32:23 @redsh4de:matrix.org can you ELI5 me on how to install the pre-commit hooks for the repo?