13:00:52 nahuhh opened pull request #2611: ci: add pr previews workflow 13:00:53 > https://github.com/monero-project/monero-site/pull/2611 15:29:28 @redsh4de:matrix.org i think the part of the workflow that creates a PR to update the core.json needs to be updated to work on beta branch 15:29:50 I messed with it last week and couldnt get it to open a pr on my own repo 15:31:08 All i tried was 15:31:08 - if: github.ref == format('refs/heads/{0}', github.event.repository.default_branch) 15:31:08 + if: github.ref == 'refs/heads/beta' || github.ref == format('refs/heads/{0}', github.event.repository.default_branch) 15:33:35 And would the monero-project repos are protected so i'm not sure that the workflow would even be able to create a branch for this cc plowsof 15:34:35 if so, maybe can be changed to comment a diff that needs to be applied 16:30:02 yeah ill have to change it to target whichever branch hashes.txt was pushed to 16:30:05 instead of the default one 16:42:00 @ofrnxmr:xmr.mx: yeah if the workflow settings are read-only & workflows arent permitted to make PRs, the PR step won't work 16:42:09 i had these enabled on the original repo 16:42:13 https://mrelay.p2pool.observer/m/matrix.org/fZSFRKfWViiQcyoYscxSfhBz.png (image.png) 17:51:14 We had a problem with the pr_comment workflow on the docs repo, because the monero-project org had write perms disabled 17:51:23 So enabling per-repo didnt work 17:51:35 But i guess we can try 17:52:02 I set this on my own repo, but it didnt work > <@ofrnxmr:xmr.mx> All i tried was 17:52:43 https://github.com/nahuhh/monero-site/commit/36de622ee7fc1a8cccd67c1bc01bd100d06c80af 20:19:42 @ofrnxmr:xmr.mx: what about something like this? https://github.com/redsh4de/monero-site/commit/29b0e467e245695c2a59728a84c60ddb2c2a7be3 20:21:06 should work on all branches regardless of default 20:21:58 I think the main issue would still be the no-write permissions 20:22:21 So this might work on our repos, but (likely) not on the monero-project one 20:22:38 yeah thats the big one, this should just make the trigger antifragile 20:23:28 probably a sane workaround would be to have actions bot comment on the pr with a diff to apply 20:23:35 i guess we can try it out and see if it works - if it won't, can add some kind of fallback that just adds a comment yeah 20:24:29 <321bob321> Chmod 777 20:26:38 @321bob321: We tried on docs and it was always respecting thr org settings 20:32:04 <321bob321> Time to move to forgejo