05:22:25 that 2639 PR is important to merge and simple to review, in case anyone wants to review it 09:27:41 @thomasbuilds:matrix.org: Why does it reformat so much? New plugin? 09:28:20 No update to plugin I think 09:33:57 prettier-plugin-astro is going v1 09:37:20 even if the site isnt launched, bulk reformatting of the repo screws up the blame 09:37:40 cant the prettier config be modifies to preserve the old formatting? 09:44:23 That plugin should be updated to v1 imo. Could it be done in a separate PR? Probably. But I mean it's not that long to review as is... 09:44:23 Also it would delay the important astro update v5 > 7 which currently holds big vulns 09:50:00 im not talking about udating to v1, just the prettier config 09:50:24 i would assume prettier's astro config can be given rules to not change the formatting 09:50:38 thats pretty intrusive for anyone who used it on any project til now 09:51:52 also not about review time, im specifically drawing a nit on the mass unrelated changes 10:01:04 Yeah I get what u mean though I personally prefer the new stricter formatting lol 10:01:04 Before HTML tags were inlined very ugly imo 10:04:10 For instance

{summary}

10:09:25 @ofrnxmr:xmr.mx: Having prettier installed as dep means we want to standardize coding style and before this PR it wasn't consistent 10:16:36 there is a disconnect we have to manage between production and a coolify instance running/building the site live 10:17:46 ideally the 'dependencies are pinned security++' marketing thing would allow production to build the site on a frozen / offline / for purpose machine that creates a zip file which is moved to machine that serves the raw html files 10:18:06 I'd like to have a coding style on monero repo too, would make code much easier to read lol but too late now 10:19:49 contirbutors have to run the software on their machines shuld they wish to run things locally - do we know what cve's are being patched and are there any to for containerisation to protect devs? 10:20:44 s/any to for containerisation/any containerisation methods like docker 10:22:58 dockerised for current site https://github.com/monero-project/monero-site/pull/2454 10:25:59 (CCS front end 'update to astro 7...8..9..10..11 with formatting including in each one for eternity sounds fun too lol) 10:28:09 Lol I think the issue is just that prettier-plugin-astro didn't properly have code formatting configured and waited until v1 to fix this 'breaking' change 10:28:47 Might be wrong im on a phone rn 💀 10:29:31 But this code formatting issue won't happen again imo 10:32:22 I dislike docker btw had many vulns involving stuff like root escalation privileges 10:34:34 Your argument is that you consider npm to possibility provide malicious deps so you'd like to containerize the entire thing? > contirbutors have to run the software on their machines shuld they wish to run things locally - do we know what cve's are being patched and are there any to for containerisation to protect devs? 10:35:12 doesnt npm have supply chain vulns a few times this year 10:35:17 didnt* 10:36:02 i remember hitting some prettier linting issues before, so i assume it was working? 10:37:21 fwiw the beta uses pnpm which has a stricter supply chain policy, iirc 14 days or something of the like as of v11 10:38:35 @ofrnxmr:xmr.mx: Yeah it did but imo it doesn't matter here really because devs that want to contribute to the website do pnpm install and they install the same packages on lockfile. So those packages should be safe since otherwise it would have been known they hold malicious code. Those malicious packages get busted super quick 10:39:37 it can be changed to preserve the legacy formatting, i can PR the new default formatting rules seperately after 2639 is merged > <@ofrnxmr:xmr.mx> i would assume prettier's astro config can be given rules to not change the formatting 10:40:02 so its just this which could be done in another PR? https://github.com/monero-project/monero-site/pull/2639/changes#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R56 10:40:30 @redsh4de:matrix.org Am I right here? > <@thomasbuilds:matrix.org> Lol I think the issue is just that prettier-plugin-astro didn't properly have code formatting configured and waited until v1 to fix this 'breaking' change 10:40:46 plowsof: the dep itself can be kept, can just tweak the config -> reformat which would keep the formatting as it is right now -> reduce the diff 10:41:43 @thomasbuilds:matrix.org: thats the gist of it yeah, it wasn't fully complete 10:42:38 Yeah so still needs to be fixed IMO for proper standardized coding style 10:43:04 agree, but its a good point that the formatting changes blow up the diff a bit too much 10:43:09 will make a seperate PR that depends on 2639 10:43:13 i would probably prefet the astro v7 update be split from the mass refactoring 10:45:37 make the PR to cuprate reformatting alot of code and see if its merged 10:48:59 🍎🍊 10:49:10 *looks at early beta site commits* nevermind 10:53:11 yes apples to oranges, its just git history of -site, who cares right? will CCS front end be treated better? 11:10:49 anyway, updated the PR 11:12:13 prettier-plugin-astro had to be downgraded back to the broken version for now 11:12:15 will be updated in the follow up 11:33:35 follow up in question, draft for now: https://github.com/monero-project/monero-site/pull/2705 11:45:33 redsh4de opened pull request #2705: deps: bump prettier-plugin-astro to 1.0 [beta] 11:45:34 > https://github.com/monero-project/monero-site/pull/2705